From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E3AC47254 for ; Fri, 8 May 2020 13:19:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEAB824954 for ; Fri, 8 May 2020 13:19:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEAB824954 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX2uC-0006HT-3u for qemu-devel@archiver.kernel.org; Fri, 08 May 2020 09:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX2su-00052a-L2 for qemu-devel@nongnu.org; Fri, 08 May 2020 09:17:48 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2462 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX2st-0003p8-5f for qemu-devel@nongnu.org; Fri, 08 May 2020 09:17:48 -0400 Received: from DGGEMM401-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 5EAFF417C297D3D916AE; Fri, 8 May 2020 21:17:35 +0800 (CST) Received: from dggeme707-chm.china.huawei.com (10.1.199.103) by DGGEMM401-HUB.china.huawei.com (10.3.20.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 8 May 2020 21:17:35 +0800 Received: from dggeme756-chm.china.huawei.com (10.3.19.102) by dggeme707-chm.china.huawei.com (10.1.199.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Fri, 8 May 2020 21:17:35 +0800 Received: from dggeme756-chm.china.huawei.com ([10.6.80.68]) by dggeme756-chm.china.huawei.com ([10.6.80.68]) with mapi id 15.01.1913.007; Fri, 8 May 2020 21:17:34 +0800 From: miaoyubo To: "Michael S. Tsirkin" Subject: RE: [PATCH v6 5/8] acpi: Align the size to 128k Thread-Topic: [PATCH v6 5/8] acpi: Align the size to 128k Thread-Index: AQHWDaWUvFhviwtWwUqLPdmf4WCHnKiXmCuAgAbBSRA= Date: Fri, 8 May 2020 13:17:34 +0000 Message-ID: References: <20200408125816.955-1-miaoyubo@huawei.com> <20200408125816.955-6-miaoyubo@huawei.com> <20200504100317-mutt-send-email-mst@kernel.org> In-Reply-To: <20200504100317-mutt-send-email-mst@kernel.org> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.29] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.187; envelope-from=miaoyubo@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/08 09:17:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "peter.maydell@linaro.org" , "berrange@redhat.com" , "qemu-devel@nongnu.org" , Xiexiangyou , "shannon.zhaosl@gmail.com" , "imammedo@redhat.com" , "lersek@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > -----Original Message----- > From: Michael S. Tsirkin [mailto:mst@redhat.com] > Sent: Monday, May 4, 2020 10:03 PM > To: miaoyubo > Cc: peter.maydell@linaro.org; shannon.zhaosl@gmail.com; > lersek@redhat.com; imammedo@redhat.com; qemu-devel@nongnu.org; > berrange@redhat.com; Xiexiangyou > Subject: Re: [PATCH v6 5/8] acpi: Align the size to 128k >=20 > On Wed, Apr 08, 2020 at 08:58:13PM +0800, Yubo Miao wrote: > > From: miaoyubo > > > > If table size is changed between virt_acpi_build and > > virt_acpi_build_update, the table size would not be updated to UEFI, > > therefore, just align the size to 128kb, which is enough and same with > > x86. It would warn if 64k is not enough and the align size should be > > updated. > > > > Signed-off-by: miaoyubo >=20 > does this affect migration in any way? >=20 No, it would not affect migration. I migrated one vm between two qemus(one with tables aligned to 128k and one= not) and the vm could be migrated.=20 > > --- > > hw/arm/virt-acpi-build.c | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index > > 7bcd04dfb7..89bb768b0c 100644 > > --- a/hw/arm/virt-acpi-build.c > > +++ b/hw/arm/virt-acpi-build.c > > @@ -54,6 +54,8 @@ > > #include "hw/pci/pci_bridge.h" > > #define ARM_SPI_BASE 32 > > > > +#define ACPI_BUILD_TABLE_SIZE 0x20000 > > + > > static void acpi_dsdt_add_cpus(Aml *scope, int smp_cpus) { > > uint16_t i; > > @@ -883,6 +885,15 @@ struct AcpiBuildState { > > bool patched; > > } AcpiBuildState; > > > > +static void acpi_align_size(GArray *blob, unsigned align) { > > + /* > > + * Align size to multiple of given size. This reduces the chance > > + * we need to change size in the future (breaking cross version > migration). > > + */ > > 2.19.1 > > Regards, Miao