From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3C28EB64D8 for ; Wed, 14 Jun 2023 13:55:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E8B4286167; Wed, 14 Jun 2023 15:55:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="hzqrCPRz"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="JDHgFXbf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 29C04860FE; Wed, 14 Jun 2023 15:55:14 +0200 (CEST) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [IPv6:2001:67c:2050:0:465::103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 672B586020 for ; Wed, 14 Jun 2023 15:55:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@mailbox.org Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Qh6PT1sjbz9spD; Wed, 14 Jun 2023 15:55:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1686750909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0UAk+LyFlOVLCZ4FqzCash/POHlBqRl0MLxpnYed/nk=; b=hzqrCPRzemPr5yo44WHQcLvuUsJopA8DgJbG1pq9A0T4uDMPgwVnwAtcBhKjNhEfXPFfJj FSLBP/53272sXUql4vAyJ0h96ZO343VvtkdQJHLkw4fPni4Reg4cwJ1T3T+ZwKFdN4/Pw0 VY6CgUJz0ViHE/coeU96kToy27BM3lB2wiUtKRcm/uib/91gKyICD2q47MU4ourjt4c6QN fYEEu1BwFP56iDUi7uSjszl0eM7bCbVAkMMu858SaW8S2uII4mrKZfZInllkqQDKnS2+/P EDIHVC5tkkSznU3Q+Bjuy4ACosROro7tH2zX/+Of2hUNVM6l/CvElh2R/GCNbQ== Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1686750907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0UAk+LyFlOVLCZ4FqzCash/POHlBqRl0MLxpnYed/nk=; b=JDHgFXbfQAkVl9eeR7lT2LkoS15D58KoeALjZErmKVO7uvwvIBzyOGeS5BNNGDbPogAvu4 qKi0a9ztrkgtG4n9Ldq27Mv946JqtjnabG6bcaZa4f+eKrtV2ZZQbLFs2lwuGbiGkU40af l6zVAJ2XG8MUWMIPkocrXX7FxJah0CSyvXDFP65gxrGXa9+W7tfbO7DM/KSrkNQtEp8DTy 0qapCmZRO4BadHaHqnmNaR+YzNRbHr2dRgeRoN+NALxtFunD+V3AryUHN9wqqHV+1zYNdO dO7HUeeaSUM60bEjfZ+zo7OMz+YRcGm6V9xjQ7rReWBb1bW1h8xEJBB0ul0j4A== Date: Wed, 14 Jun 2023 15:47:16 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/3] renesas: rcar3: Expose the board id in sysinfo To: Detlev Casanova , u-boot@lists.denx.de Cc: Marek Vasut , Hai Pham , Tam Nguyen References: <20230612195107.171748-1-detlev.casanova@collabora.com> <20230612195107.171748-2-detlev.casanova@collabora.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20230612195107.171748-2-detlev.casanova@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: 6091fa9aea6bb19d8ae X-MBO-RS-META: 79wwjeiek4shuqysbptkfggn9xixei89 X-Rspamd-Queue-Id: 4Qh6PT1sjbz9spD X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 6/12/23 21:51, Detlev Casanova wrote: > This is a preparation commit for selecting the correct device tree name > to be loaded depending on the board id. > > Signed-off-by: Detlev Casanova > --- > .../arm/mach-rmobile/include/mach/sys_proto.h | 15 ++++++++++ > drivers/sysinfo/rcar3.c | 30 +++++++++++-------- > 2 files changed, 33 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/mach-rmobile/include/mach/sys_proto.h b/arch/arm/mach-rmobile/include/mach/sys_proto.h > index ec8036a354c..e020b24f7c2 100644 > --- a/arch/arm/mach-rmobile/include/mach/sys_proto.h > +++ b/arch/arm/mach-rmobile/include/mach/sys_proto.h > @@ -7,4 +7,19 @@ > #ifndef _SYS_PROTO_H_ > #define _SYS_PROTO_H_ > > +/* > + * Renesas R-Car Board IDs > + */ > +#define BOARD_SALVATOR_X 0x0 > +#define BOARD_KRIEK 0x1 > +#define BOARD_STARTER_KIT 0x2 > +#define BOARD_EAGLE 0x3 > +#define BOARD_SALVATOR_XS 0x4 > +#define BOARD_CONDOR 0x6 > +#define BOARD_DRAAK 0x7 > +#define BOARD_EBISU 0x8 > +#define BOARD_STARTER_KIT_PRE 0xB > +#define BOARD_EBISU_4D 0xD > +#define BOARD_CONDOR_I 0x10 > + > #endif > diff --git a/drivers/sysinfo/rcar3.c b/drivers/sysinfo/rcar3.c > index 7b127986da7..b8b837341a2 100644 > --- a/drivers/sysinfo/rcar3.c > +++ b/drivers/sysinfo/rcar3.c > @@ -8,23 +8,12 @@ > #include > #include > #include > +#include > > #define BOARD_CODE_MASK 0xF8 > #define BOARD_REV_MASK 0x07 > #define BOARD_CODE_SHIFT 0x03 > > -#define BOARD_SALVATOR_X 0x0 > -#define BOARD_KRIEK 0x1 > -#define BOARD_STARTER_KIT 0x2 > -#define BOARD_EAGLE 0x3 > -#define BOARD_SALVATOR_XS 0x4 > -#define BOARD_CONDOR 0x6 > -#define BOARD_DRAAK 0x7 > -#define BOARD_EBISU 0x8 > -#define BOARD_STARTER_KIT_PRE 0xB > -#define BOARD_EBISU_4D 0xD > -#define BOARD_CONDOR_I 0x10 > - This part ^ should not be in this patch . All this patch should do is expose the board ID . Please split that into separate patch. > /** > * struct sysinfo_rcar_priv - sysinfo private data > * @boardname: board model and revision > @@ -32,6 +21,7 @@ > */ > struct sysinfo_rcar_priv { > char boardmodel[64]; > + u8 board_id; > u8 val; > }; > > @@ -42,6 +32,19 @@ static int sysinfo_rcar_detect(struct udevice *dev) > return priv->val == 0xff; > } > > +static int sysinfo_rcar_get_int(struct udevice *dev, int id, int *val) > +{ > + struct sysinfo_rcar_priv *priv = dev_get_priv(dev); > + > + switch (id) { > + case SYSINFO_ID_BOARD_MODEL: The BOARD_MODEL is a string, please add another 'BOARD_ID' into include/sysinfo.h to discern the properties. > + *val = priv->board_id; > + return 0; > + default: > + return -EINVAL; > + }; > +} [...]