From: Justin Lai <justinlai0215@realtek.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver
Date: Wed, 9 Aug 2023 06:42:27 +0000 [thread overview]
Message-ID: <b5462aca9d85452fa40dc7ee88bc8d26@realtek.com> (raw)
In-Reply-To: <ZMuw2SuGZtVX42Nu@nanopsycho>
> Thu, Aug 03, 2023 at 03:20:46PM CEST, justinlai0215@realtek.com wrote:
> >Hi, Jiri Pirko
> >
> >Our device is multi-function, one of which is netdev and the other is
> character device. For character devices, we have some custom functions that
> must use copy_from_user or copy_to_user to pass data.
>
> 1. Don't top post
> 2. That's nice you have it, but it is totally unacceptable. That's my
> point. This is not about wrapping your out-of-tree driver and sending
> it as is. You have to make sure you comply with the upstream code.
> Which you don't, not even remotelly.
Thank you for your reply, I will refer to your suggestions to modify my code.
next prev parent reply other threads:[~2023-08-09 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 8:25 [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver justinlai0215
2023-08-03 8:57 ` Jiri Pirko
2023-08-03 13:20 ` Justin Lai
2023-08-03 13:51 ` Jiri Pirko
2023-08-09 6:42 ` Justin Lai [this message]
2023-08-03 15:49 ` Andrew Lunn
2023-08-09 6:49 ` Justin Lai
2023-08-04 20:05 ` Heiner Kallweit
2023-08-09 6:54 ` Justin Lai
2023-08-09 7:31 ` Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5462aca9d85452fa40dc7ee88bc8d26@realtek.com \
--to=justinlai0215@realtek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.