From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 708B6C433FE for ; Mon, 7 Nov 2022 16:29:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3253384F1C; Mon, 7 Nov 2022 17:29:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=@gmx.de header.b="EE7D+dSA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0DC0784E96; Mon, 7 Nov 2022 17:29:50 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D7D64806EE for ; Mon, 7 Nov 2022 17:29:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1667838585; bh=nE2Twy0PEvasUK3txccvacMpXfja+82uCUp3UlJGkZU=; h=X-UI-Sender-Class:Date:Subject:To:References:Cc:From:In-Reply-To; b=EE7D+dSAXuTrYKX3idIb/jvVsR2vHT9cedL64jlZjyC9Nc0YF+BP6/I0fIUj0UsP/ f4rO2P82DxoxMEMRnxUoapo9/KAdbf6X3iaYXKGenj9/pLGh/S66UiKSUEf1UTQbDb GJB5SXLM1xc3UFxvd7yiw5JjR66upAFN3HVxgviFApM1XMUwv7IHGlo5/bu9FB/dj3 suxRhEa1nsptcGiGgUU6VEMZFd5ytl73JxlWdjRjWGfjQjtSIyuQzTaBOVr373ElTa rOopwL2EOrb0QQmn9jCz7AoUGqITWFmtli5iXtK58OZb9TFYkIVnc2yRqT5lBr+LSj VbAyBD8CddQ1w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N33Ed-1ozgqz3ZQj-013Oxm; Mon, 07 Nov 2022 17:29:44 +0100 Message-ID: Date: Mon, 7 Nov 2022 17:29:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3 1/3] efi_loader: Avoid overwriting previous outputs on console screen clearing Content-Language: en-US To: Jan Kiszka References: <4d7b7acff70af5aa5f356eac78c78addccafc787.1667549199.git.jan.kiszka@siemens.com> Cc: U-Boot Mailing List , Simon Glass , Ilias Apalodimas From: Heinrich Schuchardt In-Reply-To: <4d7b7acff70af5aa5f356eac78c78addccafc787.1667549199.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:irir/P0LVgYaDb3qXMfIU1FQGqXCqiOwDEx/PK+EModQvtooLKu RLlps363x5QElQ8JGjRDJXd6qT9kQnsTv0MPAiVTV0JLvKwqwnIgKRh0APt/SBTAKwa/OjD vSp1vTqkWioxhJDjgmc3/kxYLAabdCAQUr1FEx4TzCe76Z62P8emAwcosWSM4iRpPSS4hFo vBMnhM9zxUzzUYlvPxXFQ== UI-OutboundReport: notjunk:1;M01:P0:NnzS/wrRWwo=;JrdUKvp9aQCmBixy/Wn9PFqgCK6 HKRV/zxKelu8rxjO2pbeYMdXORtwx/LywsLsfLJPK/5OxLHjKMIPAkuB370KGta2wCqGuISO+ UnN4O/v5qiuK7Z+i5c+qxrH2Vif5mgT57HcBHBCnEwUQhiHosnDfoPpvO0C9J6C/aOAabrjxa qZH46TYIKAdv21eHSO7T+qwKsAbyTk0MfnCPraP1FbmBolzgJdQIzl/9Fj5/G93IuMG2XGmne oHSEcQYcZYR8HEyoRE/dvbw2YWY+BBKjWvm2kuVYkC+8CVqvf2slBSxS1dJRQIf1oZfjjDxEv Q96UlH1OzOTpIOzGDGceTWA13k7jlJ/AjF5dkpJlHCrmG4Hmn/lI+GmaDgPY3LhgRDB74hFNj q8O+/KaRcg60G4co0+mB0QjBx3CDjgDgcWnX0jGI45Tjk+wctF4R5jgJgwIV0p3JKTtHvlw1N yJubR0D3eSjQNPUzrToFftREFw/nWEfj8rFumfPDH05S2QR470419z/kUY0/FPCMC9g2nNYFq cQavY6N6rmgb+6trigYIkyglcUE2XKFxqTHcxeEpuAcNwVJGtaGQ6OaEuzxv/ite1w5M4hnzt q1ygiZ4v/Z4IX2A/YlJtFH39S3A9HBDYbQxOX2QVaW1W4jVGFStqW7OGLnhVJOmBiIQTKdGDB +4JPnNn5JEKkFZxGNFOwiYRB77By8lncJMp+MLG1/AbEyNnIg7CIYyeF6heXnxsnxrtQDaRb9 +LWrj62jSTXhl5XHAQZ+hQ4myDI2MwApkrMT3v7EsG4UQX9Idi7DOuvNE3YHbKZDqze3LsR4i wyEy8EVAKAxY+V/59BvTvqaRFT71IH8mGH98LZELO1bcf/R+rSoqxldb6Z6iuqz+QYRtJmAkG 7lDsBvIn0BIgVaXgjjJLfg8gkczGdE8jlQebKDrSUmmkwXG3z2CA4P+OV68GJELNM82lBzrZr i5ev0w== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/4/22 09:06, Jan Kiszka wrote: > From: Jan Kiszka > > Before clearing the screen, ensure that no previous output of firmware > or UEFI programs will be overwritten on serial devices or other > streaming consoles. This helps generating complete boot logs. > > Tested regarding multi-output against qemu-x86_defconfig. > > Signed-off-by: Jan Kiszka > --- > lib/efi_loader/efi_console.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c > index 4d08dd3763a..6ce0fcc168d 100644 > --- a/lib/efi_loader/efi_console.c > +++ b/lib/efi_loader/efi_console.c > @@ -461,10 +461,16 @@ static efi_status_t EFIAPI efi_cout_set_attribute( > } > > /** > - * efi_cout_clear_screen() - clear screen > + * efi_clear_screen() - clear screen > */ > static void efi_clear_screen(void) > { > + unsigned int row; > + > + /* Avoid overwriting previous outputs on streaming consoles */ > + for (row =3D 1; row < efi_cout_modes[efi_con_mode.mode].rows; row++) > + printf("\n"); > + Scrolling on a framebuffer is a very expensive operations: For each of the 135 lines of an UHD display you have to copy 32 MiB. This would create a delay of multiple seconds on a slow device. So keep the patch for your debugging purposed. But we cannot merge it into upstream. Best regards Heinrich > /* > * The Linux console wants both a clear and a home command. The video > * uclass does not support [H without coordinates, yet.