From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89AA6CD6E6B for ; Thu, 4 Jun 2026 10:30:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wV5Ks-0004I3-Cn; Thu, 04 Jun 2026 06:30:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV5Kn-0004H9-Tl for qemu-riscv@nongnu.org; Thu, 04 Jun 2026 06:29:57 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV5Km-0000eo-J8 for qemu-riscv@nongnu.org; Thu, 04 Jun 2026 06:29:57 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6548Np4q140423 for ; Thu, 4 Jun 2026 10:29:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hCEMa0nmoXeMWQ39pYbDDWNPAo0cXZ88r9IjHPuQF88=; b=DBbxIjoEr5Jl/W8X CTnd6kUyHV+FrkfX64nCENcTubdOGrM7BaAleS8z7Qx6J+uiL72nmC8uOnsGBfUZ 7PTcoWlcU1ELxabsqFhuZb+X3pYRy20LqhBNRhxkJ43I4Dw0ov3YrAF8poRmq3kq /GT13rOGUlBDJ04nkZpcd4Gw8H5Pk0gqzcfKgmro5uhb9NQH+M48xC2G2m6N7hWj RvcuIvuuKujmh+OuKLo5U4dnOI/Kfn6k59nefzlkVMvvwBBmIe5V1tkPIDAQecuD XD/ZyDQDRPgalDKsc0TplAZzlYz8/hW1f9mkxPSkGgkSRsy8r2PddIRmQBqNnuwE FYkU1w== Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejyen9v00-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 10:29:55 +0000 (GMT) Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-6603f24ce64so918006d50.3 for ; Thu, 04 Jun 2026 03:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780568995; x=1781173795; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hCEMa0nmoXeMWQ39pYbDDWNPAo0cXZ88r9IjHPuQF88=; b=AuCurrfs0Z1+08JiShQERjGX0PG2iQ+LN5g2eUl+hrOxNjWE8uxjRUITJ0TEbShGZq lWVe+lhm6U7ddXGzzkVNOYgIC1pUcHd0Qm5qqnbmpi4saA/39mt+Gb7zThMteZbV/GSE 0MTRVzMavTX4Le3cuOBEcsBrlfjANE5sqs01gl+RZ70oQJLeS0hq5yViXv7Lp7EM0dto yGcSeAEJM+Fh/U8xlsjvhvHdKNSIcNIGUBE6zkgTynPLHvtJ5HbQwzvz3gthazd4mFtB tljWIq/MHtbkWlxqSfI7P6J+za62nA+jFYZbwSf3dcwbGR/T81x8zK9gcKJcQc3GQ6j3 Ugtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780568995; x=1781173795; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hCEMa0nmoXeMWQ39pYbDDWNPAo0cXZ88r9IjHPuQF88=; b=TEuwLEzxWuKryY1DRCfLAjygNWkKctR9uCagNkk+8T1QVUXwtr2FGbbM6CedvHWR/U 9gppgqzT9gsImeCL46ImkWRWYGS37V9FYO1jyk463G2yH8h39WV7Sl2wZWt0KWMmiXMD 5GQFyqat8Zv13akvXzWTf8+hRDyAJwyc0OowhE7cGhml3anz+7pRPIH+4+EnWMITTu8Z guC+2lz0Jf7FdcRPBTs8WkEUr7uliPPvfkqMoI09v/LpiqetX1caeKGiWQsNE/2OKBHV OuVvDAKcGd6gGtvO1Hdvx+AqmbztQJy6ItFGkvjRIIIwM574TZsAOLzJ3o30I6oXs/sZ qwcg== X-Forwarded-Encrypted: i=1; AFNElJ8rQgrFnndgfviZTYgG2cfUQ4gJMhFk+/aAgY/ZrBFlFO5A+SbnNFIqPkF7k9qS9pVjeyLrS+vdzR6k@nongnu.org X-Gm-Message-State: AOJu0Yx5eO4XVkiwXKNS2UKJndL9tGdrNEBsK+GVYTua/XjWsR7UmFAe QnUq7bNyi2hAZbdogpX98ZQ9dBXLC+l/rQzwUgLXVYWgckPrpY0u28tHGMGW7/OFi7WFMSgH2Fv ujbrFJoBcovARsyft1nVm/HknJ8KYsmiOsGT4/G6kvrww0erP4h5CxFsq/g== X-Gm-Gg: Acq92OFzb/Nzi/hbmW4dHVR1HN3x5vqp6S90k7weKtnPXkdY8G2EzHgHVzXUt5QKLo1 ycpS+xS9UrovJsRve+BsQEKx4uJVj4xJGKvC1XlMcyuQkL1qZUHrwIsTU+tKZgXynr6p9ffQ8IY ObC7dlqpq5Nfp1TGzoBbOOP5XkYqbmbJ8mNEz9dEkuMl07evbtljOLKiAtzRy66djdG8zUa53l5 XMdeCZy0FMYfHdmnJ5e4+GxuFUrnR1AjbMzJM7ach968X9cvO/jgShPc6HA1uFNhUTZYqsnsPuv CEFeDsBRBlUU6WlVbv/uvcfPGvVhUdxbwuBwbE8/a9es+ygRzyTxI+1MWM2F6p5DEeGVnP2gNRf r97lZAF0eKAqT/3RkmGDSD/sN4ZP4N/NEyYysYdqQVvJGtlgsTX8nOki9cCts7fyyFEfO X-Received: by 2002:a53:d016:0:b0:660:689b:1539 with SMTP id 956f58d0204a3-660dc5af389mr5944093d50.58.1780568994959; Thu, 04 Jun 2026 03:29:54 -0700 (PDT) X-Received: by 2002:a53:d016:0:b0:660:689b:1539 with SMTP id 956f58d0204a3-660dc5af389mr5944077d50.58.1780568994492; Thu, 04 Jun 2026 03:29:54 -0700 (PDT) Received: from [192.168.68.106] ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-660d6488b1csm3591926d50.19.2026.06.04.03.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 03:29:54 -0700 (PDT) Message-ID: Date: Thu, 4 Jun 2026 07:29:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 06/25] target/riscv/debug: Implement get_trigger_action for icount type trigger To: Nicholas Piggin , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , bin.meng@windriver.com, vivahavey@gmail.com, Alvin Chang , Yu-Ming Chang , Joel Stanley References: <20260114044701.1173347-1-npiggin@gmail.com> <20260114044701.1173347-7-npiggin@gmail.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20260114044701.1173347-7-npiggin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JaSMa0KV c=1 sm=1 tr=0 ts=6a2153a3 cx=c_pps a=ngMg22mHWrP7m7pwYf9JkA==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=aLERe-55eW_5Fbas3b4A:9 a=QEXdDO2ut3YA:10 a=yHXA93iunegOHmWoMUFd:22 X-Proofpoint-ORIG-GUID: rd4fu3lkwl3dmc1czynhw9x89l6HXPxJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDEwMSBTYWx0ZWRfXzAv/jBsB/j1b QF4qDi5v/tFYa5/mXEouvLMnLkQHX8TfDHK97raa3yMBF8SbjwR+7SLsYnCJj0ij4I6Iaw1u+EN W7FOQIzyIaIQ8AgAfykRrYOayWaTcGYNesHjvktR+EmiAwIKI+xzkJEY0Vr8tH4bTaeqRQu06vM hLc0DN/GiyoPiiqJgO6zvuJqv0WEOKKadXRJ+Z9LMFGY6PCXyu5NKAdd4xymZxTj595xzOS3xLe mc82Ozn4R1/51NZo4O4AVA28oSQzntAnnoFQDowsuBWARIJd6PZks8XHhZ0LJDmGhFiXBfL+tFu JyKtzR2MfAlgqdbaFTTWvaa7A/NrgH5naj+mIf09Y1sND8JXBBDLXBgEkXpeQx9CZXgDKpr+97L dkl3FfzPska6SezYcd/cGf6g1E/ufNCSRVohyuwFSVvfe8N2lA8WRSasCvNI3NulFXUMaGcmRwE pz279XUfdChHAlRW0ug== X-Proofpoint-GUID: rd4fu3lkwl3dmc1czynhw9x89l6HXPxJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040101 Received-SPF: pass client-ip=205.220.180.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 1/14/2026 1:46 AM, Nicholas Piggin wrote: > Signed-off-by: Nicholas Piggin > --- Reviewed-by: Daniel Henrique Barboza > target/riscv/debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/riscv/debug.c b/target/riscv/debug.c > index 51c5934bfa..af9c4e37cd 100644 > --- a/target/riscv/debug.c > +++ b/target/riscv/debug.c > @@ -110,6 +110,8 @@ static trigger_action_t get_trigger_action(CPURISCVState *env, > action = (tdata1 & TYPE6_ACTION) >> 12; > break; > case TRIGGER_TYPE_INST_CNT: > + action = (tdata1 & ITRIGGER_ACTION); > + break; > case TRIGGER_TYPE_INT: > case TRIGGER_TYPE_EXCP: > case TRIGGER_TYPE_EXT_SRC: