From: Tokunori Ikegami <ikegami.t@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: check PI size if metadata size or below
Date: Wed, 23 Oct 2024 03:12:48 +0900 [thread overview]
Message-ID: <b5504bf0-95c7-459d-8192-cdd80371dbdd@gmail.com> (raw)
In-Reply-To: <Zxfnj3HwRjZpHTHa@kbusch-mbp>
Thanks for your confirmation. Just sent the v3 patch to change only
nvme_ns_has_pi(). Thank you.
On 2024/10/23 2:57, Keith Busch wrote:
> On Wed, Oct 23, 2024 at 02:51:16AM +0900, Tokunori Ikegami wrote:
>> I see. Thanks for your explanation. To make sure let me confirm again below.
>> The nvme_ns_has_pi changed does not use PRACT as mentioned but still is it
>> not okay to change the function only also? (I could understand as
>> nvme_submit_io() uses PRACT then it does not work correctly as mentioned.)
> The function name could be better. It's just reporting if the namespace
> format supports inserting/stripping metadata, such that the host doesn't
> need to provide it.
prev parent reply other threads:[~2024-10-22 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 16:34 [PATCH] nvme: check PI size if metadata size or below Tokunori Ikegami
2024-10-22 16:54 ` Keith Busch
2024-10-22 17:08 ` Tokunori Ikegami
2024-10-22 17:33 ` Keith Busch
2024-10-22 17:51 ` Tokunori Ikegami
2024-10-22 17:57 ` Keith Busch
2024-10-22 18:12 ` Tokunori Ikegami [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5504bf0-95c7-459d-8192-cdd80371dbdd@gmail.com \
--to=ikegami.t@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.