From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15596C4332F for ; Fri, 9 Dec 2022 11:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbiLILTJ (ORCPT ); Fri, 9 Dec 2022 06:19:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbiLILSc (ORCPT ); Fri, 9 Dec 2022 06:18:32 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D024349095; Fri, 9 Dec 2022 03:18:25 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A86D024E1FE; Fri, 9 Dec 2022 19:18:23 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 19:18:23 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 19:18:22 +0800 Message-ID: Date: Fri, 9 Dec 2022 19:18:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive To: Linus Walleij CC: , , , Rob Herring , "Krzysztof Kozlowski" , Jaehoon Chung , Ulf Hansson , References: <20221207131731.1291517-1-william.qiu@starfivetech.com> <20221207131731.1291517-2-william.qiu@starfivetech.com> Content-Language: en-US From: William Qiu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 2022/12/9 5:13, Linus Walleij wrote: > Hi William, > > thanks for your patch! > > On Wed, Dec 7, 2022 at 2:17 PM William Qiu wrote: > >> Add documentation to describe StarFive >> designware mobile storage host controller driver. >> >> Signed-off-by: William Qiu > > (...) > >> + starfive,sys-syscon: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + description: >> + The desired number of times that the host execute tuning when needed. > > This is not consistent with the use in the code of the attached driver. > There it is a phandle, and it has three cells, which I am critical of. > Also this description is hard to understand. > Will update all of it in next version. >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts > > I don't think the syscon phandle is optional. > Will fix. >> + #include >> + #include >> + mmc@16010000 { >> + compatible = "starfive,jh7110-sdio"; >> + reg = <0x16010000 0x10000>; > > No syscon phandle in the example: this needs to be added. > I will add the syscon phandle. Thank you for taking time to review and provide helpful comments for this patch. Best regards, William Qiu > Yours, > Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44FD8C4332F for ; Fri, 9 Dec 2022 11:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nAFZTTVTsvmLoO9klQOM6/SRey6n1Ei3rapg+xcjaHQ=; b=PNsP8KnUUbO8Jz plD24M5/ALzdZu9CPpfa/2ajwmv0d5uE5dMy8nv1zSKdqQAQOmRGDnxHJk1OrveY25Io53wb/RoTU vT9HySNQfuGni53yf056XEV+sfRoulrgP1WmLvCQBGYl0LPaERloM4oc2tuXIjdinATd+qHvXJ23Y 7xxE4UjNM2PwEcwhEtavyrBrLV/eJH3nakhXD+02pok1+bt/2odXNq7ZZroo+GqrlNc5275KRNwfb R5mdqeVVSYXzSk4OBiDkscXdPhifjlstqw+sZWwUzw/K570MTBqF5s/5aCugARnhWGv3lL989szLZ SQ9GXCJRdh1w8zBKYFkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3bPH-00768t-8I; Fri, 09 Dec 2022 11:19:07 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3bPD-0075zg-3f for linux-riscv@lists.infradead.org; Fri, 09 Dec 2022 11:19:05 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A86D024E1FE; Fri, 9 Dec 2022 19:18:23 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 19:18:23 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 19:18:22 +0800 Message-ID: Date: Fri, 9 Dec 2022 19:18:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive To: Linus Walleij CC: , , , Rob Herring , "Krzysztof Kozlowski" , Jaehoon Chung , Ulf Hansson , References: <20221207131731.1291517-1-william.qiu@starfivetech.com> <20221207131731.1291517-2-william.qiu@starfivetech.com> Content-Language: en-US From: William Qiu In-Reply-To: X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_031903_481558_C4BA37A8 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2022/12/9 5:13, Linus Walleij wrote: > Hi William, > > thanks for your patch! > > On Wed, Dec 7, 2022 at 2:17 PM William Qiu wrote: > >> Add documentation to describe StarFive >> designware mobile storage host controller driver. >> >> Signed-off-by: William Qiu > > (...) > >> + starfive,sys-syscon: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + description: >> + The desired number of times that the host execute tuning when needed. > > This is not consistent with the use in the code of the attached driver. > There it is a phandle, and it has three cells, which I am critical of. > Also this description is hard to understand. > Will update all of it in next version. >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts > > I don't think the syscon phandle is optional. > Will fix. >> + #include >> + #include >> + mmc@16010000 { >> + compatible = "starfive,jh7110-sdio"; >> + reg = <0x16010000 0x10000>; > > No syscon phandle in the example: this needs to be added. > I will add the syscon phandle. Thank you for taking time to review and provide helpful comments for this patch. Best regards, William Qiu > Yours, > Linus Walleij _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv