Re: [PATCH 12/19] drm/xe: Report 'probe blocked' error using SIGID

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 7/24/2026 2:28 PM, Aravind Iddamsetty wrote:
> 
> On 24-07-2026 02:07, Michal Wajdeczko wrote:
>> Report 'probe blocked' error using xe_log_err() helper.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
>> Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 36d62927b969..a9ada8e4f081 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -25,6 +25,7 @@
>>  #include "xe_gt_printk.h"
>>  #include "xe_gt_sriov_vf.h"
>>  #include "xe_guc.h"
>> +#include "xe_log.h"
>>  #include "xe_mmio.h"
>>  #include "xe_module.h"
>>  #include "xe_pci_error.h"
>> @@ -1172,8 +1173,8 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>  	}
>>  
>>  	if (id_blocked(pdev->device)) {
>> -		dev_info(&pdev->dev, "Probe blocked for device [%04x:%04x].\n",
>> -			 pdev->vendor, pdev->device);
>> +		xe_log_err(pdev, PROBE, -ENODEV, "Probe
> 
> if this is due to force_probe passed by user shall not even be
> considered an error.

true, we can use xe_log_info(PROBE) here

and I assume the plan is to use use xe_log_err_fatal(PROBE) on all other error paths from xe_pci_probe()

> 
> Thanks,
> Aravind.
>>  blocked for device [%04x:%04x]\n",
>> +			   pdev->vendor, pdev->device);
>>  		return -ENODEV;
>>  	}
>>