From: John Hubbard <jhubbard@nvidia.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Cc: <akpm@linux-foundation.org>, <songmuchun@bytedance.com>,
<mike.kravetz@oracle.com>, <willy@infradead.org>
Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h
Date: Wed, 14 Dec 2022 14:53:09 -0800 [thread overview]
Message-ID: <b5932129-e438-9379-fa38-993b289ea591@nvidia.com> (raw)
In-Reply-To: <cf3f6439-ac2b-53ae-6b55-5ff0b8003fb1@oracle.com>
On 12/14/22 12:35, Sidhartha Kumar wrote:
>> if (WARN_ON_ONCE(!folio_test_large(folio)))
>> return;
>> I agree that warning this way is clearer, I will change in a v2.
With that change, please feel free to add:
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-12-14 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 21:20 [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h Sidhartha Kumar
2022-12-14 8:43 ` John Hubbard
2022-12-14 20:35 ` Sidhartha Kumar
2022-12-14 22:53 ` John Hubbard [this message]
2022-12-15 3:44 ` Muchun Song
2022-12-15 5:09 ` Sidhartha Kumar
2022-12-15 5:31 ` Muchun Song
2022-12-16 22:27 ` Andrew Morton
2022-12-16 22:56 ` John Hubbard
2022-12-16 23:09 ` Andrew Morton
2022-12-16 23:10 ` Sidhartha Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5932129-e438-9379-fa38-993b289ea591@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.