From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: Question about scsi device hotplug (e.g scsi-hd)
Date: Thu, 2 Apr 2020 10:49:11 +0200 [thread overview]
Message-ID: <b59caec6-062d-735d-dc4e-2fc4db57b607@redhat.com> (raw)
In-Reply-To: <87zhbubg80.fsf@dusky.pond.sub.org>
On 02/04/20 07:37, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 01/04/20 17:09, Stefan Hajnoczi wrote:
>>>> What do you think about it?
>>>
>>> Maybe aio_disable_external() is needed to postpone device emulation
>>> until after realize has finished?
>>>
>>> Virtqueue kick ioeventfds are marked "external" and won't be processed
>>> while external events are disabled. See also
>>> virtio_queue_aio_set_host_notifier_handler() ->
>>> aio_set_event_notifier().
>>
>> Yes, I think Stefan is right.
>
> Is this issue limited to SCSI devices?
Yes, because they (and more specifically virtio-scsi) are the only ones
that can be processed
1) outside the BQL
2) by a device other than themselves (in this case, by the adapter).
Paolo
next prev parent reply other threads:[~2020-04-02 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 16:16 Question about scsi device hotplug (e.g scsi-hd) Maxim Levitsky
2020-04-01 15:09 ` Stefan Hajnoczi
2020-04-01 16:36 ` Paolo Bonzini
2020-04-02 5:37 ` Markus Armbruster
2020-04-02 8:49 ` Paolo Bonzini [this message]
2020-04-02 8:46 ` Maxim Levitsky
2020-04-03 12:41 ` Stefan Hajnoczi
2020-04-03 13:45 ` Markus Armbruster
2020-04-03 13:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b59caec6-062d-735d-dc4e-2fc4db57b607@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.