From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, willmcvicker@google.com,
kernel-team@android.com
Subject: Re: [PATCH v2 1/5] dt-bindings: firmware: google,gs101-acpm-ipc: add #clock-cells
Date: Sun, 31 Aug 2025 12:40:15 +0200 [thread overview]
Message-ID: <b5d0e355-2681-4eaa-8a67-82a364312ec5@kernel.org> (raw)
In-Reply-To: <20250827-acpm-clk-v2-1-de5c86b49b64@linaro.org>
On 27/08/2025 14:42, Tudor Ambarus wrote:
> diff --git a/include/dt-bindings/clock/google,gs101.h b/include/dt-bindings/clock/google,gs101.h
> index 442f9e9037dc33198a1cee20af62fc70bbd96605..f1d0df412fdd49b300db4ba88bc0b1674cf0cdf8 100644
> --- a/include/dt-bindings/clock/google,gs101.h
> +++ b/include/dt-bindings/clock/google,gs101.h
> @@ -634,4 +634,19 @@
> #define CLK_GOUT_PERIC1_CLK_PERIC1_USI9_USI_CLK 45
> #define CLK_GOUT_PERIC1_SYSREG_PERIC1_PCLK 46
I missed it last time - this is a header for SoC clock controller
bindings. ACPM firmware is completely different device, so should go to
its own binding header.
>
> +#define CLK_ACPM_DVFS_MIF 0
> +#define CLK_ACPM_DVFS_INT 1
> +#define CLK_ACPM_DVFS_CPUCL0 2
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-31 10:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 12:42 [PATCH v2 0/5] exynos-acpm: add DVFS protocol and clock driver Tudor Ambarus
2025-08-27 12:42 ` [PATCH v2 1/5] dt-bindings: firmware: google,gs101-acpm-ipc: add #clock-cells Tudor Ambarus
2025-08-29 16:51 ` Rob Herring (Arm)
2025-08-31 10:40 ` Krzysztof Kozlowski [this message]
2025-09-01 6:25 ` Tudor Ambarus
2025-08-27 12:42 ` [PATCH v2 2/5] firmware: exynos-acpm: add DVFS protocol Tudor Ambarus
2025-08-27 12:42 ` [PATCH v2 3/5] clk: samsung: add Exynos ACPM clock driver Tudor Ambarus
2025-08-28 5:35 ` Tudor Ambarus
2025-08-31 18:45 ` kernel test robot
2025-08-27 12:42 ` [PATCH v2 4/5] firmware: exynos-acpm: register ACPM clocks dev Tudor Ambarus
2025-08-31 10:50 ` Krzysztof Kozlowski
2025-09-01 6:56 ` Tudor Ambarus
2025-09-01 7:48 ` Krzysztof Kozlowski
2025-09-01 8:43 ` Tudor Ambarus
2025-09-01 9:34 ` Krzysztof Kozlowski
2025-08-27 12:42 ` [PATCH v2 5/5] arm64: defconfig: enable Exynos ACPM clocks Tudor Ambarus
2025-08-31 10:42 ` [PATCH v2 0/5] exynos-acpm: add DVFS protocol and clock driver Krzysztof Kozlowski
2025-09-01 7:06 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d0e355-2681-4eaa-8a67-82a364312ec5@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.