From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Edward Liaw <edliaw@google.com>,
shuah@kernel.org, Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
cmllamas@google.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, kernel-team@android.com,
llvm@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH v1 1/2] selftests/mm: Include linux/mman.h
Date: Fri, 7 Jun 2024 14:44:50 +0500 [thread overview]
Message-ID: <b5e4ca79-8be0-4085-adfa-e8ee1c855fdb@collabora.com> (raw)
In-Reply-To: <20240605223637.1374969-2-edliaw@google.com>
On 6/6/24 3:36 AM, Edward Liaw wrote:
> thuge-gen defines MAP_HUGE_* macros that are provided by linux/mman.h
> since 4.15. Removes the macros and includes linux/mman.h instead.
>
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
> tools/testing/selftests/mm/thuge-gen.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
> index ea7fd8fe2876..034635317935 100644
> --- a/tools/testing/selftests/mm/thuge-gen.c
> +++ b/tools/testing/selftests/mm/thuge-gen.c
> @@ -15,6 +15,7 @@
>
> #define _GNU_SOURCE 1
> #include <sys/mman.h>
> +#include <linux/mman.h>
> #include <stdlib.h>
> #include <stdio.h>
> #include <sys/ipc.h>
> @@ -28,10 +29,6 @@
> #include "vm_util.h"
> #include "../kselftest.h"
>
> -#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT)
> -#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT)
> -#define MAP_HUGE_SHIFT 26
> -#define MAP_HUGE_MASK 0x3f
Totally makes sense.
Reviewed-by: Muhammad Usama Anjum <usama.anju@collabora.com>
> #if !defined(MAP_HUGETLB)
> #define MAP_HUGETLB 0x40000
> #endif
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-06-07 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 22:36 [PATCH v1 0/2] selftests/mm: thuge-gen defines Edward Liaw
2024-06-05 22:36 ` [PATCH v1 1/2] selftests/mm: Include linux/mman.h Edward Liaw
2024-06-05 22:45 ` Carlos Llamas
2024-06-07 9:44 ` Muhammad Usama Anjum [this message]
2024-06-07 10:04 ` Muhammad Usama Anjum
2024-06-05 22:36 ` [PATCH v1 2/2] selftests/mm: Guard defines from shm Edward Liaw
2024-06-05 22:52 ` Carlos Llamas
2024-06-07 10:03 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e4ca79-8be0-4085-adfa-e8ee1c855fdb@collabora.com \
--to=usama.anjum@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=cmllamas@google.com \
--cc=edliaw@google.com \
--cc=justinstitt@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.