Re: [PATCH] crypto/x509-utils: don't double set errp

[Zhuoying Cai <zycai@linux.ibm.com>]

Reviewed-by: Zhuoying Cai <zycai@linux.ibm.com>

On 8/31/26 8:09 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> qcrypto_x509_get_ecc_curve() already sets errp on failure.
> 
> Fixes: e8317c4c9f68 ("crypto/x509-utils: Add helper functions for DIAG 320 subcode 2")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  crypto/x509-utils.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c
> index e4767f98384e..34cbfca26bff 100644
> --- a/crypto/x509-utils.c
> +++ b/crypto/x509-utils.c
> @@ -325,7 +325,6 @@ int qcrypto_x509_check_ecc_curve_p521(uint8_t *cert, size_t size, Error **errp)
>  
>      curve_id = qcrypto_x509_get_ecc_curve(cert, size, errp);
>      if (curve_id == -1) {
> -        error_setg(errp, "Failed to get ECC curve");
>          return -1;
>      }
>