From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Huang Wei <huangwei@kylinos.cn>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables
Date: Mon, 12 Oct 2026 14:58:30 +0300 (EEST) [thread overview]
Message-ID: <b5f1c096-f10b-ee56-c3ec-e2eba4a151b1@linux.intel.com> (raw)
In-Reply-To: <20261012034129.2902006-1-huangwei@kylinos.cn>
On Mon, 12 Oct 2026, Huang Wei wrote:
> Hi Mark,
>
> Thanks for running this down with the FW team - and for the honest
> follow-up. Dropping the patch is clearly the right call: if the X9-14
> has its own register layout, reusing the existing quirk-table offsets
> would just trade "thermal sensors disabled" for wrong readings, which
> is worse.
>
> The symptom the reporter hit (legacy probes reading 0x00, thermal
> getting disabled) is still real, so I'm glad Lenovo is working on the
> correct mapping - happy to review that series when it lands.
>
> Ilpo - sorry for the churn, the patch will need to come back out of
> your review branch.
Hi,
If you want it removed, please send a revert patch as there have been
enough merges in between so I don't want to attempt history rewriting to
get it pulled.
--
i.
next prev parent reply other threads:[~2026-10-12 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 7:30 [PATCH] platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables Huang Wei
2026-09-18 15:15 ` Ilpo Järvinen
2026-09-18 16:15 ` [PATCH v2] " Huang Wei
2026-09-18 18:25 ` Ilpo Järvinen
2026-09-18 22:00 ` Mark Pearson
2026-09-30 12:20 ` Mark Pearson
2026-10-02 12:55 ` Mark Pearson
2026-10-12 3:41 ` Huang Wei
2026-10-12 11:58 ` Ilpo Järvinen [this message]
2026-10-13 7:07 ` [PATCH] Revert "platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables" Huang Wei
2026-10-13 17:14 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f1c096-f10b-ee56-c3ec-e2eba4a151b1@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=huangwei@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.