From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37ED8CF9C6E for ; Mon, 23 Sep 2024 11:04:37 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.801921.1211986 (Exim 4.92) (envelope-from ) id 1ssgri-00061M-RB; Mon, 23 Sep 2024 11:04:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 801921.1211986; Mon, 23 Sep 2024 11:04:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ssgri-00061F-Oe; Mon, 23 Sep 2024 11:04:26 +0000 Received: by outflank-mailman (input) for mailman id 801921; Mon, 23 Sep 2024 11:04:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ssgrh-000619-M5 for xen-devel@lists.xenproject.org; Mon, 23 Sep 2024 11:04:25 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 974d490e-799b-11ef-99a2-01e77a169b0f; Mon, 23 Sep 2024 13:04:23 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a8d2b4a5bf1so608025466b.2 for ; Mon, 23 Sep 2024 04:04:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90612b3a1asm1201997466b.129.2024.09.23.04.04.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 04:04:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 974d490e-799b-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727089463; x=1727694263; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=PR9ksYDTLQ6w39lE7MMEEAWsyLToeYOPnmNKiMnMZzc=; b=cuddeGlY0e3saUooIlFnK3CaBworlfchulmUw5J7oS/wTaO0yTHSmYaG77RjmbaHS/ D9xqQqtSsWbjToKPlqHwbRndNc1yz9d8WoPRqukbXeNLG1e5vy+xPr314RcRLgxr3CUd 8b5cPH7/AfHAVOTHQoyHejicJyHv2McdLM25nHxt3l/ohb4ljpLtGw0unqSU5QXbHOvN ChKo8EB5TI4I3oyyGvkgziWaNzyV+G2dchoVDFG15SkrYuv67iO6xjGIf9EEIz9f8JN/ 9tiDP161qblgXhAaiKnmfYslZMcod6LtTvT4T+UHeqzaU76zlvpswkMWEy2uxPybixHz Eu9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727089463; x=1727694263; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PR9ksYDTLQ6w39lE7MMEEAWsyLToeYOPnmNKiMnMZzc=; b=RUdxpfp8bf1wWX+hKbBwZL5Kw+8Z7JC8c75ygdmww91FW449H4Djlot/fgNnZ4Ro1w uluiWvE1qNQa2iGbpYNpnb8lmI1Obty7evyRXkJc4n1CUI4qRwWJJWMBst0stMuQ/G9a oo6/f/qGRX0nuY3P8qb+X7ohz4HKFzffObQ8p2yKX92Tta3pGPxjKJekU0he2pomfi2e PptA3wCIYYMAu11GCLn9wnn2PoMnw6w1YRyyr7Iecfug5IZV5TYvorpUcxgxkXAGs6pw ex9t+MwVy22HtcDobg1x+NLOWGeklV9z1wje3Kd+mCugQlAuE3+byckAu2r2EPusA2mE 8xDQ== X-Forwarded-Encrypted: i=1; AJvYcCUMI6tlX/q/uy2tvs9eGypkwcOujqTTXekCd5sCfBVHR2taromqL7y6fED0oUZ1cyixtMMpcyte4Dg=@lists.xenproject.org X-Gm-Message-State: AOJu0YwqtHQ1VLJa2CKkqzK5botiD5OlYXiaMBkb0FRFKjrin7Svc8R5 Qo06ZAGwYEgVuujJMN8+t/fT7WU/gG6YuBykzqiehxuIq/FMXU2aoBpCeS5VUQ== X-Google-Smtp-Source: AGHT+IEbFCYY0Vm2KsCrIu7IhnnmPQbQ4yawbcJYqmGOWDWymGZKNFCC3GkXtOXjELszVMbQlMnANg== X-Received: by 2002:a17:907:d2d0:b0:a8a:8de6:a605 with SMTP id a640c23a62f3a-a90d4ffd348mr1229971466b.17.1727089463209; Mon, 23 Sep 2024 04:04:23 -0700 (PDT) Message-ID: Date: Mon, 23 Sep 2024 13:04:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] xen/livepatch: do Xen build-id check earlier To: Roger Pau Monne Cc: Ross Lagerwall , xen-devel@lists.xenproject.org References: <20240920093656.48879-1-roger.pau@citrix.com> <20240920093656.48879-3-roger.pau@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240920093656.48879-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20.09.2024 11:36, Roger Pau Monne wrote: > The check against the expected Xen build ID should be done ahead of attempting > to apply the alternatives contained in the livepatch. > > If the CPUID in the alternatives patching data is out of the scope of the > running Xen featureset the BUG() in _apply_alternatives() will trigger thus > bringing the system down. Sounds like there wants to be a Fixes: tag then? Jan