From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8287BC433EF for ; Thu, 20 Jan 2022 07:12:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AC2AC2F4B; Thu, 20 Jan 2022 08:11:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AC2AC2F4B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642662736; bh=lKUlz7DdzHdUMnF9WoLx7Hobn0qCI4QP9a4+wXQvXnE=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y2zqU9GoLeOeXFX9OL2iUk3y/wfWoKkdszhdfhA9kC3V4zXMzY8oQl0WKqAtL/+Y2 VHM03k3SN2QI+HAxhJH42I5j9P1v/WNrZaXTROuFTM69qjvgdOFgTP+PiCqjivH+Tq Jfpc3oswl0mEdKqKAjWLXjj+1VeYsyTtSxWwGCAc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0C2D1F805C7; Thu, 20 Jan 2022 08:03:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7E35BF801F7; Wed, 19 Jan 2022 11:56:25 +0100 (CET) Received: from mxout03.lancloud.ru (mxout03.lancloud.ru [45.84.86.113]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 642B3F80128 for ; Wed, 19 Jan 2022 11:56:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 642B3F80128 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru A788320EEBBF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 13:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-Mailman-Approved-At: Thu, 20 Jan 2022 08:03:35 +0100 Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, Lee Jones , openipmi-developer@lists.sourceforge.net, Khuong Dinh , Florian Fainelli , Matthias Schiffer , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , linux-pwm@vger.kernel.org, Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Sebastian Reichel , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Tony Luck , Mun Yew Tham , Eric Auger , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 1/18/22 12:18 PM, Uwe Kleine-König wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: >>> A possible compromise: We can have both. We rename >>> platform_get_irq_optional() to platform_get_irq_silent() (or >>> platform_get_irq_silently() if this is preferred) and once all users are >>> are changed (which can be done mechanically), we reintroduce a >>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>> return 0 on not-found, no error message printking). >> >> Please do not do that as anyone trying to forward-port an old driver >> will miss the abi change of functionality and get confused. Make >> build-breaking changes, if the way a function currently works is >> changed in order to give people a chance. > > Fine for me. I assume this is a Nack for Sergey's patch? Which patch do you mean? I'm starting to get really muddled... :-( > Best regards > Uwe MBR, Sergey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4940C433EF for ; Wed, 19 Jan 2022 10:56:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352384AbiASK4W (ORCPT ); Wed, 19 Jan 2022 05:56:22 -0500 Received: from mxout04.lancloud.ru ([45.84.86.114]:57474 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240254AbiASK4V (ORCPT ); Wed, 19 Jan 2022 05:56:21 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru A771820D27E6 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" CC: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Liam Girdwood , "Guenter Roeck" , Thierry Reding , , , Miquel Raynal , , Lee Jones , Khuong Dinh , "Florian Fainelli" , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , "Bartosz Golaszewski" , Daniel Lezcano , "Tony Luck" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Matthias Brugger" , , , Robert Richter , "Saravanan Sekar" , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , , Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , , , "Richard Weinberger" , Mun Yew Tham , "Hans de Goede" , , Yoshihiro Shimoda , Cornelia Huck , , , , , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , Brian Norris , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 13:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On 1/18/22 12:18 PM, Uwe Kleine-König wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: >>> A possible compromise: We can have both. We rename >>> platform_get_irq_optional() to platform_get_irq_silent() (or >>> platform_get_irq_silently() if this is preferred) and once all users are >>> are changed (which can be done mechanically), we reintroduce a >>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>> return 0 on not-found, no error message printking). >> >> Please do not do that as anyone trying to forward-port an old driver >> will miss the abi change of functionality and get confused. Make >> build-breaking changes, if the way a function currently works is >> changed in order to give people a chance. > > Fine for me. I assume this is a Nack for Sergey's patch? Which patch do you mean? I'm starting to get really muddled... :-( > Best regards > Uwe MBR, Sergey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3ACDC433F5 for ; Wed, 19 Jan 2022 10:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=z42Vjf+Jae7CcvogbO+AsGAquZdTSDbfKnd+ygLWpWM=; b=NX2dd8P6SwzqXQA3B7Uv09CBR2 IA+UKec9A527ogFminNkg6HMkxC2eI8EIMu4LpJS8UGa/Cxt189nzL+d+S6g4xQ9YNz7JhYaMGr3m gaweqppGpiv7uaedhp5A52GGQRq9F+nceQjAyhA4uUBpomF+fZ2gnNBXaQRIHXWEG6f2se0SH4MqC xg9EEbNv7R9ZL1uPZBO6ikSsLvyLLAQKUVQD6GAsbLetFPTRGQFa7Lah/ipdIa79a4yip+/aYhABb M9KlYKA0+q9a8y0j6U+RrZ+OgLZ997M/pNNrLOwcYM9EQ16p36obq5RxsR0AZaJT6ACGlIR2pTEvQ Pt4PrSjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA8df-00529P-0V; Wed, 19 Jan 2022 10:56:27 +0000 Received: from mxout03.lancloud.ru ([45.84.86.113]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA8da-00526A-OW; Wed, 19 Jan 2022 10:56:25 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru A788320EEBBF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" CC: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Liam Girdwood , "Guenter Roeck" , Thierry Reding , , , Miquel Raynal , , Lee Jones , Khuong Dinh , "Florian Fainelli" , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , "Bartosz Golaszewski" , Daniel Lezcano , "Tony Luck" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Matthias Brugger" , , , Robert Richter , "Saravanan Sekar" , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , , Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , , , "Richard Weinberger" , Mun Yew Tham , "Hans de Goede" , , Yoshihiro Shimoda , Cornelia Huck , , , , , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , Brian Norris , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 13:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_025623_180112_99F5C2C8 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 1/18/22 12:18 PM, Uwe Kleine-K=F6nig wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-K=F6nig wrote: >>> A possible compromise: We can have both. We rename >>> platform_get_irq_optional() to platform_get_irq_silent() (or >>> platform_get_irq_silently() if this is preferred) and once all users are >>> are changed (which can be done mechanically), we reintroduce a >>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>> return 0 on not-found, no error message printking). >> >> Please do not do that as anyone trying to forward-port an old driver >> will miss the abi change of functionality and get confused. Make >> build-breaking changes, if the way a function currently works is >> changed in order to give people a chance. > = > Fine for me. I assume this is a Nack for Sergey's patch? Which patch do you mean? I'm starting to get really muddled... :-( > Best regards > Uwe MBR, Sergey _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C20C7C433F5 for ; Wed, 19 Jan 2022 10:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=447yCZ8PnFFmVfr7H40fY9Du6HRO13xhW94EX4T/Ojw=; b=RPrFc85iwyOrXGT2Vfs8NvkPWq d+I5NaQAEZ1cscx1SPd3IY3PQ4GIAjYusAf4DT/sGEUOpS/b4H+ElREw7RoGCZyTW+WaMQZQj53gs 5kvbSOAM2PUNPBoYD1n0cNh+Fxb7nrEd2+tJE8+iXUIrK/jvCr7+ZZxlC4i9SEGyQcMcBcpxnTWQO QmkEv9uXV2bLR1wVpsMlzKoXH7lsy1c8ALYvXhz6UgoC+/7D10sf6Mj3+F2ymM3Wcy4M4+x8WgFmQ 7onh4VKrPNezN0WwtSHDuF6ZozCa4BgwyTzPLD2w7PKDToRcV/URqHBS9zBO+xKrHNuE20ah6d/Ri xXh4anqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA8dg-00529o-63; Wed, 19 Jan 2022 10:56:28 +0000 Received: from mxout03.lancloud.ru ([45.84.86.113]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA8da-00526A-OW; Wed, 19 Jan 2022 10:56:25 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru A788320EEBBF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" CC: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Liam Girdwood , "Guenter Roeck" , Thierry Reding , , , Miquel Raynal , , Lee Jones , Khuong Dinh , "Florian Fainelli" , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , "Bartosz Golaszewski" , Daniel Lezcano , "Tony Luck" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Matthias Brugger" , , , Robert Richter , "Saravanan Sekar" , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , , Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , , , "Richard Weinberger" , Mun Yew Tham , "Hans de Goede" , , Yoshihiro Shimoda , Cornelia Huck , , , , , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , Brian Norris , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 13:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_025623_180112_99F5C2C8 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 1/18/22 12:18 PM, Uwe Kleine-K=F6nig wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-K=F6nig wrote: >>> A possible compromise: We can have both. We rename >>> platform_get_irq_optional() to platform_get_irq_silent() (or >>> platform_get_irq_silently() if this is preferred) and once all users are >>> are changed (which can be done mechanically), we reintroduce a >>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>> return 0 on not-found, no error message printking). >> >> Please do not do that as anyone trying to forward-port an old driver >> will miss the abi change of functionality and get confused. Make >> build-breaking changes, if the way a function currently works is >> changed in order to give people a chance. > = > Fine for me. I assume this is a Nack for Sergey's patch? Which patch do you mean? I'm starting to get really muddled... :-( > Best regards > Uwe MBR, Sergey ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFE26C433EF for ; Wed, 19 Jan 2022 10:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7j8EPcy7QNtrHPwwXxOmsOq9l3DAb1i0HZcN5GMGhOI=; b=wEvIA3ddld1AzKB0VAEBBkMj6V hLiKvYgm44guZnVpKEAE+kOiJDoTRSlp2XO6LBsnGVuqNOyUMHFqjLHprkvB8N5B2xCh9xj0WJ/L6 V6ARsoBuBsaapopnSbR7ncFv9Dt/Aew5/uBMKVlkr1IBZHJ4gxxwUuw8zJA8HhYb0ONs5qiTLKxqx eBtYkq3hdIjDZvq0nWVs/0Sb4y9l8T56PgbG2yxNdfBI/8ZOCG+aUt3QiTctVCvIHmi+p66filuBb A12MhszSyv89L8ESnRtyl6bKbsoWBuYPNNH/ZEze5lP1jYYiN+Ie5wuC1m3yQmmqhOPFD7dSwTrk+ SKwsBhyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA8dt-0052EZ-BC; Wed, 19 Jan 2022 10:56:41 +0000 Received: from mxout03.lancloud.ru ([45.84.86.113]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA8da-00526A-OW; Wed, 19 Jan 2022 10:56:25 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru A788320EEBBF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" CC: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Liam Girdwood , "Guenter Roeck" , Thierry Reding , , , Miquel Raynal , , Lee Jones , Khuong Dinh , "Florian Fainelli" , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , "Bartosz Golaszewski" , Daniel Lezcano , "Tony Luck" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Matthias Brugger" , , , Robert Richter , "Saravanan Sekar" , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , , Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , , , "Richard Weinberger" , Mun Yew Tham , "Hans de Goede" , , Yoshihiro Shimoda , Cornelia Huck , , , , , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , Brian Norris , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 13:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_025623_180112_99F5C2C8 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 1/18/22 12:18 PM, Uwe Kleine-K=F6nig wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-K=F6nig wrote: >>> A possible compromise: We can have both. We rename >>> platform_get_irq_optional() to platform_get_irq_silent() (or >>> platform_get_irq_silently() if this is preferred) and once all users are >>> are changed (which can be done mechanically), we reintroduce a >>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>> return 0 on not-found, no error message printking). >> >> Please do not do that as anyone trying to forward-port an old driver >> will miss the abi change of functionality and get confused. Make >> build-breaking changes, if the way a function currently works is >> changed in order to give people a chance. > = > Fine for me. I assume this is a Nack for Sergey's patch? Which patch do you mean? I'm starting to get really muddled... :-( > Best regards > Uwe MBR, Sergey -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy