From: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Harald Nordgren <haraldnordgren@gmail.com>,
Harald Nordgren <haraldnordgren@gmail.com>
Subject: [PATCH v3 2/2] git-gui: silence statistics under "make -s"
Date: Sun, 21 Jun 2026 14:56:43 +0000 [thread overview]
Message-ID: <b613d4ac4a258e0e280a15547efe0b510a57e83b.1782053803.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2339.v3.git.git.1782053803.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>
The catalog rule runs msgfmt with --statistics, whose output goes to
stderr and so survives "make -s". In non-verbose builds the rule also
captures the output in a shell variable to strip it to an 80 column
line.
The statistics are not needed, as in 2f12b31b746c (Makefile: don't
invoke msgfmt with --statistics, 2021-12-17). Remove them, and with
nothing left to format make the rule as minimal as the other quiet
rules, so a quiet build stays quiet.
Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
git-gui/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index d33204e875..2e1711adc5 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -69,8 +69,7 @@ ifndef V
QUIET = @
QUIET_GEN = $(QUIET)echo ' ' GEN '$@' &&
QUIET_INDEX = $(QUIET)echo ' ' INDEX $(dir $@) &&
- QUIET_MSGFMT0 = $(QUIET)printf ' MSGFMT %12s ' $@ && v=`
- QUIET_MSGFMT1 = 2>&1` && echo "$$v" | sed -e 's/fuzzy translations/fuzzy/' | sed -e 's/ messages*//g'
+ QUIET_MSGFMT = $(QUIET)echo ' ' MSGFMT '$@' &&
INSTALL_D0 = dir=
INSTALL_D1 = && echo ' ' DEST $$dir && $(INSTALL) -d -m 755 "$$dir"
@@ -155,7 +154,7 @@ $(PO_TEMPLATE): $(SCRIPT_SH) $(ALL_LIBFILES)
update-po:: $(PO_TEMPLATE)
$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; )
$(ALL_MSGFILES): %.msg : %.po
- $(QUIET_MSGFMT0)$(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $< $(QUIET_MSGFMT1)
+ $(QUIET_MSGFMT)$(MSGFMT) --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<
lib/tclIndex: $(ALL_LIBFILES) generate-tclindex.sh GIT-GUI-BUILD-OPTIONS
$(QUIET_INDEX)$(SHELL_PATH) generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS $(ALL_LIBFILES)
--
gitgitgadget
prev parent reply other threads:[~2026-06-21 14:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 17:52 [PATCH 0/2] Silence po catalog output under "make -s" Harald Nordgren via GitGitGadget
2026-06-14 17:52 ` [PATCH 1/2] gitk: silence " Harald Nordgren via GitGitGadget
2026-06-14 17:52 ` [PATCH 2/2] git-gui: silence statistics " Harald Nordgren via GitGitGadget
2026-06-15 19:25 ` [PATCH 0/2] Silence po catalog output " Harald Nordgren
2026-06-20 15:46 ` Johannes Sixt
2026-06-20 22:46 ` [PATCH v2] gitk, git-gui: drop msgfmt --statistics output Harald Nordgren via GitGitGadget
2026-06-21 10:33 ` [PATCH 2/1] git-gui: reduce complexity of the quiet msgfmt rule Johannes Sixt
2026-06-21 13:00 ` [PATCH v2] gitk, git-gui: drop msgfmt --statistics output Johannes Sixt
2026-06-21 13:15 ` Harald Nordgren
2026-06-21 13:27 ` Johannes Sixt
2026-06-21 13:32 ` Harald Nordgren
2026-06-21 13:47 ` Johannes Sixt
2026-06-21 14:56 ` [PATCH v3 0/2] Silence po catalog output under "make -s" Harald Nordgren via GitGitGadget
2026-06-21 14:56 ` [PATCH v3 1/2] gitk: make "make -s" silent Harald Nordgren via GitGitGadget
2026-06-21 14:56 ` Harald Nordgren via GitGitGadget [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b613d4ac4a258e0e280a15547efe0b510a57e83b.1782053803.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=haraldnordgren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.