From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A17BC25B7E for ; Tue, 4 Jun 2024 09:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BEAB6B00B2; Tue, 4 Jun 2024 05:19:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E956B00B4; Tue, 4 Jun 2024 05:19:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0352B6B00B5; Tue, 4 Jun 2024 05:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D95936B00B2 for ; Tue, 4 Jun 2024 05:19:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 809BAA1E41 for ; Tue, 4 Jun 2024 09:19:11 +0000 (UTC) X-FDA: 82192657302.08.72EFF9F Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.7]) by imf24.hostedemail.com (Postfix) with ESMTP id 85139180006 for ; Tue, 4 Jun 2024 09:19:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=Ffp5j4SO; spf=pass (imf24.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.7 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717492749; a=rsa-sha256; cv=none; b=wls37/K+QbQ+7YarNtBqz0t23m7QMcMwWAEJXnhl1lbnyS7DQCDE1G5VwoOkV3O5pW+03t YVPod1VNOt+Kr1FnyFHiSp9ubf2yECk0LSt7bUA59hfUrzyAocpHZcMpSk4nxxhpfJSm4i i/AtKzU7J+Mt85wG9QmUgDsjGDLCVPY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=Ffp5j4SO; spf=pass (imf24.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.7 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717492749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2DDm8l35/Bltp4qP4Zdve1JaiaMBihsWKQJn9UAiG0g=; b=2nNbiAzBji0jGCHdi++7rp4VfjOqmazq734kYr0zw3RH/SAl90Zj1uQqCT0ItvcxfPOX6/ +YI/FUkMqQLt8oaOV9Xan+jjmFZUI7yqcIInzhJvQvjeXZcMkX+aCwgofarCm43JqpFH/y GUpNuKxes9Ea8+nLALL2WZ22+pT88rU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version: Content-Type; bh=2DDm8l35/Bltp4qP4Zdve1JaiaMBihsWKQJn9UAiG0g=; b=Ffp5j4SOSR1KmXVfar+nho8Ored+FDSzLLOrOVU6PFc97UDqBWN3jA3zxDK+Tx CgS1VBrlaD7WC4odK4/phw+03DwNgWNXaDLiesH8Srm61Xeyq8pm2BtK+zEnEi4+ T1FWjOLyGyFWzb4IoIcH5px8NTn52sIxEDWfFOqojcFdQ= Received: from [172.21.21.216] (unknown [118.242.3.34]) by gzga-smtp-mta-g1-5 (Coremail) with SMTP id _____wD33y0B3F5mbUi8Cw--.59253S2; Tue, 04 Jun 2024 17:18:58 +0800 (CST) Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: Baolin Wang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn References: <1717488551-18053-1-git-send-email-yangge1116@126.com> <89bd659b-a85f-48f2-98ce-f7522cdb95da@linux.alibaba.com> From: yangge1116 Message-ID: Date: Tue, 4 Jun 2024 17:18:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <89bd659b-a85f-48f2-98ce-f7522cdb95da@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD33y0B3F5mbUi8Cw--.59253S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww4xXr18ZF48Xr18Kr17ZFb_yoW8GF4kpF 18KF1YkFZFqryvy3W2qa95ZF90yrWqvr48Kr43JFy5CwnxWryUtr42qrn7u3Z5CrWUAa1a yrWYq3WI9F4qka7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07bOWlgUUUUU= X-Originating-IP: [118.242.3.34] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbiGAjzG2VLblcTcgAAsO X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 85139180006 X-Stat-Signature: fh3pni7t7gr8jj8xjibf813zrs687jen X-HE-Tag: 1717492748-574270 X-HE-Meta: U2FsdGVkX1/vNZp7s5wpxiLIy6R/le+BLCYvr9dp1FyvFAhmb4cJFWh4NohzmL3JFWvoVci35/d1sjLjnzqUEllM/lbz8PO6uf1FHndnOQBim2I031rp/b0VtI5jRvHlBFGJOrglilEx/TEZSHeU5IM23vlaS5oSmzfP8lFP9VnN4lZmmwzRv9gQnWOHAN8aicXeRAjumwJXV3WRo8ApwyqX2sJapLd/bbB7NIhZgHugG0Jip9NVHFLKctOZ+5eT+iL/cc5/8+KduZTm2k2lszxEjecFVS/TQQDu+5ZAsJaFisA+TF/nTKZvLYAp9WbW1zHybYmwFJ5ekeNuhgxh++tl9WrD5mVfT5r0hFLTDB1dv+MWGdvW8K/bZ11KRGWE1VbNYxhZWY/ButGnxm/1PI+A1xcQeLmSwx8E3GJsd/7nf0jYLRAW+q0IQZPl6ZvGgWvlZhHZpKICwchmeV+rVsRXF4glFBUqGndCyzzUy4vU/Ihfqqx/fkGqf2xLjLkrIrX7N+IbyXUwXuhUWAFYAwaI6DP5mwNw03ImLCRdDDIscJ1qOuoG3zl7RhCmg2Z/z1mapz+6ab9V7nPijF6cXxfc6nTb+QP4exMpp5w5ebUJLzpSKazxOUl9KmIJFjOu8dX04XWrCCkcFReib16jzSOvHZAaUK/d/2hojF9fPXDY6sDbbJ1duj4E8xPtbG1xdzl/iOwTQs/Gh3XeFwxpEAxfGJazeuWHPIe8HjQSCHFl1ktf15UWMzkTODUGETD5X8SBngv/PoSoAMdUSHTA4/Q6qfrv/VTVxrhlFIK1ODbF0zWHeKOd4ZIAY2O6hBnUMSEmHRzitK0HvbzFdtIlsitCjuiyq2lJxz+i8SUnxiD+nq821DiWVMzkkySWmDMlfAFaqSXx8oZcz1UkSMYF+Lv3FThSqbGRCtwqi8tT9eKImXOqao4St+KQrHeH0o7wp7PVsmRNHHC49sNjjla 5C6X2qjB eC8Bi+sMMphaY/anHSVFHarQt+fVoqmPiPft+3DCXWod9aGH1UYeylD9bvTHyIt4YT9QwUnnUwPp75ZmXh9MAVGrN1RbczqS94vkJHPr812j0moS07H+r5v6OZFVotkJEbgkUNAHmADmpC5PdiyKXm05Xo3Jnw1akOFNe1gNrDxqZIQMJLYAW5bdXixH8KruDmrHV9+cGaI1ZZw0RJshQZO1J2LrgFgQgD2kGcCCBk4er0vRsXF5aGS0Ol/n2MxClpiMcSgqL6wl1QPseBQaqCIB5jDdI+6rWOIrTTaHFttVUFinABehYsv2mzMV9i30osaA6oifVlUCt/ic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.037347, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/6/4 下午4:56, Baolin Wang 写道: > > > On 2024/6/4 16:09, yangge1116@126.com wrote: >> From: yangge >> >> If a page is added in pagevec, its ref count increases one, remove >> the page from pagevec decreases one. Page migration requires the >> page is not referrened by others except page mapping. Before >> migrating a page, we should try to drain the page from pagevec in >> case the page is in it, however, folio_test_lru() is not sufficient >> to tell whether the page is in pagevec or not, if the page is in >> pagevec, the migration will fail. >> >> Remove the condition and drain lru once to ensure the page is not >> referrenced by pagevec. > > This looks sane to me and seems a simple way to fix. > >> Signed-off-by: yangge >> --- >>   mm/gup.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index ca0f5ce..890dcbc 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -2411,7 +2411,7 @@ static unsigned long >> collect_longterm_unpinnable_pages( >>               continue; >>           } >> -        if (!folio_test_lru(folio) && drain_allow) { >> +        if (drain_allow) { >>               lru_add_drain_all(); >>               drain_allow = false; >>           } > > You should rebase your code on the latest mm-unstable branch, as > collect_longterm_unpinnable_pages() in the upstream has been replaced > with collect_longterm_unpinnable_folios(). Ok, thanks