All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Poosa, Karthik" <karthik.poosa@intel.com>
To: Sk Anirban <sk.anirban@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>, <badal.nilawar@intel.com>,
	<riana.tauro@intel.com>, <raag.jadav@intel.com>,
	<soham.purkait@intel.com>, <mallesh.koujalagi@intel.com>
Subject: Re: tests/intel/xe_pm_residency: skip cpg-gt-toggle if GT not in C6
Date: Fri, 15 May 2026 09:32:24 +0530	[thread overview]
Message-ID: <b62214a5-0e12-475c-aa4e-9b90883bd779@intel.com> (raw)
In-Reply-To: <20260504202840.2572025-2-sk.anirban@intel.com>


On 05-05-2026 01:58, Sk Anirban wrote:
> The test assumes GTs are idle before forcewake is acquired and power-gate
> status is validated. If a prior subtest leaves a GT in C0 (GT stays active
> for any reason), the final power-gate checks can fail for the wrong reason.
> Add an skip so that inability to enter C6 is treated as a missing
> prerequisite.
>
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   tests/intel/xe_pm_residency.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> index 1eeabd509..bfae1f844 100644
> --- a/tests/intel/xe_pm_residency.c
> +++ b/tests/intel/xe_pm_residency.c
> @@ -392,8 +392,8 @@ static void cpg_gt_toggle(int fd)
>   	int gt;
>   
>   	xe_for_each_gt(fd, gt)
> -		igt_assert_f(igt_wait(xe_gt_is_in_c6(fd, gt), 1000, 10),
> -			     "GT %d should be in C6\n", gt);
> +		igt_skip_on_f(!igt_wait(xe_gt_is_in_c6(fd, gt), 1000, 10),
> +			      "GT %d is not in C6\n", gt);
>   
>   	fw_handle = igt_debugfs_open(fd, "forcewake_all", O_RDONLY);
>   	igt_assert_lte(0, fw_handle);

LGTM.

Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>

Follow up this patch with 
https://patchwork.freedesktop.org/series/163104/  adding power powergate 
when not in C6.


      parent reply	other threads:[~2026-05-15  4:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 20:28 [PATCH] tests/intel/xe_pm_residency: skip cpg-gt-toggle if GT not in C6 Sk Anirban
2026-05-04 21:29 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-05-04 21:40 ` ✓ i915.CI.BAT: " Patchwork
2026-05-05  3:19 ` ✓ Xe.CI.FULL: " Patchwork
2026-05-05  4:09 ` ✗ i915.CI.Full: failure " Patchwork
2026-05-15  4:02 ` Poosa, Karthik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b62214a5-0e12-475c-aa4e-9b90883bd779@intel.com \
    --to=karthik.poosa@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.