Re: [PATCH v2 03/12] test: Do not set DTC environment variable

[Quentin Schulz <quentin.schulz@cherry.de>]

On 11/10/26 3:30 PM, Andrew Goodbody wrote:
> On 10/11/2026 13:30, Quentin Schulz wrote:
>> Hi Andrew,
>>
>> On 11/10/26 1:24 PM, Andrew Goodbody wrote:
>>> The presence of the DTC environment variable breaks a binman test that
>>> attempts to execute dtc from a temporary directory using the value of
>>> DTC but that is a relative directory path based on the source tree not
>>> this temporary directory and so it fails.
>>> It also breaks a buildman test that checks the environment and asserts
>>> that DTC is not present.
>>> Remove the setting of DTC as it is not needed.
>>>
>>
>> What happens if you have DTC exported in your current environment 
>> before the tests are run? It'd be nice to mention which tests exactly 
>> fail for future reference.
> 
> It will fail if DTC is already set in the environment. I will add the 
> failing test names to the commit message.
> 
>> I'm thinking this is not enough and we should also fix the binman and 
>> buildman tests to run with an environment where the DTC variable is 
>> removed/absent/set to the correct path so we don't depend on a 
>> "correct" external environment.
> 
> I was hoping that assuming a 'clean' environment would be acceptable but 
> I can look at what needs to be done to make the test work no matter what 
> the DTC variable is set to on entry.
> 

Mock the environment with with unittest.mock.patch.dict('os.environ', 
environ) for example, see tools/binman/ftest.py for examples. If you 
want to only remove some variables, you can duplicate the environment, 
delete the key from the dict and use that as mock value.

Cheers,
Quentin