All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	dri-devel@lists.freedesktop.org
Cc: Adam Ford <aford173@gmail.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Inki Dae <inki.dae@samsung.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Michael Walle <mwalle@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	kernel@dh-electronics.com
Subject: Re: [PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach
Date: Mon, 13 May 2024 16:55:35 +0200	[thread overview]
Message-ID: <b6368650-4bbf-4f86-bdb1-817c7ddb0290@denx.de> (raw)
In-Reply-To: <2283cbdf-e480-4d10-ab4e-d10dd772ef5d@samsung.com>

On 5/13/24 9:57 AM, Marek Szyprowski wrote:
> 
> On 13.05.2024 04:16, Marek Vasut wrote:
>> Initialize the bridge on attach already, to force lanes into LP11
>> state, since attach does trigger attach of downstream bridges which
>> may trigger (e)DP AUX channel mode read.
>>
>> This fixes a corner case where DSIM with TC9595 attached to it fails
>> to operate the DP AUX channel, because the TC9595 enters some debug
>> mode when it is released from reset without lanes in LP11 mode. By
>> ensuring the DSIM lanes are in LP11, the TC9595 (tc358767.c driver)
>> can be reset in its attach callback called from DSIM attach callback,
>> and recovered out of the debug mode just before TC9595 performs first
>> AUX channel access later in its attach callback.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> This patch breaks driver operation on Samsung TM2e board with S6E3HF2
> DSI panel. The initialization procedure is very fragile and it looks
> that the changes must be done very carefully. We discussed this many
> times when converting this driver from Exynos DSI to generic Samsung DSI
> used on IMX and other SoCs.

Clearly we need to find a way to support both use cases .

What options do we have ?

Does the panel require DSI lanes in some specific state when it is 
released from reset ?

  reply	other threads:[~2024-05-13 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240513021916eucas1p127a78946a07fa16a85e588a726ed9243@eucas1p1.samsung.com>
2024-05-13  2:16 ` [PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach Marek Vasut
2024-05-13  2:16   ` [PATCH 2/2] drm/bridge: tc358767: Reset chip again " Marek Vasut
2024-06-24  9:26     ` [2/2] " Alexander Stein
2024-05-13  7:57   ` [PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge " Marek Szyprowski
2024-05-13 14:55     ` Marek Vasut [this message]
2024-05-16  6:51   ` Alexander Stein
2024-06-25 12:27     ` Marek Vasut
2024-06-24  9:26   ` [1/2] " Alexander Stein
2024-06-24 13:41     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6368650-4bbf-4f86-bdb1-817c7ddb0290@denx.de \
    --to=marex@denx.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=inki.dae@samsung.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@dh-electronics.com \
    --cc=l.stach@pengutronix.de \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.