From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2504CC35FFF for ; Fri, 21 Mar 2025 10:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2EBB280004; Fri, 21 Mar 2025 06:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB502280001; Fri, 21 Mar 2025 06:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E265280004; Fri, 21 Mar 2025 06:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6BCAB280001 for ; Fri, 21 Mar 2025 06:13:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1C1AA82370 for ; Fri, 21 Mar 2025 10:13:50 +0000 (UTC) X-FDA: 83245147020.27.24E7611 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 8D27D40012 for ; Fri, 21 Mar 2025 10:13:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="h/zOY0xM"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742552027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OpoKiNz0zYG+MZwr0p3MfFv9/gi/iW8/9JNtqwEH8EY=; b=SkE4BOFEOmcLRlgYEkfJDX6MjHcl4DlzdagCG+urJNQjhAHmXSIbWWNSRC93u7X5iQe11E wOub4g+JpLi7dl36NWG2uxp5mPi590ID2MYzsCqXa5+29zlUcjoEI/+Kx7GXIxjErforxx IkBz1U/HhEcCeIEPdMTaQouarcW/5yY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="h/zOY0xM"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742552027; a=rsa-sha256; cv=none; b=bB6QoFD0WzDhajW7gEv4wU7P0FZAmz2Bzgj4czQKQG3ZGDHIR8Waebuz4B0tQa1YT1vDNs as5CKcCreIY9spkk7wmZsmyze8hw47qxeY9lpHR3ND4GkbdCD+8maLkt1eJVcQ/mPV6omL XC70wgNYU+OXxgpaf+z0CHf0xwLpjO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742552026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OpoKiNz0zYG+MZwr0p3MfFv9/gi/iW8/9JNtqwEH8EY=; b=h/zOY0xMtWGP7tzk43/XeL4b1MZdXBPHXgqELnIzAQ/2hEYRLnLjpn5lz0XGU2W1d5gCj4 hsAXpvnqd8hGS+00bH17PTnx7g0k4uRZcHdh012rbzSt7kgnRDPttQiSQASu55Qc6C5LOt 8UYYCbae+ef207wRqyR72OXlncTpado= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-PvJ3NyTDOTuzj-0zxPmxOA-1; Fri, 21 Mar 2025 06:13:45 -0400 X-MC-Unique: PvJ3NyTDOTuzj-0zxPmxOA-1 X-Mimecast-MFC-AGG-ID: PvJ3NyTDOTuzj-0zxPmxOA_1742552024 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so8698935e9.0 for ; Fri, 21 Mar 2025 03:13:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742552024; x=1743156824; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OpoKiNz0zYG+MZwr0p3MfFv9/gi/iW8/9JNtqwEH8EY=; b=NjsmpGpVrdL/fsY0Igflh+XcqpLP/Hf9fl5IWUmWFrtm98SCoTUDZc1S3dXFxeGRB5 4dTZqvPLkh2ghZvOlqTGA/hNv6slbczz9Pb2at8oGmt14d5eD6kxYSbEJJUXrECqnCn6 X9OocHQcc3XiVdirRz1HaoHNoojxO6lY+dOUoQ5Mu8P6zYYtPTmpl/Ei7FpTP6pwOrfE 7DEDYBuz0osxhXGfCmz713Ew8+msJWUwR+LEoXut40/7OtkneXFF54Mn0jEiXPQFJ8rT lEl/R9kP3GNbwU9HmgK2G+LzZ9gAkh5uINmXM75ritOcXLVqQBoFZxCNXXSbT18xG7/g ZFow== X-Forwarded-Encrypted: i=1; AJvYcCXUyDPhVLTzwHcIPHVou+7+ZWoxcbOKXATB2n7OE54Gd7i2t9gfA+oAzUcfq2voeavHRVwTuNuraw==@kvack.org X-Gm-Message-State: AOJu0YwNn89gXbRoPxHeft6G/eljP2ZHSG7dE4gFopb+3Lv6IAX/6SKy B56jwNaVg1YRsHDzUdLsgVHPrHSdVT18lFQK0XmjvyV/PAE78HHMc/vbMIKnURn+Da5XNCwoO5C PwWEEfYHfj7al14POr/nIlZzNQpcxBnKheX6r2XQYSwwn9I2X X-Gm-Gg: ASbGncv8LYKOnlZ8zzJdCvVkVZJC/E/iWNTLv+bKaECwSo+48ZnT9eO7IAS3/GlpWhS qTMA5qm5VAIAQf/beoxeCkzkSPqvV+1TXH7+/TDY1AhZNVGFCeKNaoWI324Vy/EivzTky/DmHlg inuG1rTd0Yfp7Gnh3z/GHcyB6ZyKvUp3GCmEl6FQ6vUKyR9HGrU/bEWze4kFMFEKaYpCisI+/bp DTEK8OMB04g/G040S5q4nK+F1tXnUwA7qDE2dNkAl7mCyFQmLVynNuPYkIYQWP3FILPWEYeSF7J I3eI0WKDZnNEGBGeaSr40ywzvL2t9tq9ZH7IcPweB9LmWQ64SE8et4l4eqAA/DhKgcJbbjAFkOo aGjz+QbHIfNzKHfOjPYVCn5bIW+qL45dzvTd7Dh1o+hw= X-Received: by 2002:a05:600c:3ca5:b0:43d:ed:acd5 with SMTP id 5b1f17b1804b1-43d509edc2emr21843505e9.10.1742552023637; Fri, 21 Mar 2025 03:13:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBP4NnEBTa8zS0JzRR4KVNM50Jg6dbKBkeZvydjC/x9TK+BLltYzF5+LQX+YUo6w3oEcYOxg== X-Received: by 2002:a05:600c:3ca5:b0:43d:ed:acd5 with SMTP id 5b1f17b1804b1-43d509edc2emr21843225e9.10.1742552023173; Fri, 21 Mar 2025 03:13:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c72a:9100:23d2:3800:cdcc:90f0? (p200300cbc72a910023d23800cdcc90f0.dip0.t-ipconnect.de. [2003:cb:c72a:9100:23d2:3800:cdcc:90f0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f33242sm73565295e9.5.2025.03.21.03.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 03:13:42 -0700 (PDT) Message-ID: Date: Fri, 21 Mar 2025 11:13:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: Fix parameter passed to page_mapcount_is_type() To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321053148.1434076-1-gshan@redhat.com> <20250321053148.1434076-2-gshan@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250321053148.1434076-2-gshan@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4TreDAceKpLpvqW4IhLuoWx4N-hzo0Zk1DW33Qc_AYo_1742552024 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: un58xo15phz358kj4e1ns6f9fxd11iko X-Rspam-User: X-Rspamd-Queue-Id: 8D27D40012 X-HE-Tag: 1742552027-22967 X-HE-Meta: U2FsdGVkX1+FnIifMnbrSZn2WuppbmsuGC+g4M4AYGKRNArXNzI/jsdSFpecONgM/mshIsn91/k7iinsCMvN1mfRrG//fiR95G/NYWdkz5CtlUkyLgYAos6zubj6UvCg1LD/r3EiVS+FabMMtEa0fCh9aQfZC3FEkYsfNsRM8q2f8aqLkT4/hdD8SIfnPtK6JrEEpd+XREdOk4uEgRcIgX4KG+PxKavvjK1vKqatEgAlxfxtxtSjV717BgdZEM8v/uGotKgmfRYnNsgj83kOt9CCcamGe64iEKHmOCDt7T71iuVELGFAK5IiAjrfM5FUiHkiYj1wC6uc+pZfhiXBA+vVHPHoByiEUZ1WSE2zxTu6U/b3+56orcKCzkMQsil6zdjCxuBA1WPxxTAfPpuN8h+fyNkX2d9+xa0IzZZfxHJIZyefSU5KqeZ0W4JOKhpG+uwNp21bEvZLUcTSthbbquBsUeOuZy7jjR5CG3g0FTajyCEzW0Wpolyu49yS+QXwYDeB8O6P+RK/krZxsAUZ5IBZzyeb8f+YC+ob/3Ep5Yi264eQozDu8clfe7OQm3NHmiYhb6MKAxrrm97WcoBEOtv9ZfrdeFW2MQ/klxOT8EXdzT1qePE+ZDl5NIoyaL2NktPhwnQpGz2k3yplcFTugzPsyqF94oJ6bTG2CIhWyO9PC90/e2YazII695s34eYa7pSpTLWGOBLPdpRFXdhFMuOCVV6DFmyk+q3kuTntI/dKfit/AX+LxOLw6hKybVO9OWSobqhdUfUbq78JN9xYhTWmwYy9Y7aW8NPj1Xfgq7pl6lm8lVdCJjOGjAtp0nUcP3FkgjaFjotyn3CH0gY6W+oDdxdS0opGfzDW7hyAwC0VL++P0P3CvieIPChFrr2bra2phoIZA9CViMZ4p5J+cGcg0mBNG9GEdUNJwwZJA7H0jFPAMZZ8sxWoSj0ueVNsJhSF8Zu095HtJP0tksb P9ZnFbjh 6RTyHnSD2GIjjPZgVUIOj6NRI+SWSb/TGHXJvhhA0EEuSyfAVeDLl1Vg5I/sIWhkJXQWCqBqoaZO6lMkY4QMBl3iwjPd+i8F/5VWQWCOAh+l+uwFiS3Sa8FukK/FAa8ukbHbaFc1a+njqUzyF2LW+c6VZ/85VX1WxCLV+iuMVWrM7lKw4xkwE1I3sWWHO5yjZi/hiXF49CjlqC84vVUwXwvtUr532tqhQGSe6h0SYw+bcSAx+V/LoWcK7NJQpNKnsmY44RGpkXjksWWnJawywlIyNYZ0/tyDFXO0KAaT3G0HCl1F60qW6Moh9OnzN12o1jZE9mf46sJ/DJg5ar3gT0flupPoT1V2zNAqBIwl8xMRmpxOBsZ1Acau+15Zdyq+ANkCdPdubUASqnAUTxhWBsFhPwKD1fUInEauBjmacKGQjC+0XXY46Z2I8YuqN7mlDcnYLCSqLbgQQ0Vgkkj1Ryfvph6Svb7kphur/wQkbUGJa6iPpWwVTL2L+X9j0iBU4oNHMN4bkNdf+6+8VbjMPx0STgk7tMh6GIg9Zz5a9WBXKhgrQd3slyNnmzlnuDQW8lE3F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.25 06:31, Gavin Shan wrote: > As the comments of page_mapcount_is_type() indicate, the parameter > passed to the function should be one more than page->__mapcount. > However, page->__mapcount (equivalent to page->page_type) is passed to > the function by commit 4ffca5a96678 ("mm: support only one page_type per > page") where page_type_has_type() is replaced by page_mapcount_is_type(), > but the parameter isn't adjusted. > > Fix the parameter passed to page_mapcount_is_type() to be (page->__mapcount > + 1). > > Fixes: 4ffca5a96678 ("mm: support only one page_type per page") > Cc: stable@vger.kernel.org # v6.12+ > Signed-off-by: Gavin Shan > --- > include/linux/page-flags.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 36d283552f80..ad87b4cf1f9a 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -950,7 +950,7 @@ static inline bool page_mapcount_is_type(unsigned int mapcount) > > static inline bool page_has_type(const struct page *page) > { > - return page_mapcount_is_type(data_race(page->page_type)); > + return page_mapcount_is_type(data_race(page->page_type) + 1); Probably we should just call page_type_has_type() instead? -- Cheers, David / dhildenb