From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m43-15.mailgun.net ([69.72.43.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmpWh-0008IR-JO for ath10k@lists.infradead.org; Wed, 09 Dec 2020 02:48:25 +0000 MIME-Version: 1.0 Date: Wed, 09 Dec 2020 10:48:21 +0800 From: Wen Gong Subject: Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons In-Reply-To: References: <20200922022818.15855-1-thomas@adapt-ip.com> <20200922022818.15855-14-thomas@adapt-ip.com> <6064b579538afca27c511edeb5400032@codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Thomas Pedersen Cc: Johannes Berg , linux-wireless , ath11k@lists.infradead.org, ath10k@lists.infradead.org On 2020-12-09 02:19, Thomas Pedersen wrote: > Hi Wen, > > On 2020-12-07 23:44, Wen Gong wrote: >> On 2020-09-22 10:28, Thomas Pedersen wrote: >>> S1G beacons are 802.11 Extension Frames, so the fixed >>> header part differs from regular beacons. >>> >>> Add a handler to process S1G beacons and abstract out the >>> fetching of BSSID and element start locations in the >>> beacon body handler. >>> >>> Signed-off-by: Thomas Pedersen >>> --- >>> net/mac80211/ieee80211_i.h | 4 ++ >>> net/mac80211/iface.c | 5 +++ >>> net/mac80211/mlme.c | 84 >>> +++++++++++++++++++++++++++++--------- >>> net/mac80211/rx.c | 84 >>> ++++++++++++++++---------------------- >>> net/mac80211/util.c | 52 +++++++++++++++++++++++ >>> 5 files changed, 162 insertions(+), 67 deletions(-) >>> >> ... >>> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct >>> ieee80211_rx_data *rx) >>> } >>> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) { >>> sta->rx_stats.last_rx = jiffies; >>> - } else if (!is_multicast_ether_addr(hdr->addr1)) { >>> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) && >>> + is_multicast_ether_addr(hdr->addr1)) { >> is this a typo mistake? >> it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==> >> is_multicast_ether_addr) > > Yes that does look like a typo, it should be: > > } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) && > !is_multicast_ether_addr(hdr->addr1)) { > > (because is_multicast_ether_addr() evaluates to true for s1g beacons). > > Do you have a patch or would you like me to send a fixup? Yes, I have a patch for it. I will send it. > > Thanks, _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m43-15.mailgun.net ([69.72.43.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmpWh-0008IQ-SW for ath11k@lists.infradead.org; Wed, 09 Dec 2020 02:48:25 +0000 MIME-Version: 1.0 Date: Wed, 09 Dec 2020 10:48:21 +0800 From: Wen Gong Subject: Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons In-Reply-To: References: <20200922022818.15855-1-thomas@adapt-ip.com> <20200922022818.15855-14-thomas@adapt-ip.com> <6064b579538afca27c511edeb5400032@codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Thomas Pedersen Cc: Johannes Berg , linux-wireless , ath11k@lists.infradead.org, ath10k@lists.infradead.org On 2020-12-09 02:19, Thomas Pedersen wrote: > Hi Wen, > > On 2020-12-07 23:44, Wen Gong wrote: >> On 2020-09-22 10:28, Thomas Pedersen wrote: >>> S1G beacons are 802.11 Extension Frames, so the fixed >>> header part differs from regular beacons. >>> >>> Add a handler to process S1G beacons and abstract out the >>> fetching of BSSID and element start locations in the >>> beacon body handler. >>> >>> Signed-off-by: Thomas Pedersen >>> --- >>> net/mac80211/ieee80211_i.h | 4 ++ >>> net/mac80211/iface.c | 5 +++ >>> net/mac80211/mlme.c | 84 >>> +++++++++++++++++++++++++++++--------- >>> net/mac80211/rx.c | 84 >>> ++++++++++++++++---------------------- >>> net/mac80211/util.c | 52 +++++++++++++++++++++++ >>> 5 files changed, 162 insertions(+), 67 deletions(-) >>> >> ... >>> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct >>> ieee80211_rx_data *rx) >>> } >>> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) { >>> sta->rx_stats.last_rx = jiffies; >>> - } else if (!is_multicast_ether_addr(hdr->addr1)) { >>> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) && >>> + is_multicast_ether_addr(hdr->addr1)) { >> is this a typo mistake? >> it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==> >> is_multicast_ether_addr) > > Yes that does look like a typo, it should be: > > } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) && > !is_multicast_ether_addr(hdr->addr1)) { > > (because is_multicast_ether_addr() evaluates to true for s1g beacons). > > Do you have a patch or would you like me to send a fixup? Yes, I have a patch for it. I will send it. > > Thanks, -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B500C433FE for ; Wed, 9 Dec 2020 02:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1BA92388B for ; Wed, 9 Dec 2020 02:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbgLICtN (ORCPT ); Tue, 8 Dec 2020 21:49:13 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:34918 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgLICtN (ORCPT ); Tue, 8 Dec 2020 21:49:13 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1607482128; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=46bJUxgq79O6ZYLsq5vRFJDYjMMuddxgHfULx7TR2ZM=; b=LNAS94BMkgiNWrMZjAR6WF0vYcWKC13ykSo8e8fV1idiYd8szrFfSTuJREbvSsr6H10NlxAZ PGT79eD4cPgXdKs4xduaYQrBe1G2UycYMEFMy4QmMaYKfbUpqcDf30uj0pOr6GGDXrBAIi62 Q7/wuSUgE6kEC0ZL6QBEdME4MAA= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5fd03af66d5c2f1d206d0e6b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 09 Dec 2020 02:48:22 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4042EC43463; Wed, 9 Dec 2020 02:48:22 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8E8EDC433C6; Wed, 9 Dec 2020 02:48:21 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 09 Dec 2020 10:48:21 +0800 From: Wen Gong To: Thomas Pedersen Cc: Johannes Berg , linux-wireless , ath10k@lists.infradead.org, ath11k@lists.infradead.org Subject: Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons In-Reply-To: References: <20200922022818.15855-1-thomas@adapt-ip.com> <20200922022818.15855-14-thomas@adapt-ip.com> <6064b579538afca27c511edeb5400032@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-12-09 02:19, Thomas Pedersen wrote: > Hi Wen, > > On 2020-12-07 23:44, Wen Gong wrote: >> On 2020-09-22 10:28, Thomas Pedersen wrote: >>> S1G beacons are 802.11 Extension Frames, so the fixed >>> header part differs from regular beacons. >>> >>> Add a handler to process S1G beacons and abstract out the >>> fetching of BSSID and element start locations in the >>> beacon body handler. >>> >>> Signed-off-by: Thomas Pedersen >>> --- >>> net/mac80211/ieee80211_i.h | 4 ++ >>> net/mac80211/iface.c | 5 +++ >>> net/mac80211/mlme.c | 84 >>> +++++++++++++++++++++++++++++--------- >>> net/mac80211/rx.c | 84 >>> ++++++++++++++++---------------------- >>> net/mac80211/util.c | 52 +++++++++++++++++++++++ >>> 5 files changed, 162 insertions(+), 67 deletions(-) >>> >> ... >>> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct >>> ieee80211_rx_data *rx) >>> } >>> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) { >>> sta->rx_stats.last_rx = jiffies; >>> - } else if (!is_multicast_ether_addr(hdr->addr1)) { >>> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) && >>> + is_multicast_ether_addr(hdr->addr1)) { >> is this a typo mistake? >> it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==> >> is_multicast_ether_addr) > > Yes that does look like a typo, it should be: > > } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) && > !is_multicast_ether_addr(hdr->addr1)) { > > (because is_multicast_ether_addr() evaluates to true for s1g beacons). > > Do you have a patch or would you like me to send a fixup? Yes, I have a patch for it. I will send it. > > Thanks,