All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org, Mlody12 mlody12 <kudzo51@gmail.com>
Subject: Re: [PATCH net-next 1/3] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT
Date: Sun, 15 Nov 2026 19:49:25 +0100	[thread overview]
Message-ID: <b66402beeb5ad97ce60db4e127543b90@tipi-net.de> (raw)
In-Reply-To: <20261113211554.2058181-2-florian.fainelli@broadcom.com>

On 13.11.2026 22:15, Florian Fainelli wrote:
> The MDIO_CMD operation code field starts at bit 26. Define
> MDIO_OP_SHIFT for it and use it to build the opcodes instead of open
> coding the shift.
> 
> While at it, rename MDIO_RD and MDIO_WR to MDIO_RD_C22 and MDIO_WR_C22 
> to
> make it clear that these are the Clause 22 opcodes, in preparation for
> adding the Clause 45 ones.
> 
> No functional change.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

> [...]

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks,
Nicolai

  parent reply	other threads:[~2026-11-15 18:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 21:15 [PATCH net-next 0/3] net: mdio: Clause 45 support for Florian Fainelli
2026-11-13 21:15 ` [PATCH net-next 1/3] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-13 21:55   ` Andrew Lunn
2026-11-15 18:49   ` Nicolai Buchwitz [this message]
2026-11-13 21:15 ` [PATCH net-next 2/3] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-13 21:58   ` Andrew Lunn
2026-11-15 18:51   ` Nicolai Buchwitz
2026-11-13 21:15 ` [PATCH net-next 3/3] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-13 22:04   ` Andrew Lunn
2026-11-13 22:14     ` Florian Fainelli
2026-11-15 18:59   ` Nicolai Buchwitz
2026-11-16 18:54     ` Florian Fainelli
2026-11-17  9:32       ` Nicolai Buchwitz
2026-11-17 21:39   ` netdev-bot+sashiko
2026-11-17 23:16     ` Florian Fainelli
2026-11-14  0:00 ` [PATCH net-next 0/3] net: mdio: Clause 45 support for Kordian Chmielewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b66402beeb5ad97ce60db4e127543b90@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kudzo51@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.