From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31C53033E for ; Wed, 29 Nov 2023 15:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KVed2Zjg" Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4BE47821E3 for ; Wed, 29 Nov 2023 15:22:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4BE47821E3 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=KVed2Zjg X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -2.1 X-Spam-Level: Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ij3OpeGn4xV1 for ; Wed, 29 Nov 2023 15:22:40 +0000 (UTC) X-Greylist: delayed 1893 seconds by postgrey-1.37 at util1.osuosl.org; Wed, 29 Nov 2023 15:22:40 UTC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 020AE821DD Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [IPv6:2001:41d0:1004:224b::bb]) by smtp1.osuosl.org (Postfix) with ESMTPS id 020AE821DD for ; Wed, 29 Nov 2023 15:22:39 +0000 (UTC) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701271358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQiZ+7wAuSeNjpj8apTyPg8hJlrrmCrTI0XRLYKF0N8=; b=KVed2Zjgv7XeII9r2X+MTlQ6MpHbUpzjRjxCRVryPjqS7WQgL/klPvl0DGCIJtn+2HJ9i0 zpbKIVf6tnVZwxthxtzt9g6JYlqiuCCWus9aNEciqYzPTrPZXLvo98bW6UJ4CPgjB7NzAd duAQwvGTlZusGXFH/EPUzS2lSrfQJfM= Date: Wed, 29 Nov 2023 23:22:30 +0800 Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance To: "Michael S. Tsirkin" Cc: Liang Chen , jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xuanzhuo@linux.alibaba.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, alexander.duyck@gmail.com References: <20230526054621.18371-1-liangchen.linux@gmail.com> <20230526054621.18371-2-liangchen.linux@gmail.com> <20231129095825-mutt-send-email-mst@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20231129095825-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2023/11/29 22:59, Michael S. Tsirkin 写道: > On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: >> 在 2023/5/26 13:46, Liang Chen 写道: > > what made you respond to a patch from May, now? I want to apply page_pool to our virtio_net. This virtio_net works on our device. I want to verify whether page_pool on virtio_net with our device can improve the performance or not. And I found that ethtool is wrong. I use virtio_net on our device. I found that page member variable in rq is not used in recv path. When virtio_net is modprobe, I checked page member variable in rq with kprobe or crash tool.  page member variable in rq is always NULL. But sg in recv path is used. So how to use page member variable in rq? If page member variable in rq is always NULL, can we remove it? BTW, I use ping and iperf tool to make tests with virtio_net. In the tests, page member variable in rq is always NULL. It is interesting. Zhu Yanjun >