From: "Alexey Dobriyan" <adobriyan@gmail.com>
To: torvalds@osdl.org
Cc: akpm@osdl.org, mpm@selenic.com, linux-kernel@vger.kernel.org
Subject: *sigh* /proc/*/pagemap
Date: Sat, 5 Jul 2008 05:07:02 +0400 [thread overview]
Message-ID: <b6fcc0a0807041807p24cce461m419d7b54fce72d34@mail.gmail.com> (raw)
I'm few days from my patch-sending facility, but could someone
_please_ do the following before release:
1) initialize pagemap_walk.mm to "mm" , so the code starts working as
advertised, and
2) also initialize ->private to "&pm" so it wouldn't immediately oops
in pagemap_pte_hole(), and
3) unstatic struct pagemap_walk, so two threads won't fsckup each other
(including those started by root, including flipping ->mm when you
don't have permissions),
and
4) remove second ptrace_may_attach(), and
5) check with microscope allocation there -- page-aligned address and size == 0
should allocate 0 bytes, and
6) actually check that it works.
next reply other threads:[~2008-07-05 1:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 1:07 Alexey Dobriyan [this message]
2008-07-05 1:53 ` *sigh* /proc/*/pagemap Andrew Morton
2008-07-05 7:44 ` Alexey Dobriyan
2008-07-05 8:02 ` Andrew Morton
[not found] ` <28fa9c5e0807161906q68411e9bn5975dc277f67b086@mail.gmail.com>
2008-07-17 20:17 ` Alexey Dobriyan
2008-07-05 17:40 ` Linus Torvalds
2008-07-07 18:23 ` Matt Mackall
2008-07-07 18:34 ` Linus Torvalds
2008-07-07 18:51 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fcc0a0807041807p24cce461m419d7b54fce72d34@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.