All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Jingbo Xu <jefflexu@linux.alibaba.com>,
	xiang@kernel.org, linux-erofs@lists.ozlabs.org
Cc: chao@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] erofs: support SEEK_HOLE/SEEK_DATA in inode_share mode
Date: Mon, 24 Aug 2026 08:44:05 +0800	[thread overview]
Message-ID: <b74b343f-d9f2-48c4-b3cb-8deb6805d6d8@kernel.org> (raw)
In-Reply-To: <20260820134006.66208-1-jefflexu@linux.alibaba.com>

On 8/20/26 21:40, Jingbo Xu wrote:
> When inode_share is enabled, erofs_ishare_fops.llseek falls back to
> generic_file_llseek, which treats the whole file as data and always
> returns i_size for SEEK_HOLE, hiding real holes in sparse files.
> 
> Switch it to erofs_file_llseek instead.  For user files f_mapping->host
> is always the real erofs inode, so SEEK_HOLE/SEEK_DATA resolve the
> per-file on-disk layout via iomap_seek_hole()/iomap_seek_data().
> 
> Reviewed-by: Gao Xiang <xiang@kernel.org>
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


      reply	other threads:[~2026-08-24  0:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 13:40 [PATCH v2] erofs: support SEEK_HOLE/SEEK_DATA in inode_share mode Jingbo Xu
2026-08-24  0:44 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b74b343f-d9f2-48c4-b3cb-8deb6805d6d8@kernel.org \
    --to=chao@kernel.org \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.