From: Reinette Chatre <reinette.chatre@intel.com>
To: <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>
Cc: <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
<akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
<rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
<songmuchun@bytedance.com>, <peterz@infradead.org>,
<jpoimboe@kernel.org>, <pbonzini@redhat.com>,
<chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
<jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
<sandipan.das@amd.com>, <tony.luck@intel.com>,
<james.morse@arm.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
<eranian@google.com>, <christophe.leroy@csgroup.eu>,
<jarkko@kernel.org>, <adrian.hunter@intel.com>,
<quic_jiles@quicinc.com>, <peternewman@google.com>
Subject: Re: [PATCH v6 7/8] x86/resctrl: Introduce "-o debug" mount option
Date: Tue, 8 Aug 2023 10:09:08 -0700 [thread overview]
Message-ID: <b74b543e-ea5e-4c60-1f37-eade3affdd9c@intel.com> (raw)
In-Reply-To: <091884b4-d479-9b24-013c-8d5dd9eb4ecd@amd.com>
Hi Babu,
On 8/8/2023 9:29 AM, Moger, Babu wrote:
> On 8/4/23 15:42, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 7/19/2023 4:22 PM, Babu Moger wrote:
>>> @@ -2591,6 +2599,8 @@ static int rdt_get_tree(struct fs_context *fc)
>>> out_schemata_free:
>>> schemata_list_destroy();
>>> out_ctx:
>>> + if (ctx->enable_debug)
>>> + resctrl_debug = false;
>>> if (ctx->enable_mba_mbps)
>>> set_mba_sc(false);
>>> cdp_disable_all();
>>
>> These changes are a red flag to me. Developers still need to
>> do what patch #4 was aiming to prevent.
>
> I think you meant patch 5 (x86/resctrl: Unwind the errors inside
> rdt_enable_ctx).
>
> I can take care of this unwind part in rdt_disable_ctx() and call it here.
> https://lore.kernel.org/lkml/9fd70ef3-ca90-65e3-4746-7d574bdd159b@intel.com/#t
>
> Hope that is what you meant.
It is. Thank you for reading what I meant to write.
Reinette
next prev parent reply other threads:[~2023-08-08 20:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 23:21 [PATCH v6 0/8] x86/resctrl: Miscellaneous resctrl features Babu Moger
2023-07-19 23:21 ` [PATCH v6 1/8] x86/resctrl: Add multiple tasks to the resctrl group at once Babu Moger
2023-07-19 23:21 ` [PATCH v6 2/8] x86/resctrl: Simplify rftype flag definitions Babu Moger
2023-07-19 23:21 ` [PATCH v6 3/8] x86/resctrl: Rename rftype flags for consistency Babu Moger
2023-07-19 23:21 ` [PATCH v6 4/8] x86/resctrl: Add comments on RFTYPE flags hierarchy Babu Moger
2023-08-04 20:39 ` Reinette Chatre
2023-08-07 15:40 ` Moger, Babu
2023-08-11 20:15 ` Moger, Babu
2023-07-19 23:22 ` [PATCH v6 5/8] x86/resctrl: Unwind the errors inside rdt_enable_ctx Babu Moger
2023-08-04 20:41 ` Reinette Chatre
2023-08-07 16:19 ` Moger, Babu
2023-07-19 23:22 ` [PATCH v6 6/8] x86/resctrl: Move default control group creation during mount Babu Moger
2023-08-04 20:42 ` Reinette Chatre
2023-08-08 16:22 ` Moger, Babu
2023-07-19 23:22 ` [PATCH v6 7/8] x86/resctrl: Introduce "-o debug" mount option Babu Moger
2023-08-04 20:42 ` Reinette Chatre
2023-08-08 16:29 ` Moger, Babu
2023-08-08 17:09 ` Reinette Chatre [this message]
2023-07-19 23:22 ` [PATCH v6 8/8] x86/resctrl: Display hardware ids of resource groups Babu Moger
2023-08-02 1:36 ` [PATCH v6 0/8] x86/resctrl: Miscellaneous resctrl features Shaopeng Tan (Fujitsu)
2023-08-08 16:48 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74b543e-ea5e-4c60-1f37-eade3affdd9c@intel.com \
--to=reinette.chatre@intel.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=babu.moger@amd.com \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=quic_jiles@quicinc.com \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.