From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6571AC4167B for ; Sun, 10 Dec 2023 10:10:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D7A5061059; Sun, 10 Dec 2023 10:10:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D7A5061059 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702203015; bh=ADWraa4k6eG9yRfXT8esIb4uBfUGVf3puQ/Hyk4wQeA=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qnhaoB0ojoQtjiztGAZfBHHyUfe7QPRhKMeHchYLDm74H+lJY4u5M4P3246xtN2Sc WnGH+V2rjOUNOnhLKdG/oVnEz6rMjiCyNT6g9/o8lU50AK3jNg5oVFHGAGQpvNFBQw edvuHCMfsfu85cxucHV4ZKUVagqwBusQYUmvkDFb+PEDbI+DK8Mwdzs9EnpowxNCm6 A2W0K0FspVvRXtRDbnhApNKSbJeTjxGQI60Hjntb0o8Q4hqQTcWD/1Ym8p42ESBjTd Y5x7rlMYbDsTd7n8bG9N1S3DAwsjHewe+HL6pclqNVF6Bgf4iMO5s8Ifb2rriQe9JS 0nki7aLWvmw3w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U8adPSQEyxoY; Sun, 10 Dec 2023 10:10:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E239C6103B; Sun, 10 Dec 2023 10:10:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E239C6103B Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E1AEC1BF5AA for ; Sun, 10 Dec 2023 10:10:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BD7FE405F1 for ; Sun, 10 Dec 2023 10:10:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BD7FE405F1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qKINevkSrtk4 for ; Sun, 10 Dec 2023 10:10:12 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by smtp2.osuosl.org (Postfix) with ESMTPS id D9F37404AE for ; Sun, 10 Dec 2023 10:10:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D9F37404AE X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="384957270" X-IronPort-AV: E=Sophos;i="6.04,265,1695711600"; d="scan'208";a="384957270" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2023 02:10:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="722391237" X-IronPort-AV: E=Sophos;i="6.04,265,1695711600"; d="scan'208";a="722391237" Received: from naamamex-mobl.ger.corp.intel.com (HELO [10.251.181.21]) ([10.251.181.21]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2023 02:10:06 -0800 Message-ID: Date: Sun, 10 Dec 2023 12:10:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "David S. Miller" , Eric Dumazet , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Jesse Brandeburg , Jonathan Cameron , netdev@vger.kernel.org, Paolo Abeni , Tony Nguyen , linux-kernel@vger.kernel.org References: <20231121123428.20907-1-ilpo.jarvinen@linux.intel.com> <20231121123428.20907-3-ilpo.jarvinen@linux.intel.com> From: "naamax.meir" In-Reply-To: <20231121123428.20907-3-ilpo.jarvinen@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702203012; x=1733739012; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=5FnYIJIbR+wsxAQWvfQ77OzwqLrChyDizMkLcyyll9A=; b=WiMEF0bjHcfyv3Az2m4rl6vuTbS1CWUvDNIjK/MUncR2X2o2NGPjjEfJ t171Vz0CLyhcfuzTxqIHSCAiNDl6JWMunv95sfjoGdbIZNd73/0PYg0Gr /goIjsYQjvzrXxKnpkCxGN104eTdFZFak2g5+5OfV6bi4Gp/bFHD4kw6l gstNYmSb6Qbtge7sTtycwmO38BXDEdIdy75R8KfN60Sc50Y8FmQyUEElJ 1Xm985Yhcye4X3OF2do795mHWhG/zZUVoFJecdqFRcVe+B+UkMIOLWLqw GtkE5HhYEhQ+XbRcd82ZrUfic0tvLC1Tb9RYZ66WT2U7ew3FfXgKfLIIm g==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WiMEF0bj Subject: Re: [Intel-wired-lan] [PATCH v4 2/3] e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom defines/code X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gMTEvMjEvMjAyMyAxNDozNCwgSWxwbyBKw6RydmluZW4gd3JvdGU6Cj4gZTEwMDBlIGhhcyBv d24gY29weSBvZiBQQ0kgTmVnb3RpYXRlZCBMaW5rIFdpZHRoIGZpZWxkIGRlZmluZXMuIFVzZSB0 aGUKPiBvbmVzIGZyb20gaW5jbHVkZS91YXBpL2xpbnV4L3BjaV9yZWdzLmggaW5zdGVhZCBvZiB0 aGUgY3VzdG9tIG9uZXMgYW5kCj4gcmVtb3ZlIHRoZSBjdXN0b20gb25lcyBhbmQgY29udmVydCB0 byBGSUVMRF9HRVQoKS4KPiAKPiBTdWdnZXN0ZWQtYnk6IEpvbmF0aGFuIENhbWVyb24gPEpvbmF0 aGFuLkNhbWVyb25AaHVhd2VpLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBJbHBvIErDpHJ2aW5lbiA8 aWxwby5qYXJ2aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEpvbmF0aGFuIENh bWVyb24gPEpvbmF0aGFuLkNhbWVyb25AaHVhd2VpLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvbmV0 L2V0aGVybmV0L2ludGVsL2UxMDAwZS9kZWZpbmVzLmggfCAyIC0tCj4gICBkcml2ZXJzL25ldC9l dGhlcm5ldC9pbnRlbC9lMTAwMGUvbWFjLmMgICAgIHwgNyArKysrLS0tCj4gICAyIGZpbGVzIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCgpUZXN0ZWQtYnk6IE5hYW1h IE1laXIgPG5hYW1heC5tZWlyQGxpbnV4LmludGVsLmNvbT4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtd2lyZWQtbGFuIG1haWxpbmcgbGlzdApJ bnRlbC13aXJlZC1sYW5Ab3N1b3NsLm9yZwpodHRwczovL2xpc3RzLm9zdW9zbC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC13aXJlZC1sYW4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F734C4167B for ; Sun, 10 Dec 2023 10:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231805AbjLJKKF (ORCPT ); Sun, 10 Dec 2023 05:10:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjLJKKE (ORCPT ); Sun, 10 Dec 2023 05:10:04 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F35AF1; Sun, 10 Dec 2023 02:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702203011; x=1733739011; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=5FnYIJIbR+wsxAQWvfQ77OzwqLrChyDizMkLcyyll9A=; b=Q31NgcN20hkOofpjbnhNl2dC7wPfr432SIuT8GV0SazKaE/DBm+WOqbQ 7VEtmP3FOjenLbFOlf15iaU4QzyRy9xJ5/v5rQ3gP241CGau8ibhBTiMT hnlXQyAf/b40q6CM8klg17me5qTdfYeTK2M7X9fxQxHsoDA1ilpKM1dPU jYi70s4yNOMI57JJZ02nPmlfBfGm4mpdt/olcg07Bt0rbTTltWYRRy/WF /Z6TL91ROtk8if/vIF6RfqPJm9tS9C2wHT30pSszkycf9FceNXUEfEL2s cfsv7eSp/Tu4jsQQI08QunVadKdr+It95+FDEs8zKMdQAoaX1A/+AyEH9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="384957266" X-IronPort-AV: E=Sophos;i="6.04,265,1695711600"; d="scan'208";a="384957266" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2023 02:10:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="722391237" X-IronPort-AV: E=Sophos;i="6.04,265,1695711600"; d="scan'208";a="722391237" Received: from naamamex-mobl.ger.corp.intel.com (HELO [10.251.181.21]) ([10.251.181.21]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2023 02:10:06 -0800 Message-ID: Date: Sun, 10 Dec 2023 12:10:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH v4 2/3] e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom defines/code Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "David S. Miller" , Eric Dumazet , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Jesse Brandeburg , Jonathan Cameron , netdev@vger.kernel.org, Paolo Abeni , Tony Nguyen , linux-kernel@vger.kernel.org References: <20231121123428.20907-1-ilpo.jarvinen@linux.intel.com> <20231121123428.20907-3-ilpo.jarvinen@linux.intel.com> From: "naamax.meir" In-Reply-To: <20231121123428.20907-3-ilpo.jarvinen@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2023 14:34, Ilpo Järvinen wrote: > e1000e has own copy of PCI Negotiated Link Width field defines. Use the > ones from include/uapi/linux/pci_regs.h instead of the custom ones and > remove the custom ones and convert to FIELD_GET(). > > Suggested-by: Jonathan Cameron > Signed-off-by: Ilpo Järvinen > Reviewed-by: Jonathan Cameron > --- > drivers/net/ethernet/intel/e1000e/defines.h | 2 -- > drivers/net/ethernet/intel/e1000e/mac.c | 7 ++++--- > 2 files changed, 4 insertions(+), 5 deletions(-) Tested-by: Naama Meir