From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B041B3930; Mon, 25 Nov 2024 17:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732554098; cv=none; b=iwEwwCvsB1jT8Zu8ACdD/fOqDGpiF/5W+EMZRsAz5gNg0rWZ8pAX+LK3wslmLUTH+u40QFskhAxsm0p1jXLImrVycJLp0uuXrGQrWoLi/lDqnbDGroC1Tj02GQ142DiO+xSW30igR61XjJXZoE/+Ncw64f0jJV0uQklhlDV6G8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732554098; c=relaxed/simple; bh=HlYatPRssPObd56rmxeNiT4ErQeIene20vo3pRYhOUQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=isvavJWEaZ0ucOWosVm5ThYkW3pKGxwgXWLOGVZwJ1kQbqv/OjiOR/PU9x1cddP9/4vKolAMkqgIbcuil4MvbxgTRCY5TsloYmi/iDlF4J2aJsclrQb5ADux1QnVl3rLS4WYVjqIRBr4qwWih2XbH0jptCCJ/MxYizSHdGPbaCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nIj/XXls; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nIj/XXls" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-720c286bcd6so4166124b3a.3; Mon, 25 Nov 2024 09:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732554096; x=1733158896; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=ekYN7BuLBRNCWsOyxovHCCedQMjj6G1OUvM/BMuCtf0=; b=nIj/XXlsFk7XZS5hfcy1zIOLzkCUHWhAyGY3zpNdZ/Sw9NNL8kfg+vU74aNKJKLqlp zp21WtUe4TnyugfYta64avwZSHvd/cJiMPkVtuqeuxIFYFgKhC8S2y5/BoUPm54GenEN YUHKu18ymY0iFczrxErHY7zD32F93gkD8NDR6K3TsPaxk6IQ+BsN/GI/USIwacmFT5cz PAt66MzhpGKtl1XgQ9TDGnosUebGnUqfRkGO9F+cwBcZD8rM7T88uPe1rhVwGSuV/4AH aSy36397ujdZHGpJOneo1WvncXu2VIsAWlRQTFpnQ9YCIoWLCoV7fpjpMPkWXTeaZbLN 3MHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732554096; x=1733158896; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ekYN7BuLBRNCWsOyxovHCCedQMjj6G1OUvM/BMuCtf0=; b=cZ5FN2GLJQUxPAflJ57XYLQC2m32kFOmNTrTCNwtPnzleTw72LTt1uW1nkG+j4X6+Y Ox7K0ahMWtXupsIvIPNeyyYL8o1Aiu/V6fjTzxx5E7n4NrCMCKD5Ptw8rzlmI/9qn9Mu 9vYMrYw7SDOBnlRrlaodJkkbj8GYrnCRyCncbkAAbaZ7z/8XIcklMYjnor8vVSg1pJMa f4nJCmBAY2GSRRflTwLutcZN+w4oil8XElQCbg8BBns0Ygf/WjY1YidSJBwinBaxPFFx OBhLNesgtprDPQsKnJyDzdmP+g8FoVR8/8f4WZ7r/uAZVvyfq8j41PrtIK87eBfDwyDJ fg8A== X-Forwarded-Encrypted: i=1; AJvYcCV9gnExEBSyvcTEVN9Sr/x8cNJ4+IY5iAM9Actcpl9OSAsq3/bOQAAZxX8K9Pp/tAsXnnCC6tg5OFCX@vger.kernel.org X-Gm-Message-State: AOJu0YzT7fRk5F+5Ze39HBdSPqigBehzS2ZiJq6kjIhBTsodXbxhmWnj dWWMWt1zSdd1yctIgjFQy1Yz/dHtrboBBa9Q/Ir/iQPSPlR//Dyb X-Gm-Gg: ASbGncuKhomLD7hVRsnO6JVjSkZNw+bfOBUs/sI6/C//PlTmG6wasT1xiH1Nw60Qg4t TSaC2T4qVmRJFgWA1PXU2gh4G4aUDKPJdqwZiOV4arAq/pUll+/YhkaXWXYzkxS4aCSVSsOYrs1 vu5G85wWk9DK4OAon1CjiNvc2xYGR/bb3bOVbkbn12AJVnfXdAUBWg50uejz6ljVOai3R2oHLND 9Bahk4n36BL/au9X9Wihcxfo+D09VN9EoX+IdpswcFVwEQszdXhvBMbovlLM09t4LYW0918h7U2 FRXeYIlJ5CX0aKj1RDrnB/U= X-Google-Smtp-Source: AGHT+IEvOvRaJG4YyMlRJY2wTnhOnr8SyigLQV2JQc0LMSb0+tjH7oovxshkOkqxA/o+4u62B2CAmA== X-Received: by 2002:a17:902:ec8e:b0:211:a6d:85e8 with SMTP id d9443c01a7336-2129f81f20emr173099805ad.39.1732554096069; Mon, 25 Nov 2024 09:01:36 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dc2aad7sm67298285ad.279.2024.11.25.09.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Nov 2024 09:01:35 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Mon, 25 Nov 2024 09:01:33 -0800 Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sparc/pci: Make pci_poke_lock a raw_spinlock_t. To: Sebastian Andrzej Siewior , sparclinux@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Boqun Feng , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , "David S. Miller" , Andreas Larsson References: <20241009161041.1018375-1-bigeasy@linutronix.de> <20241009161041.1018375-2-bigeasy@linutronix.de> <7656395b-58fc-4874-a9f3-6d934e2ef7ee@roeck-us.net> <20241125085314.1iSDFulg@linutronix.de> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20241125085314.1iSDFulg@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/25/24 00:53, Sebastian Andrzej Siewior wrote: > The pci_poke_lock is used underneath of the pci_lock. The pci_lock is a > low level lock used by the core code in sections with disabled > insterrupts. Therefore the pci_poke_lock must be a raw_spinlock_t. > > Make pci_poke_lock a raw_spinlock_t. > > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/7656395b-58fc-4874-a9f3-6d934e2ef7ee@roeck-us.net > Fixes: 560af5dc839ee ("lockdep: Enable PROVE_RAW_LOCK_NESTING with PROVE_LOCKING.") > Signed-off-by: Sebastian Andrzej Siewior > --- > On 2024-11-23 08:27:08 [-0800], Guenter Roeck wrote: >> >> Is this a problem with the test or with the platform ? > > platform. The patch below should fix it. It makes no difference unless > used on PREEMPT_RT. Since sparc does not support it I made the fixes > where the default option changed. > > Could you test it, please? I don't have a even a compiler for sparc > right now. > Unfortunately it doesn't make a difference. [ 1.050499] ============================= [ 1.050801] [ BUG: Invalid wait context ] [ 1.051200] 6.12.0+ #1 Not tainted [ 1.051571] ----------------------------- [ 1.051875] swapper/0/1 is trying to lock: [ 1.052201] 0000000001b694c8 (pci_poke_lock){....}-{3:3}, at: pci_config_read16+0x8/0x80 [ 1.052994] other info that might help us debug this: [ 1.053331] context-{5:5} [ 1.053641] 2 locks held by swapper/0/1: [ 1.053959] #0: fffff800042b50f8 (&dev->mutex){....}-{4:4}, at: __driver_attach+0x80/0x160 [ 1.054388] #1: 0000000001d29078 (pci_lock){....}-{2:2}, at: pci_bus_read_config_word+0x18/0x80 [ 1.054793] stack backtrace: [ 1.055171] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0+ #1 [ 1.055632] Call Trace: [ 1.055985] [<00000000004e31d0>] __lock_acquire+0xa50/0x3160 [ 1.056329] [<00000000004e63e8>] lock_acquire+0xe8/0x340 [ 1.056645] [<00000000010f0dfc>] _raw_spin_lock_irqsave+0x3c/0x80 [ 1.056966] [<0000000000443828>] pci_config_read16+0x8/0x80 [ 1.057278] [<000000000044442c>] sun4u_read_pci_cfg+0x12c/0x1a0 [ 1.057593] [<0000000000b7657c>] pci_bus_read_config_word+0x3c/0x80 [ 1.057913] [<0000000000b7fa78>] pci_find_capability+0x18/0xa0 [ 1.058228] [<0000000000b794b0>] set_pcie_port_type+0x10/0x160 [ 1.058543] [<0000000000442a98>] pci_of_scan_bus+0x158/0xb00 [ 1.058854] [<00000000010c74a0>] pci_scan_one_pbm+0xd0/0xf8 [ 1.059167] [<0000000000446174>] sabre_probe+0x1f4/0x5c0 [ 1.059476] [<0000000000c13a48>] platform_probe+0x28/0x80 [ 1.059785] [<0000000000c11158>] really_probe+0xb8/0x340 [ 1.060098] [<0000000000c11584>] driver_probe_device+0x24/0xe0 [ 1.060413] [<0000000000c117ac>] __driver_attach+0x8c/0x160 [ 1.060728] [<0000000000c0ef54>] bus_for_each_dev+0x54/0xc0 The original call trace also included _raw_spin_lock_irqsave(), and I don't have CONFIG_PREEMPT_RT enabled in my sparc64 builds to start with. FWIW, I don't understand the value of pr_warn("context-{%d:%d}\n", curr_inner, curr_inner); Why print curr_inner twice ? Thanks, Guenter