All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	linux-nfs@vger.kernel.org, kinglongmee@gmail.com
Subject: Re: [PATCH 1/3] NFSD: pass an integer for stable type to nfsd_vfs_write
Date: Sat, 31 Dec 2016 17:16:43 +0800	[thread overview]
Message-ID: <b7d23232-393c-325f-2fe0-a9dd5bda9cfc@gmail.com> (raw)
In-Reply-To: <20161223092554.GA17715@infradead.org>

On 12/23/2016 17:25, Christoph Hellwig wrote:
> On Fri, Dec 23, 2016 at 05:18:03PM +0800, Kinglong Mee wrote:
>> We can check it in check_export() when exporting filesystem,
>> but, what can we do for the unsupported fsync filesystem?
>> Just a warning message? or deny the exporting? 
>> I'd prefer the first one.
> 
> Warn and refuse the writable export.
> 

I'd like warn and covert the export to read-only straightly.

For example, 
A test directory may be mounted many underlay filesystem (contain
 ISO9660, f2fs, etc) frequently. If refuse the writeable export, 
for ISO9660 the exports entry must be *(ro,...), but for f2fs
may be *(rw,...). I don't think someone wants change it every time.

thanks,
Kinglong Mee

      reply	other threads:[~2016-12-31  9:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  1:32 [PATCH 1/3] NFSD: pass an integer for stable type to nfsd_vfs_write Kinglong Mee
2016-12-23  7:19 ` Christoph Hellwig
2016-12-23  9:18   ` Kinglong Mee
2016-12-23  9:25     ` Christoph Hellwig
2016-12-31  9:16       ` Kinglong Mee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7d23232-393c-325f-2fe0-a9dd5bda9cfc@gmail.com \
    --to=kinglongmee@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.