From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] intel/gtt: unmap pages after rewriting GTT table. Date: Tue, 11 Jan 2011 13:28:52 +0000 Message-ID: References: <1294708636-18201-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 85A9B9E709 for ; Tue, 11 Jan 2011 05:28:55 -0800 (PST) In-Reply-To: <1294708636-18201-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Jan 2011 11:17:16 +1000, Dave Airlie wrote: > This fixes a regression caused by the GTT rework that > 450f2b3d51025a1749b694ee13f0e4e23ed58750 is part off. > > On my ILK laptop with DMAR enabled I was seeing the occasional > DMAR warning. > > The ordering in the previous code was to rewrite the GTT table > before unampping the pages and that makes sense to me. Dave you mentioned on IRC that this is not sufficient to quieten DMAR, right? The unbind+unmap looks safer than unmap+unbind, so that seems to be a good patch regardless. -Chris -- Chris Wilson, Intel Open Source Technology Centre