From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/1] Use cachable mapping for i915 opregion. Date: Sun, 23 Jan 2011 17:41:03 +0000 Message-ID: References: <1295803414-5373-1-git-send-email-kernel@mkarcher.dialup.fu-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id CCF259E740 for ; Sun, 23 Jan 2011 09:41:28 -0800 (PST) In-Reply-To: <1295803414-5373-1-git-send-email-kernel@mkarcher.dialup.fu-berlin.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Michael Karcher , airlied@linux.ie, "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, 23 Jan 2011 18:23:34 +0100, Michael Karcher wrote: > The opregion is a shared memory region between ACPI and the graphics > driver. As the ACPI mapping has been changed to cachable in commit > 6d5bbf00d251cc73223a71422d69e069dc2e0b8d, mapping the intel opregion > non-cachable now fails. As no bus-master hardware is involved in the > opregion, cachable map should do no harm. Presumably these instances in the driver also need to be acpi_os_ioremap()? -Chris -- Chris Wilson, Intel Open Source Technology Centre