From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: Intel i915 freeze on latest git Date: Tue, 01 Feb 2011 16:57:37 +0000 Message-ID: References: <20110201112200.GA2349@fujiko> <1bdc18$jeuv05@fmsmga002.fm.intel.com> <20110201122943.GA2011@fujiko> <20110201140754.GA2229@fujiko> <20110201083112.3cfefc3a@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B2DD9E8CF for ; Tue, 1 Feb 2011 08:57:41 -0800 (PST) In-Reply-To: <20110201083112.3cfefc3a@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , Francesco Allertsen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, 1 Feb 2011 08:31:12 -0800, Jesse Barnes wrote: > The bisect is interesting, I'd have expected a failure when we > re-enabled rc6 on ILK or when we fixed up the ring buffer init. Yes, that was my instinct as well. Though that patch does do have one subtlety: ironlake_enable_rc6(): + I915_WRITE(RSTDBYCTL, I915_READ(RSTDBYCTL) & ~RCX_SW_EXIT); So it appears the patch may in fact be enabling render standby, when it was actually dropped in commit 88271da3f3da75d6eaef5e768c82a1627edf7088 Author: Jesse Barnes Date: Wed Jan 5 12:01:24 2011 -0800 drm/i915: re-enable rc6 support for Ironlake+ intel_enable_clock_gating(): - I915_WRITE(MCHBAR_RENDER_STANDBY, - I915_READ(MCHBAR_RENDER_STANDBY) & ~RCX_SW_EXIT); So, if this is the issue, then simply commenting out the tweaking of RSTDBYCTL in ironlake_enable_rc6() should prevent the hang. -Chris -- Chris Wilson, Intel Open Source Technology Centre