From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 04/16] drm/i915: add Ivy Bridge PCI IDs and flags Date: Wed, 27 Apr 2011 22:28:45 +0100 Message-ID: References: <1303861134-8762-1-git-send-email-jbarnes@virtuousgeek.org> <1303861134-8762-5-git-send-email-jbarnes@virtuousgeek.org> <849307$cme8bu@azsmga001.ch.intel.com> <20110427140150.797fc29a@jbarnes-vaio.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D871D9E78F for ; Wed, 27 Apr 2011 14:28:48 -0700 (PDT) In-Reply-To: <20110427140150.797fc29a@jbarnes-vaio.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 27 Apr 2011 14:01:50 -0700, Jesse Barnes wrote: > On Wed, 27 Apr 2011 07:59:17 +0100 > Chris Wilson wrote: > > So I think we just want IS_GEN7() for IVB code. > > I'd rather keep them separate since we know we'll have gen7 chips with > different display engines in the future. I've been trying to use > IS_GEN for render related checks, IS_IVB for specific display checks, > and HAS_PCH for the ilk+ split (though for the most part that should go > away with proper function call backs). If there is method to the madness, fine. I like the explanation and so perhaps we should include that in the code somewhere. And we just need to make sure we are consistent in our usage. -Chris -- Chris Wilson, Intel Open Source Technology Centre