All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Brent Lu <brent.lu@intel.com>, alsa-devel@alsa-project.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
	sound-open-firmware@alsa-project.orgDRIVERS,
	"commit_signer:6/16=38%, authored:6/16=38%,
	added_lines:123/248=50%, removed_lines:36/84=43%,
	Kai    Vehmanen DRIVERS \)" <kai.vehmanen@linux.intel.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	Keyon Jie <yang.jie@linux.intel.com>, "authored:2/16=12%,
	added_lines:21/248=8%, removed_lines:5/84=6%, \),
	Liam    Girdwood DRIVERS \)" <lgirdwood@gmail.com>,
	Pierre-Louis Bossart DRIVERS
	<pierre-louis.bossart@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, 15/16=94@,
	"Daniel Baluta  DRIVERS \)" <daniel.baluta@nxp.com>,
	Zhu Yingjiang <yingjiang.zhu@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response
Date: Thu, 11 Jun 2020 07:26:54 -0700	[thread overview]
Message-ID: <b7e0b822a9deea506acaa40e0e31cc9f488bb446.camel@linux.intel.com> (raw)
In-Reply-To: <1591883073-17190-1-git-send-email-brent.lu@intel.com>

On Thu, 2020-06-11 at 21:44 +0800, Brent Lu wrote:
> The loop implementation could not solve the unsolicited response
> issue because the RIRBSTS is cleared after leaving the
> snd_hdac_bus_update_rirb() function. So the next loop will fail the
> status test against the RIRB_INT_MASK and skip all the RIRB handling
> stuff. On the other hand, there alwasy could be unsolicited responses
> in the last loop regardless the number of loops.
> 
> Clear the RIRB interrupt before handling it so unsolicited response
> could trigger another RIRB interrupt to handle it later.
Hi Brent,

Thanks for the patch. Is this fix for a specific issue you're seeing?
If so, could you please give us some details about it?

Thanks,
Ranjani


  reply	other threads:[~2020-06-11 14:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 13:44 [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response Brent Lu
2020-06-11 14:26 ` Ranjani Sridharan [this message]
2020-06-11 17:09   ` Lu, Brent
2020-06-11 17:09     ` Lu, Brent
2020-06-11 17:59     ` Takashi Iwai
2020-06-11 17:59       ` Takashi Iwai
2020-06-11 18:12       ` Ranjani Sridharan
2020-06-11 18:12         ` Ranjani Sridharan
2020-06-11 20:14         ` Takashi Iwai
2020-06-11 20:14           ` Takashi Iwai
2020-06-11 20:36           ` Pierre-Louis Bossart
2020-06-11 20:36             ` Pierre-Louis Bossart
2020-06-11 23:33             ` Lu, Brent
2020-06-11 23:33               ` Lu, Brent
2020-06-12  6:15       ` Lu, Brent
2020-06-12  6:15         ` Lu, Brent
2020-06-11 18:01     ` Pierre-Louis Bossart
2020-06-11 18:01       ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7e0b822a9deea506acaa40e0e31cc9f488bb446.camel@linux.intel.com \
    --to=ranjani.sridharan@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=daniel.baluta@nxp.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.orgDRIVERS \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    --cc=yingjiang.zhu@linux.intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.