From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ADAB28D82F for ; Wed, 16 Jul 2025 12:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752670754; cv=none; b=pGpZN3x5S6HKNnw1oDPIssT4h3FkoEVYfJCY4Q5TVD9t3N6En512GH6lpYWtnpJyS4JjQdD7s8RbFuILkbk9LiRxElpfxbJPElGYo/0+dCnArewl7iN/Z3Np/syCI5xhR6mfwjZDd5CnEl5zFgSrN1bYrw4lMvk0t4vW46bkbhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752670754; c=relaxed/simple; bh=YND42Vrml9Hy0dYuPFdNuU8Q4WUUBZUvslcQGXTRE3k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B9fY6mJTIOr7dlhZ/CuIAWvYX0YmdErpOKzIm5t8Bl3A0yPsEJEBH64L5SoMsUNA4pHhmfIThdAUzCy4qfYlAqCMbqa/eL2Z9c6BqOMZMlb4OX1DV2Z/1GylT3+c/sQe3wPpDO0vAexNJJRa5gB8DIrWp4lnoOgyIgJ3RNMNTeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LSt6BYXf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LSt6BYXf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752670752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rnCDE0anbzdnU2S3G+A8RzoEp80pmvgzbc0xHwRbxZQ=; b=LSt6BYXf/Fd2ijDFrrgfS/3G192pTg4Pe1448hS6AC0JcBX2HXyGSAEvVK4xbOS3TgZ/Kv Tdwy7j7jEDixSLDnW5Xh224G+WuHSctv8YGR1uDHf5D43zw/4uVLtYQwODlEmctY9dcq3w RRqy52/cc94Un4iEjiuvJ5gyh/y8F3w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-z5IVZu4QMq640-rqSsgHFg-1; Wed, 16 Jul 2025 08:59:11 -0400 X-MC-Unique: z5IVZu4QMq640-rqSsgHFg-1 X-Mimecast-MFC-AGG-ID: z5IVZu4QMq640-rqSsgHFg_1752670750 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so4359645f8f.1 for ; Wed, 16 Jul 2025 05:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752670750; x=1753275550; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rnCDE0anbzdnU2S3G+A8RzoEp80pmvgzbc0xHwRbxZQ=; b=pBFRRGgpnaSQzn4G7THozP5+0WoGFmPmxubc/H6/9Anpmqa/yIIcx63Qx6y4Ej1WBy ejkI83pdPNAnyhW6tBa1Mnyea3idfiHILcUqR8fzfVur06wWbVj5Wh5ZbmgrcTwtGv6o nxLcjZjhmklTaqih7HeMKvs3ULmgpX3v/r5v/KUU9PyazNfzt8nOurKRB9SMnwNpdzpQ puVLGPrmI1nJSr2XMWNTTBnCxhDqPilEEv16UutxZsiJwCLurdRLv6+NfRVsAtFrJiVy D3iYVvfZh4IfPxsgMAHWYJnlgCh59EozyfKqBEHMUudPk7is9aTkM739GpEVjd1r2vTw qUEQ== X-Gm-Message-State: AOJu0YzSFc5275XKHu4ETzxxR7xlgoXiFZaN35eDRZwX+KcKLPoO2/Er 8Lud+5Ox7HNQZEy8Ks0lEpnP8EUOWPmHcoy11002y8O8rjNltuCIxBd7+99UOIVvjPzk6PymCon woucrQ0Fx6b1NBwObXDHdZu5aW2P9JoE9BNaJEZKQHaZuzC8iPbAoPw== X-Gm-Gg: ASbGncv0i85VqkQ4Eq+HVjZllGwP+zzADZXSD5BRpZtbHkKCX2l6xFFbrsD0ixuIsVR Y/KGxpXFRK2WMpCuPD2/eXq2TGErm7JyGeb4AzpTLjtvs4+WN+xAf8dpaKiqQHaOZVCg14KIYLC N6cCXvCtuQBUD1iA4p4L9shTGcD83O/qzi4kFl6MFiQoHW/IW8zDAvGN+XuRrz0RYK7M2Xa7LNZ CE2Fi+n0KET8/6wU3Du3r1REkQiqKnH7TXPrI8oCDBkMT3RQudHOC/vlB13m+lXfYerP2W1GEIJ myVd5Byl/8Bi8XJinz4q+rNtqJPbXHzU0arvGkflJUnr5gTZirjfeq7gzPqn9lxsIHFWbF21mFR q6WuVGTRrc7t1VGLnQshP1mhK9QIbawhy0Mt9GwMzNWZZllSyFe203rHvTaL1qRYZEDE= X-Received: by 2002:a05:6000:5c6:b0:3b4:6577:eed5 with SMTP id ffacd0b85a97d-3b60e4b832bmr2075981f8f.12.1752670749525; Wed, 16 Jul 2025 05:59:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2OumeF8pXJTw7hPAH637uxvFFCphsEHA97i1WmtyqjORn/g2E3/6ECNcvlxeyQKntUVeaPg== X-Received: by 2002:a05:6000:5c6:b0:3b4:6577:eed5 with SMTP id ffacd0b85a97d-3b60e4b832bmr2075898f8f.12.1752670749026; Wed, 16 Jul 2025 05:59:09 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc9298sm17777986f8f.44.2025.07.16.05.59.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 05:59:08 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 14:59:05 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: Fuad Tabba , Xiaoyao Li Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> <778ca011-1b2f-4818-80c6-ac597809ec77@redhat.com> <6927a67b-cd2e-45f1-8e6b-019df7a7417e@intel.com> <47395660-79ad-4d22-87b0-c5bf891f708c@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.07.25 14:54, Fuad Tabba wrote: > Hi Xiaoyao, > > >> Not really the same result. >> >> The two-step patches I proposed doesn't produce the below thing of this >> original patch. It doesn't make sense to select >> KVM_GENERIC_GMEM_POPULATE for KVM_SW_PROTECTED_VM from the name. > > I think I see where you're going. That said, other than in the > configuration files, in all the actual code, the purpose of > KVM_GENERIC_PRIVATE_MEMis to guard kvm_gmem_populate(). So > I disagree with you, and I think that this should be one patch that > fixes the name. That said, I agree with you regarding: > > - select KVM_GENERIC_PRIVATE_MEM if KVM_SW_PROTECTED_VM > + select KVM_GENERIC_MEMORY_ATTRIBUTES if KVM_SW_PROTECTED_VM > + select KVM_GMEM if KVM_SW_PROTECTED_VM Yeah, KVM_SW_PROTECTED_VM doesn't need the populate function. -- Cheers, David / dhildenb