From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E16934D135 for ; Wed, 13 Mar 2024 20:12:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710360781; cv=none; b=BEuiPwsryNQNQwdmks2VjiYjcjIYp4KBvOqxVdpX+Q6cAqmP3XrWX/tJfIqk9yO2FVDF/weYLzmvnPvIVct1mqwzTzNT/q5CWljtwSewZ3VLv/fZeDUZjf28ohc5fxwP+XyuK1zXDL1AaaYU/Uqv2d9cFQ2ORrbiCbsCnTBl2Jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710360781; c=relaxed/simple; bh=xEydpAbl+UnNX21HEQRz8uun/LLyMM3kGBycf29Y6jk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l+ifM4XD823FAHhGS1B7r1kMx0qOxGqiRSQNbZpGOOJgpGDW0TL5K7ldqwnIuzaMIsiFDGxH6PWIVjGxiPmPPxPDF+om8OfJyJ8VjhSktENV36CGJJkMFDb/zEcyklLTWS2KaGEz6ajq0Ri4KLzhmr4JvknecWN+q1gK0BMSyVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TqzOT7XQ; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TqzOT7XQ" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6e519d73850so132791a34.2 for ; Wed, 13 Mar 2024 13:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710360779; x=1710965579; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mcoUVHgwLLkW5HjqhzTOaCJXpQUFZkJrmtPUv2eDI9M=; b=TqzOT7XQp0xwXIpdr8kuJtSoxwnTd8AthR7aSuT8qYXnqyvqBnFMhcMf5XySnavTw0 Zw5+eb2y6i7xx3pBhck1kxE/AjUd1h6A6AQtC4rlCc+GmnMTM6o93oSe/Xn6E7waW6p8 ImLdeeVVEGF7kOAj1XSLqRSSx76rY9G7DhBg9/yezXFpItxRuCtSV89PddmJLFDP6hJR pS9gzd7Zb9CfBNZ2m57yNHM4ud2Li6l0B9j0jH+/2/C+KbBjDyEVcCgksmc/y/D0od4o rZr66Ha5Kov962VvPIT13bTguHbcu51qsBzg5l3jpApB/IBH8jLzJy1o12olIeRitzRP KSHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710360779; x=1710965579; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mcoUVHgwLLkW5HjqhzTOaCJXpQUFZkJrmtPUv2eDI9M=; b=S2SoKWjSYHpoP9LCZdL56vEZHLb5NuXCAOS0xabqKvKkMSssGhxEDIB8bH/pvkni2e BIbPnQRQ/5dWHklEwyPD9dWOPJDwLJxT+PKuaRWFLYsGIC5HVdZW9AV3WlpSyR2+o4oS gTs5GrGwSab9fyYx+Z8CM0qWpmdjmCnjCLQa9e/0dRa9K5xQFaMBXmqJYZ6ekSGJNCCS 3LxJqxOoswDB5zFln5nwewiXj9QqHY125ukTmUujx8amlHCTBFBHLdXE8RJSABMPieE5 MQw82KWD2vuBqiaj3Fgtl9XC/gQYhZrJurFv3A/Mf82JXxvl0NGZAm3KbygnRE5wQ4fB WzUw== X-Forwarded-Encrypted: i=1; AJvYcCWTHcF/YBqH4Vf30HKi1IKP+7gmhALZe0SOcX9eQlXp6R0ip4UCrlNzdpteIeZ6ssAhieXl6GACxdW0ro23zQQdaKDz X-Gm-Message-State: AOJu0YwWNwcPGyrHOBt+mNS6JFJ9vwkqFur8rVc03p4X0tgdeguM2Nh0 /iegLtFyI9gBSDqAhP9ce2Ik/Vkc3/AbIMyLGmJC9nF+g03HAfR/ X-Google-Smtp-Source: AGHT+IFSK8EKQA4YLa1BW2O3gR/c6PoFXPU5Py2EL9IBEyYIERWPhz76GtYioIywO8cwI62nqsu0ow== X-Received: by 2002:a05:6870:f14e:b0:221:8fd9:284c with SMTP id l14-20020a056870f14e00b002218fd9284cmr4587256oac.1.1710360778906; Wed, 13 Mar 2024 13:12:58 -0700 (PDT) Received: from [10.102.4.159] ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id x2-20020a0ce0c2000000b00690d36c64d2sm3341355qvk.53.2024.03.13.13.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 13:12:58 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 13:12:54 -0700 Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support Content-Language: en-US To: Eric Biggers Cc: Johannes Berg , Karel Balej , dimitri.ledkov@canonical.com, alexandre.torgue@foss.st.com, davem@davemloft.net, dhowells@redhat.com, herbert@gondor.apana.org.au, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcgrof@kernel.org, mcoquelin.stm32@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, iwd@lists.linux.dev References: <005f998ec59e27633b1b99fdf929e40ccfd401c1.camel@sipsolutions.net> <20240313194423.GA1111@sol.localdomain> From: James Prestwood In-Reply-To: <20240313194423.GA1111@sol.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: > On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: >> Hi, >> >> On 3/13/24 1:56 AM, Johannes Berg wrote: >>> Not sure why you're CC'ing the world, but I guess adding a few more >>> doesn't hurt ... >>> >>> On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: >>>> and I use iwd >>> This is your problem, the wireless stack in the kernel doesn't use any >>> kernel crypto code for 802.1X. >> Yes, the wireless stack has zero bearing on the issue. I think that's what >> you meant by "problem". >> >> IWD has used the kernel crypto API forever which was abruptly broken, that >> is the problem. >> >> The original commit says it was to remove support for sha1 signed kernel >> modules, but it did more than that and broke the keyctl API. >> > Which specific API is iwd using that is relevant here? > I cloned https://kernel.googlesource.com/pub/scm/network/wireless/iwd > and grepped for keyctl and AF_ALG, but there are no matches. IWD uses ELL for its crypto, which uses the AF_ALG API: https://git.kernel.org/pub/scm/libs/ell/ell.git/ I believe the failure is when calling: KEYCTL_PKEY_QUERY enc="x962" hash="sha1" From logs Michael posted on the IWD list, the ELL API that fails is: l_key_get_info (ell.git/ell/key.c:416) Thanks, James > > - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84A0EC54791 for ; Wed, 13 Mar 2024 20:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tjUe2Z/BmYQF6b1OvWgHU/roinEzuvv8ahruWBvARFw=; b=y+qx4MWJo5srmk JIdCt/EB69WpS6G6Ho/bLkybBoiglDdM8SIn9Ri1FQu6Xg61sj0FAIwmTe/V8kQbo8KTLcMHe8jqP rgI8o93gv98xTQDIcmPnTzC6rrYDJcs5wb3+Px3moC9NUNW7gSRod9GZT7pmx19XxAjOtlNYjOZQH 3CmAP1CXm2MoO0C8m1h5CyYH9t0i5yFBj5HoSnji6unwICWq4kFsEhyG+WTvUh6e8809x+eE36qOZ U+sKfJNZIzPBDzsj4A/807ONNyrGcbsk82eyqA33OV6KD6+ymhB5TddZvHZeoXJt13Al2I+7x6SRi EUmlxWxTk0lD+bdswB0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkUyG-0000000Bmr3-1YD8; Wed, 13 Mar 2024 20:13:04 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkUyD-0000000Bmp3-1pJm for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 20:13:02 +0000 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6e50e8dcc72so105946a34.3 for ; Wed, 13 Mar 2024 13:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710360779; x=1710965579; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mcoUVHgwLLkW5HjqhzTOaCJXpQUFZkJrmtPUv2eDI9M=; b=bs8G/g8zeGj/vMI2mbUuNmd750GbISml5o9s7nRxWzKmRoYfbLKHSIyKwZ2m9HwoEJ aa4Rgbp0KquTvAEWDyejmwtt/mhTSC5+2YM+vuRSygkrzYRP9A4ctUHP/bAs8D/aXsrd EtysprMxWdgEWxwGKmrr3JiGBix0QKQQ8M56XEcJE6qWG4iEPL6QTf5xq15kVBdYPI6J KyipeuBpT0CvAj8kgXXvw8epjaDlY2yq+hSyb8Z/qthxI+w9cnfj1ZjzmFwoD0B3aajd zF5DNkMeImi59wK3SjbPIisVoZuQrZlSK3r9+/cOYqh/x/8y4fpBVhmpmRb2lLHH0vok EUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710360779; x=1710965579; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mcoUVHgwLLkW5HjqhzTOaCJXpQUFZkJrmtPUv2eDI9M=; b=W0qfBNq6OYYpVeE4leysu/SZeGPtyqoD3Dm/vYI75tNenbRuj1OROm5axUmFqKXyeE 3jbo+f3Hak90gIiV6n0Hf9c8Qf3HKJHA2i+lp0DexaWicXoNjxI4cRDPuVFNlLClpkNI fgIx4tNQ5gV8JmIIeasi7Dzp49EGpQeKMJ9BALkq2ErdmrPi0ArASFe67HdgCGJQTF3I 0npg984xMecUzpG5zw/pwL8iMcNn1Cke7KpCu6wCy3QYWJE9YBfgKPaoZa6e5X91ZI4W TOh8E2hNwrwY+7mX1WloNVi2k8eamskd0/w21VZk1dg/9BInBOqFnvC/PouiDp/6D6TB xWfQ== X-Forwarded-Encrypted: i=1; AJvYcCWIT5KKZa/s6cqSRTO+ca8rbdBDgB3gk4iAq18nh2LjD6YdjQxd8aydf2xhStJcvEWKAdQtELbhBJRh+gJj9FUn9UIq2H+HWTONgRNIEVIQRDXC6QY= X-Gm-Message-State: AOJu0YwxGWOX9Y/kr7vgKamibblAUrig0hsWbabbhbiEQJKlv7w4zVUt yI0P5cabE6FgzgtnRSX8MkB7goQpqdywcE8I4Vlm5Hut8681uQZO X-Google-Smtp-Source: AGHT+IFSK8EKQA4YLa1BW2O3gR/c6PoFXPU5Py2EL9IBEyYIERWPhz76GtYioIywO8cwI62nqsu0ow== X-Received: by 2002:a05:6870:f14e:b0:221:8fd9:284c with SMTP id l14-20020a056870f14e00b002218fd9284cmr4587256oac.1.1710360778906; Wed, 13 Mar 2024 13:12:58 -0700 (PDT) Received: from [10.102.4.159] ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id x2-20020a0ce0c2000000b00690d36c64d2sm3341355qvk.53.2024.03.13.13.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 13:12:58 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 13:12:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support Content-Language: en-US To: Eric Biggers Cc: Johannes Berg , Karel Balej , dimitri.ledkov@canonical.com, alexandre.torgue@foss.st.com, davem@davemloft.net, dhowells@redhat.com, herbert@gondor.apana.org.au, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcgrof@kernel.org, mcoquelin.stm32@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, iwd@lists.linux.dev References: <005f998ec59e27633b1b99fdf929e40ccfd401c1.camel@sipsolutions.net> <20240313194423.GA1111@sol.localdomain> From: James Prestwood In-Reply-To: <20240313194423.GA1111@sol.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_131301_519555_97D8214C X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: > On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: >> Hi, >> >> On 3/13/24 1:56 AM, Johannes Berg wrote: >>> Not sure why you're CC'ing the world, but I guess adding a few more >>> doesn't hurt ... >>> >>> On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: >>>> and I use iwd >>> This is your problem, the wireless stack in the kernel doesn't use any >>> kernel crypto code for 802.1X. >> Yes, the wireless stack has zero bearing on the issue. I think that's what >> you meant by "problem". >> >> IWD has used the kernel crypto API forever which was abruptly broken, that >> is the problem. >> >> The original commit says it was to remove support for sha1 signed kernel >> modules, but it did more than that and broke the keyctl API. >> > Which specific API is iwd using that is relevant here? > I cloned https://kernel.googlesource.com/pub/scm/network/wireless/iwd > and grepped for keyctl and AF_ALG, but there are no matches. IWD uses ELL for its crypto, which uses the AF_ALG API: https://git.kernel.org/pub/scm/libs/ell/ell.git/ I believe the failure is when calling: KEYCTL_PKEY_QUERY enc="x962" hash="sha1" From logs Michael posted on the IWD list, the ELL API that fails is: l_key_get_info (ell.git/ell/key.c:416) Thanks, James > > - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel