From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lakshmi Ramasubramanian Date: Thu, 31 Oct 2019 15:08:48 +0000 Subject: Re: [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="maccentraleurope" Content-Transfer-Encoding: base64 List-Id: References: <20191031011910.2574-1-nramas@linux.microsoft.com> <20191031011910.2574-2-nramas@linux.microsoft.com> <1572523831.5028.43.camel@linux.ibm.com> In-Reply-To: <1572523831.5028.43.camel@linux.ibm.com> To: Mimi Zohar , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Cc: prsriva@linux.microsoft.com T24gMTAvMzEvMTkgNToxMCBBTSwgTWltaSBab2hhciB3cm90ZToKCj4gT24gV2VkLCAyMDE5LTEw LTMwIGF0IDE4OjE5IC0wNzAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlhbiB3cm90ZToKPj4gQXN5 bW1ldHJpYyBrZXlzIHVzZWQgZm9yIHZlcmlmeWluZyBmaWxlIHNpZ25hdHVyZXMgb3IgY2VydGlm aWNhdGVzCj4+IGFyZSBjdXJyZW50bHkgbm90IGluY2x1ZGVkIGluIHRoZSBJTUEgbWVhc3VyZW1l bnQgbGlzdC4KPj4KPj4gVGhpcyBwYXRjaCBkZWZpbmVzIGEgbmV3IElNQSBob29rIG5hbWVseSBp bWFfcG9zdF9rZXlfY3JlYXRlX29yX3VwZGF0ZSgpCj4+IHRvIG1lYXN1cmUgYXN5bW1ldHJpYyBr ZXlzLgo+IAo+IEl0J3Mgbm90IGVub3VnaCBmb3IgdGhlIGtlcm5lbCB0byBiZSBhYmxlIHRvIGNv bXBpbGUgdGhlIGtlcm5lbCBhZnRlcgo+IGFwcGx5aW5nIGFsbCB0aGUgcGF0Y2hlcyBpbiBhIHBh dGNoIHNldC4gwqBBZnRlciBhcHBseWluZyBlYWNoIHBhdGNoLAo+IHRoZSBrZXJuZWwgc2hvdWxk IGJ1aWxkIHByb3Blcmx5LCBvdGhlcndpc2UgaXQgaXMgbm90IGJpLXNlY3Qgc2FmZS4KPiAgwqBS ZWZlciB0byAiMykgU2VwYXJhdGUgeW91ciBjaGFuZ2VzIiBvZgo+ICJEb2N1bWVudGF0aW9uL3By b2Nlc3Mvc3VibWl0dGluZy1wYXRjaGVzLnJzdC4KCkkgc3RhcnRlZCB3aXRoIGtlcm5lbCB2ZXJz aW9uIDUuMyBmb3IgdGhpcyBwYXRjaCBzZXQuCkkgYXBwbGllZCBOYXluYSdzIHByb2Nlc3NfYnVm ZmVyX21lYXN1cmVtZW50KCkgcGF0Y2ggYW5kIHRoZW4gYnVpbHQgbXkgCmNoYW5nZXMgb24gdG9w IG9mIHRoYXQuClRoaXMgcGF0Y2ggaGFzIG5vIG90aGVyIGRlcGVuZGVuY3kgYXMgZmFyIGFzIEkg a25vdy4KCkFyZSB5b3Ugc2VlaW5nIGEgYnVpbGQgYnJlYWsgYWZ0ZXIgYXBwbHlpbmcgdGhpcyBw YXRjaCBhbG9uZT8KCihQQVRDSCB2MyAxLzkpIEtFWVM6IERlZmluZWQgYW4gSU1BIGhvb2sgdG8g bWVhc3VyZSBrZXlzIG9uIGtleSBjcmVhdGUgCm9yIHVwZGF0ZQo+IAo+IFRoaXMgcGF0Y2ggc2hv dWxkIGFsc28gZGVmaW5lIHRoZSBuZXcgImZ1bmMiLgo+IAoKT2sgLSBJJ2xsIG1ha2UgdGhhdCBj aGFuZ2UuCgp0aGFua3MsCiAgLWxha3NobWk= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5032FCA9ECB for ; Thu, 31 Oct 2019 15:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 262822087F for ; Thu, 31 Oct 2019 15:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="sLIJtvbX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbfJaPIx (ORCPT ); Thu, 31 Oct 2019 11:08:53 -0400 Received: from linux.microsoft.com ([13.77.154.182]:43196 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbfJaPIx (ORCPT ); Thu, 31 Oct 2019 11:08:53 -0400 Received: from [10.137.112.108] (unknown [131.107.174.108]) by linux.microsoft.com (Postfix) with ESMTPSA id 45D1420B7192; Thu, 31 Oct 2019 08:08:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 45D1420B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1572534532; bh=b552znnqsYND51xMigIZXtf6qqgljQrlCIE5HH5S2i4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=sLIJtvbXJ37ifCWsEv5uQlJL6ydCzZ9r2nzBqntNvkOn9VL478bTvghdzjppI4LuT UbPE4B0JlPjWQ9wbW2NU/QsZjG0jVfrgvrb1FByefyTItfAZ2W9Ysyoz66iP0xgKDE cTysNaCkTLXtdQrV8mMQrn74ShsmcxWzjk39quP0= Subject: Re: [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update To: Mimi Zohar , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Cc: prsriva@linux.microsoft.com References: <20191031011910.2574-1-nramas@linux.microsoft.com> <20191031011910.2574-2-nramas@linux.microsoft.com> <1572523831.5028.43.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: Date: Thu, 31 Oct 2019 08:08:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1572523831.5028.43.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 10/31/19 5:10 AM, Mimi Zohar wrote: > On Wed, 2019-10-30 at 18:19 -0700, Lakshmi Ramasubramanian wrote: >> Asymmetric keys used for verifying file signatures or certificates >> are currently not included in the IMA measurement list. >> >> This patch defines a new IMA hook namely ima_post_key_create_or_update() >> to measure asymmetric keys. > > It's not enough for the kernel to be able to compile the kernel after > applying all the patches in a patch set.  After applying each patch, > the kernel should build properly, otherwise it is not bi-sect safe. >  Refer to "3) Separate your changes" of > "Documentation/process/submitting-patches.rst. I started with kernel version 5.3 for this patch set. I applied Nayna's process_buffer_measurement() patch and then built my changes on top of that. This patch has no other dependency as far as I know. Are you seeing a build break after applying this patch alone? (PATCH v3 1/9) KEYS: Defined an IMA hook to measure keys on key create or update > > This patch should also define the new "func". > Ok - I'll make that change. thanks, -lakshmi