From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E30617A2F6 for ; Thu, 18 Jun 2026 04:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781758514; cv=none; b=Xc+cI/c0FSzeowNc7n8NIiKigy++L4ZTV/n94uvUb8DRrQSb73A0DTxFlLlN053XwPNHrL+5mkMerWJtOsMrJo5JMg8sDi3VeezHcsYbMc7h9w2hRgUEH79/e5Elh9qpOoCTMOKYGZOoe720rY6TX4BVlMA4+ns/xt7sIA+aEVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781758514; c=relaxed/simple; bh=JtzUGkWzVGuqxlhYmBwF3u58v8D4G7FJiogmMwSP7AU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rv0G+VlU0aoWetS+ynrBj9F3f1ghRmwzzae9PsNs6hMNSwi4WtHlJ8xETzV/Bn+HA8CuMVCSr1kCpWeIyNVONk/AiYK9Vx9NIdlOQBcG+GrhovP+DkqYeAPplsyFSSO0oSO6PIBnLKlZDSG981Z8xcSvdKOTyoiPmIx2HIFAX6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=gweY9sMJ; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="gweY9sMJ" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65HHmEpc1106598; Thu, 18 Jun 2026 04:55:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=yQE187 49MRtja1lfzJ89eq/Z7UNJ4PwFMUJsbIBu77A=; b=gweY9sMJyC7Zrv8kCwY1dh z+qZlRCfDGiYwrvHUHuBBngJv+BRcruurKHC/kfJdEU2meHAVEwaTcKgnEF4kfCP dLkJm7AFvrhJL0NRKo5Dm/rG9UaZ1YyeQtIS1kZY5Xj901/xCETatq+7nqFxzk+g FtKddc/HOi2p8F+au4ZwJRHf5Ek+Oa8Z0yqISTAwX4Nyo25K0xk+9MbRYMfzW8l/ U88cgz+W+7nYgRNL9SRAQz6Dj+rkSR49woXuzU1zPiuseejUVLKp8F3I1/FnbuCP I2stlN4fqdRkN6akmlocjxZhL/+Io8Wzid5JuDhq1b5sxWZtf3YYuomtdvcMyutA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4eueqtpc6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jun 2026 04:55:01 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65I4nfHJ003842; Thu, 18 Jun 2026 04:55:00 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ev17220rd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jun 2026 04:55:00 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65I4suHb44368262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Jun 2026 04:54:57 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1D2B20043; Thu, 18 Jun 2026 04:54:56 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E0F920040; Thu, 18 Jun 2026 04:54:56 +0000 (GMT) Received: from [9.224.89.241] (unknown [9.224.89.241]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 18 Jun 2026 04:54:56 +0000 (GMT) Message-ID: Date: Thu, 18 Jun 2026 06:54:56 +0200 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 02/17] target/s390x: Move cpacf sha512 code into a new file Content-Language: en-GB To: Harald Freudenberger , richard.henderson@linaro.org, iii@linux.ibm.com, david@kernel.org, thuth@redhat.com, berrange@redhat.com Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, linux390-list@tuxmaker.boeblingen.de.ibm.com, linux-s390@vger.kernel.org, dengler@linux.ibm.com, borntraeger@linux.ibm.com, cohuck@redhat.com References: <20260617094820.34402-1-freude@linux.ibm.com> <20260617094820.34402-3-freude@linux.ibm.com> From: Finn Callies In-Reply-To: <20260617094820.34402-3-freude@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: bjhiOaGrWzgty4ywE2GhovracoJClSH8 X-Proofpoint-GUID: bjhiOaGrWzgty4ywE2GhovracoJClSH8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA0MCBTYWx0ZWRfX1rkj5hx1TTQY rN1c/BXTmpCnpK5DDKvz9w1GgxH9OMD9xDuM4qOwo+APkURFANCzPqNWUzlFRHiF18OCa5qGjFw K1qsNfgITSOYkaTXE5FVvr98iObih1DHkzVWUwHRLwjotGT4vcKn/w9e8AeZd/sD7l+TOdBEUE3 VDRNoYLm+tK56i/1e1tQXmaDkPhpe3QReUuMbuD2eUEYhHxIHm+54KisB3RhZ6V+RAF/JHC5SiO 5aUIuBcV506yXE3NJzT8QUxkB38szjTGlJZ05/2NdRDUUwB8JOUVpw0Iv4YVeoVC7dwSaMxzXHI l+ZD7D70J52QmJAlNtY77Hkf31IaMnzr0Q+viA0mFKeGjVHbcmi/wv9ohevygZ0GN8mv/MCFEnH FY/gfqCXTI4ZJhdSO0W4DJJQaxTQMAMj4Ud+TG1rOWr3BGU6IG3qLUxwfHofCMEh7lJSvXW75zU YxoB06TNxHlrYEMaWCw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA0MCBTYWx0ZWRfX/3hkw7dFCDeQ jAGc0ENdnHzOnhHKoOxpkxckKzjGo7k82CJV8wXMNaQ/AnGLBUemW0T2IpyaqgT0I0ysGydZKvX mqfbyyNP4S8K3FZqKGSK0GCuWnai+hU= X-Authority-Analysis: v=2.4 cv=B4KJFutM c=1 sm=1 tr=0 ts=6a337a25 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=AARKpvnCM0ca1r4D8OcA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_02,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1011 phishscore=0 spamscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180040 On 17.06.26 11:48, Harald Freudenberger wrote: > Move the cpacf sha512 implementation into a new file > cpacf_sha512.c. Add this new file to the build and add a > new header file cpacf.h containing the prototypes for the > s390 cpacf stuff. > > Signed-off-by: Harald Freudenberger > Tested-by: Holger Dengler With the one typo (see below) fixed: Reviewed-by: Finn Callies > --- > target/s390x/tcg/cpacf.h | 16 ++ > target/s390x/tcg/cpacf_sha512.c | 245 +++++++++++++++++++++++++++++++ > target/s390x/tcg/crypto_helper.c | 227 +--------------------------- > target/s390x/tcg/meson.build | 1 + > 4 files changed, 263 insertions(+), 226 deletions(-) > create mode 100644 target/s390x/tcg/cpacf.h > create mode 100644 target/s390x/tcg/cpacf_sha512.c > > diff --git a/target/s390x/tcg/cpacf.h b/target/s390x/tcg/cpacf.h > new file mode 100644 > index 0000000000..d27839ddd9 > --- /dev/null > +++ b/target/s390x/tcg/cpacf.h > @@ -0,0 +1,16 @@ > +/* > + * s390x cpacf > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +#ifndef S390X_CPACF_H > +#define S390X_CPACF_H > + > +/* from crypto_sha512.c */ It should be cpacf_sha512.c in the comment instead of crypto_sha512.c > +int cpacf_sha512(CPUS390XState *env, const int mmu_idx, uintptr_t ra, > + uint64_t param_addr, uint64_t *message_reg, uint64_t *len_reg, > + uint32_t type); > + [ snip ]