Re: [PATCH 05/15] drm/i915: Pass crtc_state and connector_state to encoder functions

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 05/15] drm/i915: Pass crtc_state and connector_state to encoder functions
Date: Mon, 22 Aug 2016 10:06:22 +0200	[thread overview]
Message-ID: <b848cc1f-44bf-efa3-0514-b60fdb100b1f@linux.intel.com> (raw)
In-Reply-To: <20160818133016.GG6232@phenom.ffwll.local>

Op 18-08-16 om 15:30 schreef Daniel Vetter:
> On Tue, Aug 09, 2016 at 05:04:04PM +0200, Maarten Lankhorst wrote:
>> This is mostly code churn, with exception of a few places:
>> - intel_display.c has changes in intel_sanitize_encoder
>> - intel_ddi.c has intel_ddi_fdi_disable calling intel_ddi_post_disable,
>>   and required a function change. Also affects intel_display.c
>> - intel_dp_mst.c passes a NULL crtc_state and conn_state to
>>   intel_ddi_post_disable for shutting down the real encoder.
> I didn't find this NULL callsite. Outdated commit message?
intel_dp_mst.c:

+		intel_dig_port->base.post_disable(&intel_dig_port->base,
+						  old_crtc_state, NULL);

Though it seems I accidentally pass old_crtc_state, that one should be NULL too.

R-B with that fixed?

And did you review 4/15? I don't see it in my inbox.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx