All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	"Lukas Wunner" <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	Nicolai Stange
	<nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops
Date: Tue, 23 May 2017 09:32:38 +0200	[thread overview]
Message-ID: <b84f80fd-0cd1-86cf-4e81-cb4547ea6fff@amd.com> (raw)
In-Reply-To: <b6d95951-d28d-f709-adcd-1068aeaa0e0f-otUistvHUpPR7s880joybQ@public.gmane.org>

Am 23.05.2017 um 05:55 schrieb Michel Dänzer:
> On 23/05/17 12:50 PM, Lukas Wunner wrote:
>> On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote:
>>> On 22/05/17 11:04 PM, Lukas Wunner wrote:
>>>> On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote:
>>>>> On Thu, May 18 2017, Lukas Wunner wrote:
>>>> [snip]
>>>>>> Reported-by: Nicolai Stange <nicstange@gmail.com>
>>>>>> Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo")
>>>>>> Signed-off-by: Lukas Wunner <lukas@wunner.de>
>>>>>> ---
>>>>>>
>>>>>> Awaiting a Tested-by: from Nicolai, but it's clear this is a bug and
>>>>>> needs to be fixed, so sending out with a proper commit message now.
>>>>>> The bug was only introduced to radeon, not amdgpu.
>>>>> Tested-by: Nicolai Stange <nicstange@gmail.com>
>>>>>
>>>>> Thanks for the quick fix!
>>>>>
>>>>>> @Alex Deucher: I could push this to drm-misc-fixes but then it wouldn't
>>>>>> land before -rc3 because Sean Paul has already sent out the -rc2 pull.
>>>>>> I notice you haven't sent out a pull for -rc2 yet, so maybe you want to
>>>>>> take it yourself?  Whichever you prefer.  Thanks & sorry for the breakage!
>>>> I've learned this morning that Alex is on vacation.
>>> Christian König is standing in for Alex.
>> By his own account, he already has "all hands full replacing him [Alex]",
>> explicitly asked Daniel to merge an amdgpu patch through drm-misc-next for
>> this reason and lacks permission to update branches in Alex' repo on fdo:
>>
>> "One lesson learned from the past week is that Alex needs to stop using
>> his personal repository on fdo.
>> We were asked a couple of times if I couldn't update a branch there from
>> different directions, which we obviously can't do."
>>
>> https://lists.freedesktop.org/archives/dri-devel/2017-May/142376.html
>> https://lists.freedesktop.org/archives/dri-devel/2017-May/142380.html
> The important point being that Christian reviewed that patch and
> explicitly asked Daniel to pick it up.

Wow, wait a second. I'm just catching up on this thread.

Lukas didn't committed the patch to drm-misc without a review, didn't you?

I was intentionally holding back a rb because that isn't my field of 
expertise and I was only briefly involved in the original patch. Alex 
should be back by the end of the week, so no need for a rush like that.

Daniels patch was a global cleanup of include path done by search and 
replace a complete different story.

Regards,
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-05-23  7:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 21:08 [REGRESSION] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo Nicolai Stange
     [not found] ` <87h90jkx88.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-18  8:05   ` Lukas Wunner
     [not found]     ` <20170518080501.GA31002-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-18 19:33       ` [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops Lukas Wunner
2017-05-21  7:31         ` Nicolai Stange
2017-05-22 14:04           ` Lukas Wunner
2017-05-22 19:35             ` Sean Paul
2017-05-23  9:40               ` Lukas Wunner
     [not found]             ` <20170522140407.GA7973-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-23  3:09               ` Michel Dänzer
     [not found]                 ` <ee3f8e5b-8deb-b5a3-6d07-f43c27ebf84f-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-05-23  3:50                   ` Lukas Wunner
     [not found]                     ` <20170523035053.GB3610-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-23  3:55                       ` Michel Dänzer
     [not found]                         ` <b6d95951-d28d-f709-adcd-1068aeaa0e0f-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-05-23  7:32                           ` Christian König [this message]
     [not found]                             ` <b84f80fd-0cd1-86cf-4e81-cb4547ea6fff-5C7GfCeVMHo@public.gmane.org>
2017-05-23  7:36                               ` Daniel Vetter
2017-05-23  7:43                                 ` Christian König
2017-05-23  7:43                                 ` Daniel Vetter
2017-05-23 10:14                             ` Lukas Wunner
     [not found]                               ` <20170523101414.GC31451-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-23 10:32                                 ` Christian König
2017-05-23 18:47                       ` Deucher, Alexander
     [not found]                         ` <BN6PR12MB165207FE821EFFFBE14E1676F7F90-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-23 20:23                           ` Alex Deucher
2017-05-22 19:24         ` Daniel Vetter
     [not found]           ` <20170522192434.wotowwbpdl7zqki2-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-05-23 10:00             ` Lukas Wunner
2017-05-23 12:58               ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b84f80fd-0cd1-86cf-4e81-cb4547ea6fff@amd.com \
    --to=christian.koenig-5c7gfcevmho@public.gmane.org \
    --cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org \
    --cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
    --cc=nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.