From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7BA5C48BC3 for ; Wed, 14 Feb 2024 15:31:45 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.681011.1059525 (Exim 4.92) (envelope-from ) id 1raHEY-00016J-G0; Wed, 14 Feb 2024 15:31:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 681011.1059525; Wed, 14 Feb 2024 15:31:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1raHEY-00016C-C3; Wed, 14 Feb 2024 15:31:38 +0000 Received: by outflank-mailman (input) for mailman id 681011; Wed, 14 Feb 2024 15:31:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1raHEX-00015h-Eq for xen-devel@lists.xenproject.org; Wed, 14 Feb 2024 15:31:37 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2319b43a-cb4e-11ee-98f5-efadbce2ee36; Wed, 14 Feb 2024 16:31:35 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id AD8004EE0737; Wed, 14 Feb 2024 16:31:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2319b43a-cb4e-11ee-98f5-efadbce2ee36 MIME-Version: 1.0 Date: Wed, 14 Feb 2024 16:31:34 +0100 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, bertrand.marquis@arm.com, julien@xen.org, Simone Ballarin , Doug Goldstein , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH] automation/eclair_analysis: deviate certain macros for Rule 20.12 In-Reply-To: <3519db82-6126-4aa0-9d04-795edf6f2bca@suse.com> References: <892be5c403ca7a20b35fb9facacb6a38bc7f6bfe.1707900742.git.nicola.vetrini@bugseng.com> <3519db82-6126-4aa0-9d04-795edf6f2bca@suse.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-02-14 12:49, Jan Beulich wrote: > On 14.02.2024 12:26, Nicola Vetrini wrote: >> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >> @@ -387,6 +387,16 @@ in assignments." >> {safe, "left_right(^[(,\\[]$,^[),\\]]$)"} >> -doc_end >> >> +-doc_begin="The token pasting in variadic macros cannot be replaced." >> +-config=MC3R1.R20.12,macros+={deliberate, "variadic()"} >> +-doc_end >> + >> +-doc_begin="Uses of # and ## operators within the following macros >> are >> +deliberate." > > I don't think this is a good explanation. The use of those operators is > deliberate elsewhere as well. > Implicitly this was intended to be delimited to its applicability scope - violations of Rule 20.12. I detailed the reasons that were brought up to keep using these macros as is in the deviations.rst file. I'm open to further refinements, though. >> +-config=MC3R1.R20.12,macros+={deliberate, >> "name(ASSERT||BUILD_BUG_ON||BUILD_BUG_ON_ZERO||GENERATE_CASE)"} > > I said in another context already that it is necessary to separate > global scope macros from local helper ones. Any CU can introduce > another > GENERATE_CASE(), and would be deviated here right away. In fact I > question applicability of the deviation to arm/arm64/vsysreg.c; I only > see it as applicable to arm/vcpreg.c. > Why wouldn't this be applicable for vsysreg.c? I can certainly fine-tune the deviation, if needed -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)