From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4757853D9D5 for ; Tue, 29 Sep 2026 17:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790702809; cv=none; b=J+rmtxHOAp3AyAwoQSiDxuiUqQJRVmQdbAbwH6Sy2Rg5ndiF/Mq4vXl3o9Q2j3Ac0GC3Qkq5Cobvfb5Ee19xhyIcRvE/XAEXJzlyySBqE9bxnvEAy7by2DvVYRgeOyV0sAZEM/8dZP5WURTBVjPh5Ydek7Qa3L7oYmWnXC0zGws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790702809; c=relaxed/simple; bh=u9XPzUqW79rJKn6aQ5AIYZwHVFkebmqpU+ELj+QTgU0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l/B7w1RHfrraorQYScSt47Nlbp7amWrGp8bpiB1BJaNCdO6M6hTn5d1NItIQMShaE6/KgCpCodJ4CebiP8alttKF1a5X/1Y1r+ntmoA6MKJ1Tvod9S6KainpiHWvRz4qjWqfUNcvxuA0TQBVztocX/KM9TA7vXEj4uCLrcNq2XM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=OES8jYAj; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="OES8jYAj" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49e6598dd44so28684195e9.1 for ; Tue, 29 Sep 2026 10:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1790702805; x=1791307605; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=i0fkT9jvbr/kwSvFoz/Z+e93i45No9+Z9jUlZdZhhO8=; b=OES8jYAjl33dmcmB0l5bPzaVq7QZbp7bso3E9UX2DdFjMQsBnlqzh1o0CCG95nB9pU DwJe1zX91srqtoqebmvuQdvJ8H7mSpRck+ZuvVG/WBf+V9Vfbb1Lxg4UGjQED57blQM2 kNDWW5oZbAHHXN7ogBW7kOndJ1Ij03yunp+x1Hki6v/g05hqg+eifFr/uL3x074cMe/S CCOuTQvbMeVhg/blqKX/0mKFQOODb2dPI+Kagd6Br1t1E2kdf2WnVTKRVytUsFcOPTR+ jUgf7BpAh4oVM5a5oMvj8kjhDnGg8zJGeErVkKZqmN5sxbhECwzgDRMKreseOqu38Yi9 8DJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790702805; x=1791307605; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=i0fkT9jvbr/kwSvFoz/Z+e93i45No9+Z9jUlZdZhhO8=; b=bxnRsQJ+bPwtpgr11nX7kHgRrYPHsyGPO9JdFzDY3PRv74kq3DCEJP/C9Wf+2oUAeM /OsshFgNOemBTJ8wLzAO1xprEWZ7LhT3XCmq/hj4aklG+6d14ii9Zm9/LA/BJQUisUip cfUAGMrRE9NovkkyeDWKLzHZEI8DuxgN7Wd1O8wzVyW4oR6X29OwoKo1/ALYlnv52vEk 1T7kT6+WSbwhVF3w0mJEZlrKOLqQmTRHfqDsS2qR8+Ie73gF4csXXJjTdTsacZ3/AsJh JbFlHW88BhrAiQJd48C6/SlnI7JXw1NCbPs3LK6L21G2l0ZIGl2edE49C03za8GTQXIy MPMQ== X-Forwarded-Encrypted: i=1; AKwUvBxA5p7AjiIVUjKpWX+KKaX60raemLB7eRAfSGEM9f94d9+M/mDSXPrzqU6d6yLOAbwSVEQcR5HeDdto@lists.linux.dev X-Gm-Message-State: AFuF++mHHl6Wdp3HmAkQJZ/wJIYuXhh24Ls9Yzr31oDjeBKq9stbK5fB 6WOimy4yJcNC1hvOFOFrSU2Gv6iTjx3icv5XE8u8QT1aM3zEtofOSgA6No75cwQVnTk= X-Gm-Gg: AYBFou3862EA2sxXRXqTPpyrhGvDscWo0AS7GgkDT+QRHys7HBbR7udChauu+czmhsj bREVj0gHnwOAaJ9KY/0QIihpjQsyzR6U5cakF8222OI0l/4QRaLdEOcbZ7uiSyvCkOZOfUkCb4L ZIbwyAymXxrmEdthSkI8Bc+ibctYk6zgr/si0327fSgoQtvbL3Og/ZsRE24wAsf+ND0zgahTELH pxafbOJ0XL351femIJFTQZ9D0cJ2Nybr11gOyAoV/zXZHrn3b0M3UXGe8BmK/IO0IqqwPH0ghHP WhnSvFa17PEM6vfOi8oWFHp51gMwSFa9rFa9kJeqQzcYZ8oavjM4R4ZvhWMnYQ3ZTLD1/alWNC6 sZDq9F38uRitXh7pNWUBNcCJh5Tgz+FOjD0R/k5Wo4Q85st6bj2cQpxiifKD/kIsjET0zRft2vF 6Te1dnDS2dZSxnJ5Fky1RH6C7qAP7jilGsHwpgcJ5YPvbLOELb4yF5c2pswvk3sHxHdISD1XZI5 56mg8oJrzAwkEJSa7W7kok= X-Received: by 2002:a05:600c:1c2a:b0:4a0:c2a:485e with SMTP id 5b1f17b1804b1-4a00c2a48cdmr77569005e9.33.1790702805403; Tue, 29 Sep 2026 10:26:45 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [185.218.66.243]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01491d4dbsm1981735e9.3.2026.09.29.10.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2026 10:26:45 -0700 (PDT) Message-ID: Date: Tue, 29 Sep 2026 20:26:43 +0300 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] x86/virt/tdx: Detect if the extensions initialization is required To: Xu Yilun , x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kas@kernel.org, rick.p.edgecombe@intel.com, yilun.xu@intel.com, xiaoyao.li@intel.com, sohil.mehta@intel.com, adrian.hunter@intel.com, kishen.maloor@intel.com, tony.lindgren@linux.intel.com, peter.fang@intel.com, baolu.lu@linux.intel.com, zhenzhong.duan@intel.com, chao.gao@intel.com, artem.bityutskiy@linux.intel.com, kvm@vger.kernel.org References: <20260915102658.713079-1-yilun.xu@linux.intel.com> <20260915102658.713079-4-yilun.xu@linux.intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260915102658.713079-4-yilun.xu@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15.09.26 г. 13:26 ч., Xu Yilun wrote: > Some add-on features require TDX module extensions. The TDX module > provides a metadata field "ext_required" to indicate this requirement. > > Add the first step of TDX module extensions initialization by detecting > if the extensions are required: > > 1. Check if the extensions are supported via TDX_FEATURES0_EXT. If > not, ext_required is not readable. > 2. Check if any TDX feature needs the extensions via ext_required. > > Skip the extensions initialization when it is not required. > > Currently all metadata fields are read at the very beginning of TDX > module initialization. However, ext_required is only valid after the > add-on feature configuration, so it cannot use the existing metadata > reading method. > > Add a dedicated metadata reading interface for the extensions, call it > after add-on feature configuration. > > Signed-off-by: Xu Yilun > Reviewed-by: Tony Lindgren > --- > v1: > - Include struct tdx_sys_info_ext in struct tdx_sys_info. > --- > arch/x86/include/asm/tdx.h | 1 + > arch/x86/include/asm/tdx_global_metadata.h | 5 ++++ > arch/x86/virt/vmx/tdx/tdx.c | 28 +++++++++++++++++++++ > arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 14 +++++++++++ > 4 files changed, 48 insertions(+) > > diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h > index 89e97d5761d8..6657f2db0330 100644 > --- a/arch/x86/include/asm/tdx.h > +++ b/arch/x86/include/asm/tdx.h > @@ -36,6 +36,7 @@ > /* Bit definitions of TDX_FEATURES0 metadata field */ > #define TDX_FEATURES0_TD_PRESERVING BIT_ULL(1) > #define TDX_FEATURES0_NO_RBP_MOD BIT_ULL(18) > +#define TDX_FEATURES0_EXT BIT_ULL(39) > > #ifndef __ASSEMBLER__ > > diff --git a/arch/x86/include/asm/tdx_global_metadata.h b/arch/x86/include/asm/tdx_global_metadata.h > index 41150d546589..fe3fe91de71f 100644 > --- a/arch/x86/include/asm/tdx_global_metadata.h > +++ b/arch/x86/include/asm/tdx_global_metadata.h > @@ -44,12 +44,17 @@ struct tdx_sys_info_handoff { > u16 module_hv; > }; > > +struct tdx_sys_info_ext { > + bool ext_required; > +}; > + > struct tdx_sys_info { > struct tdx_sys_info_version version; > struct tdx_sys_info_features features; > struct tdx_sys_info_tdmr tdmr; > struct tdx_sys_info_td_ctrl td_ctrl; > struct tdx_sys_info_td_conf td_conf; > + struct tdx_sys_info_ext ext; > }; > > #endif > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index 763c2d1b25d0..916a8906da10 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -1181,6 +1181,30 @@ static __init int init_tdmrs(struct tdmr_info_list *tdmr_list) > return 0; > } > > +static __init int init_tdx_module_extensions(void) > +{ > + int ret; > + > + if (!(tdx_sysinfo.features.tdx_features0 & TDX_FEATURES0_EXT)) > + return 0; > + > + ret = get_tdx_sys_info_ext(&tdx_sysinfo.ext); > + if (ret) > + return ret; > + > + /* > + * ext_required indicates if any add-on features requiring TDX module > + * extensions are configured via TDH.SYS.CONFIG. If none, skip the > + * initialization. > + */ > + if (!tdx_sysinfo.ext.ext_required) > + return 0; I'm slightly confused by the parlance introduced here. TDX_FEATURES0_EXT indicates whether this tdx module supports extensions. And ext_required aka 0x3100000000000001 is, as per td_scope_metadata.json: "Extended Features Available Mask: indicates the extended user and system features which are available for the TD." So aren't by definition all add-on features extensions. How do you distinguish add-on which are extensions and those which aren't? I think it's best if ext_required is referred to as "ext_mask" or some such and not ext_required. That value is not about what is required but rather what is available, no ?