From: Dave Hansen <dave.hansen@linux.intel.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shaohua Li <shli@kernel.org>, Hugh Dickins <hughd@google.com>,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 7/7] swap, put_swap_page: Share more between huge/normal code path
Date: Wed, 18 Jul 2018 08:13:34 -0700 [thread overview]
Message-ID: <b8a9d250-81b2-0c0b-e1c6-57dbfa11be82@linux.intel.com> (raw)
In-Reply-To: <87k1ptgskf.fsf@yhuang-dev.intel.com>
On 07/17/2018 07:56 PM, Huang, Ying wrote:
> -.orc_unwind_ip 1380 0
> -.orc_unwind 2070 0
> -Total 26810
> +.orc_unwind_ip 1480 0
> +.orc_unwind 2220 0
> +Total 27172
>
> The total difference is same: 27172 - 26810 = 362 = 24577 - 24215.
>
> The text section difference is small: 17927 - 17815 = 112. The
> additional size change comes from unwinder information: (1480 + 2220) -
> (1380 + 2070) = 250. If the frame pointer unwinder is chosen, this cost
> nothing, but if the ORC unwinder is chosen, this is the real difference.
>
> For 112 text section difference, use 'objdump -t' to get symbol size and
> compare,
Cool, thanks for doing this!
I think what you've done here is great for readability and the binary
size increase is well worth the modest size increase.
next prev parent reply other threads:[~2018-07-18 15:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 0:55 [PATCH v2 0/7] swap: THP optimizing refactoring Huang, Ying
2018-07-17 0:55 ` [PATCH v2 1/7] swap: Add comments to lock_cluster_or_swap_info() Huang, Ying
2018-07-17 18:27 ` Dave Hansen
2018-07-18 3:09 ` Huang, Ying
2018-07-18 3:09 ` Huang, Ying
2018-07-17 0:55 ` [PATCH v2 2/7] mm/swapfile.c: Replace some #ifdef with IS_ENABLED() Huang, Ying
2018-07-17 18:32 ` Dave Hansen
2018-07-18 3:25 ` Huang, Ying
2018-07-18 3:25 ` Huang, Ying
2018-07-18 15:15 ` Dave Hansen
2018-07-19 4:42 ` Huang, Ying
2018-07-19 4:42 ` Huang, Ying
2018-07-17 0:55 ` [PATCH v2 3/7] swap: Use swap_count() in swap_page_trans_huge_swapped() Huang, Ying
2018-07-17 0:55 ` [PATCH v2 4/7] swap: Unify normal/huge code path " Huang, Ying
2018-07-17 0:55 ` [PATCH v2 5/7] swap: Unify normal/huge code path in put_swap_page() Huang, Ying
2018-07-17 0:55 ` [PATCH v2 6/7] swap: Add __swap_entry_free_locked() Huang, Ying
2018-07-17 0:55 ` [PATCH v2 7/7] swap, put_swap_page: Share more between huge/normal code path Huang, Ying
2018-07-17 18:36 ` Dave Hansen
2018-07-18 2:56 ` Huang, Ying
2018-07-18 2:56 ` Huang, Ying
2018-07-18 15:13 ` Dave Hansen [this message]
2018-07-17 15:17 ` [PATCH v2 0/7] swap: THP optimizing refactoring Daniel Jordan
2018-07-18 2:56 ` Huang, Ying
2018-07-18 2:56 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a9d250-81b2-0c0b-e1c6-57dbfa11be82@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.