From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lionel Landwerlin Subject: Re: [PATCH] drm/i915/oa: Reconfigure contexts on the fly Date: Fri, 5 Jul 2019 15:43:56 +0300 Message-ID: References: <20190705123057.19346-1-chris@chris-wilson.co.uk> <0ff02900-acdb-12a2-84d4-8df69e2e08cf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1385922290==" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DA576E4A1 for ; Fri, 5 Jul 2019 12:43:59 +0000 (UTC) In-Reply-To: <0ff02900-acdb-12a2-84d4-8df69e2e08cf@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1385922290== Content-Type: multipart/alternative; boundary="------------14FC9BBC310E86D54C6E38CB" Content-Language: en-US This is a multi-part message in MIME format. --------------14FC9BBC310E86D54C6E38CB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2019 15:42, Lionel Landwerlin wrote: >> >> + >> +static int >> +gen8_store_flex(struct i915_request *rq, >> +        struct intel_context *ce, >> +        const struct flex *flex, unsigned int count) >> +{ >> +    u32 offset; >> +    u32 *cs; >> + >> +    cs = intel_ring_begin(rq, 4 * count); >> +    if (IS_ERR(cs)) >> +        return PTR_ERR(cs); > > > Is the right of the kernel context large enough to hold the MI_SDIs > for all the contexts? > > s/right/ring/ --------------14FC9BBC310E86D54C6E38CB Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
On 05/07/2019 15:42, Lionel Landwerlin wrote:

+
+static int
+gen8_store_flex(struct i915_request *rq,
+        struct intel_context *ce,
+        const struct flex *flex, unsigned int count)
+{
+    u32 offset;
+    u32 *cs;
+
+    cs = intel_ring_begin(rq, 4 * count);
+    if (IS_ERR(cs))
+        return PTR_ERR(cs);


Is the right of the kernel context large enough to hold the MI_SDIs for all the contexts?



s/right/ring/


--------------14FC9BBC310E86D54C6E38CB-- --===============1385922290== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1385922290==--