From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH 08/10] pem: Support encrypted keys in l_pem_load_private_key
Date: Fri, 11 Aug 2017 19:49:27 -0500 [thread overview]
Message-ID: <b8dc69ac-0d8d-93ab-03b4-e3781f526e65@gmail.com> (raw)
In-Reply-To: <CAOq732Jz8w13BnW024LyWt0cWZqrjHm89PhyvSnniQ8Z-SmU6Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
Hi Andrew,
>
> I have iwd code to actually enable encrypted EAP-TLS or EAP-TTLS
> private keys. But it could use a "l_pem_is_encrypted" too, only the
> files would be loaded more times.
>
Ah I see, because you're asking the agent for the passphrase.
Go with the current proposal, but do me a favor and put in a doc block
above that function and explain that 'encrypted' doesn't follow our
typical out-argument semantics. E.g. it is actually touched even if the
function fails.
Regards,
-Denis
next prev parent reply other threads:[~2017-08-12 0:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 23:10 [PATCH 01/10] checksum: Add SHA224 checksum type Andrew Zaborowski
2017-08-10 23:10 ` [PATCH 02/10] cipher: Add DES-CBC cipher type Andrew Zaborowski
2017-08-11 16:08 ` Denis Kenzior
2017-08-10 23:10 ` [PATCH 03/10] tls: Move DER / ASN.1 related definitions to asn1-private.h Andrew Zaborowski
2017-08-11 16:17 ` Denis Kenzior
2017-08-12 0:08 ` Andrew Zaborowski
2017-08-10 23:10 ` [PATCH 04/10] tls: Report error if private key loading fails Andrew Zaborowski
2017-08-11 16:18 ` Denis Kenzior
2017-08-10 23:10 ` [PATCH 05/10] asn1: Use const pointers in ASN1 parsing utilities Andrew Zaborowski
2017-08-10 23:10 ` [PATCH 06/10][RFC] cipher: Implement PKCS#5 key derivation functions Andrew Zaborowski
2017-08-11 16:28 ` Denis Kenzior
2017-08-12 0:12 ` Andrew Zaborowski
2017-08-10 23:10 ` [PATCH 07/10] cipher: Add l_cipher_from_pkcs5_id Andrew Zaborowski
2017-08-11 16:55 ` Denis Kenzior
2017-08-12 0:17 ` Andrew Zaborowski
2017-08-12 0:30 ` Denis Kenzior
2017-08-12 0:40 ` Andrew Zaborowski
2017-08-12 0:42 ` Denis Kenzior
2017-08-10 23:10 ` [PATCH 08/10] pem: Support encrypted keys in l_pem_load_private_key Andrew Zaborowski
2017-08-11 20:23 ` Denis Kenzior
2017-08-12 0:30 ` Andrew Zaborowski
2017-08-12 0:40 ` Denis Kenzior
2017-08-12 0:45 ` Andrew Zaborowski
2017-08-12 0:49 ` Denis Kenzior [this message]
2017-08-10 23:10 ` [PATCH 09/10] unit: Update for l_pem_load_private_key() parameter change Andrew Zaborowski
2017-08-10 23:10 ` [PATCH 10/10] unit: Test loading encrypted private key PEM files Andrew Zaborowski
2017-08-11 20:26 ` Denis Kenzior
2017-08-11 16:07 ` [PATCH 01/10] checksum: Add SHA224 checksum type Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8dc69ac-0d8d-93ab-03b4-e3781f526e65@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.