From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26E70C3DA6E for ; Wed, 10 Jan 2024 08:54:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 540FE878D5; Wed, 10 Jan 2024 09:54:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="aIoLV4B1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 781C38790F; Wed, 10 Jan 2024 09:54:46 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 345C587732 for ; Wed, 10 Jan 2024 09:54:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4F737615ED; Wed, 10 Jan 2024 08:54:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C716C433C7; Wed, 10 Jan 2024 08:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704876882; bh=0W4Hp4rdM1990wc25sf8PBkZX0LMeTfvapPS3IcNnDY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aIoLV4B1p40OsV5zNIcTRyoXXrzvITnB6kyKbH3yFCLLtCZXHVJ13WK1DUAQiWcgQ p6RpAA0aXbzP1aDfpAi/RVvSGob8s8DyD6zkcBqQg1Ltv5GPgqVBPFbq04zOip93gq OXhIGEfGK8TmC1OxvnAkDX5Am1XF4s+7viHE9lhCGVX228PEd0QaSPHJNb2qkITDJe e7gWZnA5nt1xCTl92K6Z5qwqwNcK66l5SoL9PjzgJ+c0TRpklMu5SPCgl10RMHpuXb iWwmyUwQXGkXAgO6W+9/VVXAtejrATcDSpQuDtyfTEr5deoTt/lSTniLqQP7r7sjXT OqCRr4+IVpLxg== Message-ID: Date: Wed, 10 Jan 2024 10:54:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 12/16] arm: dts: k3-am65x-binman: Add ICSSG2 overlay and configuration Content-Language: en-US To: MD Danish Anwar , Maxime Ripard , Siddharth Vadapalli , Nishanth Menon , Vignesh Raghavendra , Matthias Schiffer , Kamlesh Gurudasani , Manorit Chawdhry , Neha Malcom Francis , Andrew Davis , Ramon Fried , Joe Hershberger , Simon Glass , Tom Rini Cc: u-boot@lists.denx.de, srk@ti.com, r-gunasekaran@ti.com References: <20231219103418.3445886-1-danishanwar@ti.com> <20231219103418.3445886-13-danishanwar@ti.com> <1745ec33-7446-41fc-886a-704eb6e53c7e@kernel.org> <427c0741-5daf-4370-9cf6-5c70d8d6f673@ti.com> From: Roger Quadros In-Reply-To: <427c0741-5daf-4370-9cf6-5c70d8d6f673@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10/01/2024 08:50, MD Danish Anwar wrote: > Hi Roger, > > On 27/12/23 3:49 pm, MD Danish Anwar wrote: >> On 20/12/23 4:10 pm, Roger Quadros wrote: >>> >>> >>> On 19/12/2023 12:34, MD Danish Anwar wrote: >>>> Add ICSSG2 overlay and configuration to tispl and u-boot images. >>>> >>>> Signed-off-by: MD Danish Anwar >>>> --- >>>> arch/arm/dts/k3-am65x-binman.dtsi | 85 +++++++++++++++++++++++++++++++ >>>> 1 file changed, 85 insertions(+) >>>> >>>> diff --git a/arch/arm/dts/k3-am65x-binman.dtsi b/arch/arm/dts/k3-am65x-binman.dtsi >>>> index 8cc24da1f3..9a0c0fca47 100644 >>>> --- a/arch/arm/dts/k3-am65x-binman.dtsi >>>> +++ b/arch/arm/dts/k3-am65x-binman.dtsi >>>> @@ -98,6 +98,8 @@ >>>> #define SPL_AM654_EVM_DTB "spl/dts/k3-am654-base-board.dtb" >>>> #define AM654_EVM_DTB "u-boot.dtb" >>>> >>>> +#define AM654_EVM_ICSSG2_DTBO "arch/arm/dts/k3-am654-icssg2.dtbo" >>>> + >>>> &binman { >>>> ti-spl { >>>> insert-template = <&ti_spl_template>; >>>> @@ -124,6 +126,20 @@ >>>> filename = SPL_AM654_EVM_DTB; >>>> }; >>>> }; >>>> + >>>> + fdt-1 { >>>> + description = "k3-am654-icssg2 overlay"; >>>> + type = "flat_dt"; >>>> + arch = "arm"; >>>> + compression = "none"; >>>> + ti-secure { >>>> + content = <&spl_am65x_evm_icssg2_dtb>; >>>> + keyfile = "custMpk.pem"; >>>> + }; >>>> + spl_am65x_evm_icssg2_dtb: blob-ext { >>>> + filename = AM654_EVM_ICSSG2_DTBO; >>>> + }; >>> >>> This is wrong. >>> >>> ICSSG2 Ethernet should be part of the fdt-0 configuration as the 2 Ethernet ports >>> on the board are hardwired to ICSSG2. Not having them working by default >>> is an invalid configuration. >>> >> >> ICSSG2 ethernet ports should be enabled by default. But the ICSSG2 nodes >> is added in the overlay file (k3-am654-icssg2.dtso) in kernel so they >> are added in same overlay file in u-boot as well. >> >> I am keeping, >> fdt-0 as k3-am654-base-board dtb, >> fdt-1 as k3-am654-icssg2 dtbo, >> conf-0 as k3-am654-base-board and >> conf-1 as k3-am654-icssg2. >> >> Do you want me to keep k3-am654-icssg2 dtbo as fdt-0 and >> k3-am654-base-board as fdt-1? I tried doing this but this results into >> u-boot getting stuck. The tispl and u-boot images are not able to load >> if I swap fdt-0 and fdt-1 , and conf-0 and conf-1. >> >> If the current combination doesn't look OK, please let me know what >> should be the correct combinations for fdt-0, fdt-1, conf-0 and conf-1. >> > > Can you please comment on this. I'll send v2 with all the suggested > changes once you confirm the correct fdt and configurations. > Sorry, I missed this. fdt-0 = k3-am654-base-board dtb fdt-1 = k3-am654-icssg2 dtbo conf-0 = fdt-0 and ftd-1 as icssg2 ethernet is present on the base board, and should be part of the base board configuration. -- cheers, -roger