All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Mengyuan Lou <mengyuanlou@net-swift.com>, netdev@vger.kernel.org
Cc: michal.swiatkowski@linux.intel.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, andrew+netdev@lunn.ch,
	duanqiangwen@net-swift.com, linglingzhang@trustnetic.com,
	jiawenwu@trustnetic.com
Subject: Re: [PATCH net-next v3 03/12] net: libwx: add wangxun vf common api
Date: Wed, 9 Jul 2025 14:51:52 +0100	[thread overview]
Message-ID: <b8efdcd7-bc06-4c91-910f-3337be7408de@linux.dev> (raw)
In-Reply-To: <20250704094923.652-4-mengyuanlou@net-swift.com>

On 04/07/2025 10:49, Mengyuan Lou wrote:
> Add common wx_configure_vf and wx_set_mac_vf for
> ngbevf and txgbevf.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
> ---
>   drivers/net/ethernet/wangxun/libwx/Makefile   |   2 +-
>   drivers/net/ethernet/wangxun/libwx/wx_hw.c    |   3 +-
>   drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   1 +
>   drivers/net/ethernet/wangxun/libwx/wx_type.h  |   4 +
>   drivers/net/ethernet/wangxun/libwx/wx_vf.h    |  50 ++++
>   .../net/ethernet/wangxun/libwx/wx_vf_common.c | 196 ++++++++++++
>   .../net/ethernet/wangxun/libwx/wx_vf_common.h |  14 +
>   .../net/ethernet/wangxun/libwx/wx_vf_lib.c    | 280 ++++++++++++++++++
>   .../net/ethernet/wangxun/libwx/wx_vf_lib.h    |  14 +
>   9 files changed, 562 insertions(+), 2 deletions(-)
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_common.c
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_common.h
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_lib.h
> 

[...]

> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_vf.h b/drivers/net/ethernet/wangxun/libwx/wx_vf.h
> index c523ef3e8502..e863a74c291d 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_vf.h
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_vf.h
> @@ -14,6 +14,7 @@
>   #define WX_VXMRQC                0x78
>   #define WX_VXICR                 0x100
>   #define WX_VXIMS                 0x108
> +#define WX_VXIMC                 0x10C
>   #define WX_VF_IRQ_CLEAR_MASK     7
>   #define WX_VF_MAX_TX_QUEUES      4
>   #define WX_VF_MAX_RX_QUEUES      4
> @@ -22,6 +23,12 @@
>   #define WX_VXRXDCTL_ENABLE       BIT(0)
>   #define WX_VXTXDCTL_FLUSH        BIT(26)
>   
> +#define WX_VXITR(i)              (0x200 + (4 * (i))) /* i=[0,1] */
> +#define WX_VXITR_MASK            GENMASK(8, 0)
> +#define WX_VXITR_CNT_WDIS        BIT(31)
> +#define WX_VXIVAR_MISC           0x260
> +#define WX_VXIVAR(i)             (0x240 + (4 * (i))) /* i=[0,3] */
> +
>   #define WX_VXRXDCTL_RSCMAX(f)    FIELD_PREP(GENMASK(24, 23), f)
>   #define WX_VXRXDCTL_BUFLEN(f)    FIELD_PREP(GENMASK(6, 1), f)
>   #define WX_VXRXDCTL_BUFSZ(f)     FIELD_PREP(GENMASK(11, 8), f)
> @@ -44,6 +51,49 @@
>   #define WX_RX_HDR_SIZE           256
>   #define WX_RX_BUF_SIZE           2048
>   
> +#define WX_RXBUFFER_2048         (2048)

extra parentheses are not needed

> +#define WX_RXBUFFER_3072         3072
> +
> +/* Receive Path */
> +#define WX_VXRDBAL(r)            (0x1000 + (0x40 * (r)))
> +#define WX_VXRDBAH(r)            (0x1004 + (0x40 * (r)))
> +#define WX_VXRDT(r)              (0x1008 + (0x40 * (r)))
> +#define WX_VXRDH(r)              (0x100C + (0x40 * (r)))

[...]


  reply	other threads:[~2025-07-09 13:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04  9:49 [PATCH net-next v3 00/12] Add vf drivers for wangxun virtual functions Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 01/12] net: libwx: add mailbox api for wangxun vf drivers Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 02/12] net: libwx: add base vf api for " Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 03/12] net: libwx: add wangxun vf common api Mengyuan Lou
2025-07-09 13:51   ` Vadim Fedorenko [this message]
2025-07-04  9:49 ` [PATCH net-next v3 04/12] net: wangxun: add txgbevf build Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 05/12] net: txgbevf: add sw init pci info and reset hardware Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 06/12] net: txgbevf: init interrupts and request irqs Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 07/12] net: txgbevf: Support Rx and Tx process path Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 08/12] net: txgbevf: add link update flow Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 09/12] net: wangxun: add ngbevf build Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 10/12] net: ngbevf: add sw init pci info and reset hardware Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 11/12] net: ngbevf: init interrupts and request irqs Mengyuan Lou
2025-07-04  9:49 ` [PATCH net-next v3 12/12] net: ngbevf: add link update flow Mengyuan Lou
2025-07-10  1:50 ` [PATCH net-next v3 00/12] Add vf drivers for wangxun virtual functions patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8efdcd7-bc06-4c91-910f-3337be7408de@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=andrew+netdev@lunn.ch \
    --cc=duanqiangwen@net-swift.com \
    --cc=horms@kernel.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=kuba@kernel.org \
    --cc=linglingzhang@trustnetic.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.