From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7991380FEA; Thu, 6 Aug 2026 06:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785998950; cv=none; b=hfstfdPot7Ufncg37m2iNVF5P6kWRHJIKx9naC3q4/8gYGZfyFlDL9jQHFenaV9Hfu+8/WOrhHIbslJYwYWizSLdCGrqgCDe+JzApYDeDZk4qEG5EHqQgv7oXEzFviEH9HGpSAg1SIxamq6NZpoAsvFWDDAK2aIQq4z5Mc6sYZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785998950; c=relaxed/simple; bh=liepSuCWhET3A51hBZr4UfpyD/X0Yqjo0PxB4LUBEwo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NHKmPfLE0R/jd72e+B1E8DEZQPzBhqyLaulyrLkiVNcqNIGml3f+jFxZC4eYQQg22cVKMIirA5W7lOVHkv9oyZGFW6onuT4GZu4x9mh+Ed06VGgkgyY/lofnVHgkNp6g9tF4i4WVviY0ADmnGRV5ivCOxxHnP3yySboHxgdIux8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fUjhy0vL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fUjhy0vL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7202B1F000E9; Thu, 6 Aug 2026 06:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785998948; bh=3aNbsAERipFsx+yzQGv3WCU2Y9Zc5fWn7EPOiXhK8f8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=fUjhy0vLKfClXxk6YvO7DPT0idsViF/fGh4Q8xpBEsMQnDrYmDR+FPbrSlP8klYpi CspRJKPJ0NcfRS4q20LNYzEjh2chLl6jfqUnU4f8aN0/lQV1EJG8YpqvQzqTfSmD71 2SRYTMjbFvmfdoRa7VjCqWLPGkWbPW8RwEC8zjxHzu5adB0cCv29A14MBKLcVGA+in eqWSuRlIhCWXWL6US0yrikt+i0Dbh3Ji7PIjPqAhmcYHLIklA9l+a7U9YC0OOeOMIr JqJcJ2Z2RCx7QNRjJqrZ8b+y+7tzu+wuSyPgHnYgyqXhgkvq0+lCY13c1DVrNzEQTJ TZTbeNDC6Ma1g== Message-ID: Date: Thu, 6 Aug 2026 08:48:53 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/10] dt-bindings: net: pcs: add rockchip,rk3568-xpcs binding To: Coia Prant Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Vinod Koul , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Romain Gantois , Heiner Kallweit , Neil Armstrong , Russell King , Shawn Lin , David Heidelberg , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org References: <20260801142244.679437-2-coiaprant@gmail.com> <20260801142244.679437-6-coiaprant@gmail.com> <20260805-stirring-wondrous-mule-faf37d@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/08/2026 19:20, Coia Prant wrote: > Hi Krzysztof, > > Thanks for the detailed review. Here's my response to each point: > >>> +title: Rockchip RK3568 Synopsys DesignWare Ethernet PCS >>> + >>> +maintainers: >>> + - Coia Prant >>> + >>> +description: | >>> + Rockchip RK3568 SoC integrates a Synopsys DesignWare Ethernet Physical >>> + Coding Sublayer (XPCS). >>> + The PCS provides an interface between the Media Access Control (MAC) >>> + and the Physical Medium Attachment (PMA) sublayer through a Media >>> + Independent Interface (GMII). >>> + >>> + The XPCS is accessed over the APB3 bus and internally connected to a >>> + Naneng Combo SerDes PHY. >>> + It supports 1000BASE-X, SGMII and QSGMII modes. >>> + >>> + The block contains four MII ports (pcs-mii@0..3) that can be >>> + individually enabled and routed to one of the Ethernet GMAC controllers >>> + via the pcs-handle property in the MAC device tree node. > > 1. Commit message: I'll drop the redundant description paragraph and keep > only the essential information. > > 2. Subject: I'll drop the redundant "binding" word. > >> +properties: >> + compatible: >> + const: rockchip,rk3568-xpcs >> + >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 > > 3. reg order: I'll move reg to the second property (after compatible). > > 4. Quotes: I'll use consistent quoting style throughout. > >> + reg: >> + description: | >> + Base address and size of the XPCS register space mapped over the >> + APB3 bus. > > 5. reg description: I'll drop it as redundant. > >> + clocks: >> + description: | >> + Clock sources for the XPCS: >> + - csr: APB3 bus interface clock (clk_csr_i), required for register >> + access. >> + - eee: EEE clock (clk_eee_i), required for Energy Efficient >> + Ethernet (EEE) operation. >> + minItems: 2 >> + maxItems: 2 > > 6. clocks: I'll change to items with descriptions instead of min/maxItems. > >> + clock-names: >> + items: >> + - const: csr >> + - const: eee >> + >> + phys: >> + description: | > > 7. description formatting: I'll remove unnecessary '|' where not needed. > >> + power-domains: >> + description: | >> + Power domain for the XPCS. > > 8. power-domains description: I'll drop the redundant part. I don't understand any of these. There are none of my quotes. I don't get what you are referring to. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 724FCC55838 for ; Thu, 6 Aug 2026 06:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N8RY/hi07orTmtMgeIA/V45iGoEUPRxoBkoIVspQXuQ=; b=4A1fLViA7Dda4j BWQPjA9qTLxs4SHECcaTRg+fYIUEwlHBxgWeX+piRzeeE9fCoSKwHYeY+jfpuQz1N/0tPmo1hc/7r iOldN+eTqquOKlxjwcSsmLYOe0aZKe+7BRHyzfD2UaRItlSw49irUNt5NDkd+REysy9dCjpFHg8CG rUNoeuqrpmVxPUdmMQ4BQW7TKWLsmP30XpgRZAB8rCSfppKiZPfH4JWJIf2mEq3z9W2roylVvTJ5K aucg2YjX17kY6tQtLAUYjn0Zg99AdYSsEF/der2fOVv3f25Q5ol/xQphSLHeQ/vvR2gXSK6QgWxH3 TtVqqGJsQhZ1W8O7GDHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrruj-000000055Ee-2wGw; Thu, 06 Aug 2026 06:49:13 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrrui-000000055EG-0RPv; Thu, 06 Aug 2026 06:49:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id BC3B760A64; Thu, 6 Aug 2026 06:49:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7202B1F000E9; Thu, 6 Aug 2026 06:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785998948; bh=3aNbsAERipFsx+yzQGv3WCU2Y9Zc5fWn7EPOiXhK8f8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=fUjhy0vLKfClXxk6YvO7DPT0idsViF/fGh4Q8xpBEsMQnDrYmDR+FPbrSlP8klYpi CspRJKPJ0NcfRS4q20LNYzEjh2chLl6jfqUnU4f8aN0/lQV1EJG8YpqvQzqTfSmD71 2SRYTMjbFvmfdoRa7VjCqWLPGkWbPW8RwEC8zjxHzu5adB0cCv29A14MBKLcVGA+in eqWSuRlIhCWXWL6US0yrikt+i0Dbh3Ji7PIjPqAhmcYHLIklA9l+a7U9YC0OOeOMIr JqJcJ2Z2RCx7QNRjJqrZ8b+y+7tzu+wuSyPgHnYgyqXhgkvq0+lCY13c1DVrNzEQTJ TZTbeNDC6Ma1g== Message-ID: Date: Thu, 6 Aug 2026 08:48:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/10] dt-bindings: net: pcs: add rockchip,rk3568-xpcs binding To: Coia Prant Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Vinod Koul , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Romain Gantois , Heiner Kallweit , Neil Armstrong , Russell King , Shawn Lin , David Heidelberg , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org References: <20260801142244.679437-2-coiaprant@gmail.com> <20260801142244.679437-6-coiaprant@gmail.com> <20260805-stirring-wondrous-mule-faf37d@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 05/08/2026 19:20, Coia Prant wrote: > Hi Krzysztof, > > Thanks for the detailed review. Here's my response to each point: > >>> +title: Rockchip RK3568 Synopsys DesignWare Ethernet PCS >>> + >>> +maintainers: >>> + - Coia Prant >>> + >>> +description: | >>> + Rockchip RK3568 SoC integrates a Synopsys DesignWare Ethernet Physical >>> + Coding Sublayer (XPCS). >>> + The PCS provides an interface between the Media Access Control (MAC) >>> + and the Physical Medium Attachment (PMA) sublayer through a Media >>> + Independent Interface (GMII). >>> + >>> + The XPCS is accessed over the APB3 bus and internally connected to a >>> + Naneng Combo SerDes PHY. >>> + It supports 1000BASE-X, SGMII and QSGMII modes. >>> + >>> + The block contains four MII ports (pcs-mii@0..3) that can be >>> + individually enabled and routed to one of the Ethernet GMAC controllers >>> + via the pcs-handle property in the MAC device tree node. > > 1. Commit message: I'll drop the redundant description paragraph and keep > only the essential information. > > 2. Subject: I'll drop the redundant "binding" word. > >> +properties: >> + compatible: >> + const: rockchip,rk3568-xpcs >> + >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 > > 3. reg order: I'll move reg to the second property (after compatible). > > 4. Quotes: I'll use consistent quoting style throughout. > >> + reg: >> + description: | >> + Base address and size of the XPCS register space mapped over the >> + APB3 bus. > > 5. reg description: I'll drop it as redundant. > >> + clocks: >> + description: | >> + Clock sources for the XPCS: >> + - csr: APB3 bus interface clock (clk_csr_i), required for register >> + access. >> + - eee: EEE clock (clk_eee_i), required for Energy Efficient >> + Ethernet (EEE) operation. >> + minItems: 2 >> + maxItems: 2 > > 6. clocks: I'll change to items with descriptions instead of min/maxItems. > >> + clock-names: >> + items: >> + - const: csr >> + - const: eee >> + >> + phys: >> + description: | > > 7. description formatting: I'll remove unnecessary '|' where not needed. > >> + power-domains: >> + description: | >> + Power domain for the XPCS. > > 8. power-domains description: I'll drop the redundant part. I don't understand any of these. There are none of my quotes. I don't get what you are referring to. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A94AC55ABF for ; Thu, 6 Aug 2026 06:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xOj67LMa0525iEFjfQU8tT8aBs482WVvbs49Z+NGzvw=; b=BwVGCFYt5jI5oo 1biuOSSHybAZSJBuGE4+Ascy2/BklfN05ztDaieTO50OSAEatpArMy0w0RZyonQ22dMb0kDmCUrb7 W41+EgZT/W5TWVo3oyGJq6yGvRmBtTW9QwK6fV5n+iq2Ps6EzAHdij2N9rLQGTpKW/rUwTlUC2qQ+ 7DEOpVCt7rxwnMpSvFPmn0HcFr6L6bNMm9DwCx7PUG0ZPshUtl/oXsU2V20JjiIOKXhSI3+cj0V9k qJTdEaPKCzLH+tU7Zu9N65fqmfaexptz47Pr3B6NJ4WQ87R5rOCnvXdo2OsCbAs7y10jUxjdpxN5U XhJ6T1r8pVRk2FP6z2rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrruj-000000055Ea-2lvr; Thu, 06 Aug 2026 06:49:13 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrrui-000000055EG-0RPv; Thu, 06 Aug 2026 06:49:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id BC3B760A64; Thu, 6 Aug 2026 06:49:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7202B1F000E9; Thu, 6 Aug 2026 06:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785998948; bh=3aNbsAERipFsx+yzQGv3WCU2Y9Zc5fWn7EPOiXhK8f8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=fUjhy0vLKfClXxk6YvO7DPT0idsViF/fGh4Q8xpBEsMQnDrYmDR+FPbrSlP8klYpi CspRJKPJ0NcfRS4q20LNYzEjh2chLl6jfqUnU4f8aN0/lQV1EJG8YpqvQzqTfSmD71 2SRYTMjbFvmfdoRa7VjCqWLPGkWbPW8RwEC8zjxHzu5adB0cCv29A14MBKLcVGA+in eqWSuRlIhCWXWL6US0yrikt+i0Dbh3Ji7PIjPqAhmcYHLIklA9l+a7U9YC0OOeOMIr JqJcJ2Z2RCx7QNRjJqrZ8b+y+7tzu+wuSyPgHnYgyqXhgkvq0+lCY13c1DVrNzEQTJ TZTbeNDC6Ma1g== Message-ID: Date: Thu, 6 Aug 2026 08:48:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/10] dt-bindings: net: pcs: add rockchip,rk3568-xpcs binding To: Coia Prant Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Vinod Koul , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Romain Gantois , Heiner Kallweit , Neil Armstrong , Russell King , Shawn Lin , David Heidelberg , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org References: <20260801142244.679437-2-coiaprant@gmail.com> <20260801142244.679437-6-coiaprant@gmail.com> <20260805-stirring-wondrous-mule-faf37d@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 05/08/2026 19:20, Coia Prant wrote: > Hi Krzysztof, > > Thanks for the detailed review. Here's my response to each point: > >>> +title: Rockchip RK3568 Synopsys DesignWare Ethernet PCS >>> + >>> +maintainers: >>> + - Coia Prant >>> + >>> +description: | >>> + Rockchip RK3568 SoC integrates a Synopsys DesignWare Ethernet Physical >>> + Coding Sublayer (XPCS). >>> + The PCS provides an interface between the Media Access Control (MAC) >>> + and the Physical Medium Attachment (PMA) sublayer through a Media >>> + Independent Interface (GMII). >>> + >>> + The XPCS is accessed over the APB3 bus and internally connected to a >>> + Naneng Combo SerDes PHY. >>> + It supports 1000BASE-X, SGMII and QSGMII modes. >>> + >>> + The block contains four MII ports (pcs-mii@0..3) that can be >>> + individually enabled and routed to one of the Ethernet GMAC controllers >>> + via the pcs-handle property in the MAC device tree node. > > 1. Commit message: I'll drop the redundant description paragraph and keep > only the essential information. > > 2. Subject: I'll drop the redundant "binding" word. > >> +properties: >> + compatible: >> + const: rockchip,rk3568-xpcs >> + >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 > > 3. reg order: I'll move reg to the second property (after compatible). > > 4. Quotes: I'll use consistent quoting style throughout. > >> + reg: >> + description: | >> + Base address and size of the XPCS register space mapped over the >> + APB3 bus. > > 5. reg description: I'll drop it as redundant. > >> + clocks: >> + description: | >> + Clock sources for the XPCS: >> + - csr: APB3 bus interface clock (clk_csr_i), required for register >> + access. >> + - eee: EEE clock (clk_eee_i), required for Energy Efficient >> + Ethernet (EEE) operation. >> + minItems: 2 >> + maxItems: 2 > > 6. clocks: I'll change to items with descriptions instead of min/maxItems. > >> + clock-names: >> + items: >> + - const: csr >> + - const: eee >> + >> + phys: >> + description: | > > 7. description formatting: I'll remove unnecessary '|' where not needed. > >> + power-domains: >> + description: | >> + Power domain for the XPCS. > > 8. power-domains description: I'll drop the redundant part. I don't understand any of these. There are none of my quotes. I don't get what you are referring to. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy